[{"id":37855,"web_url":"https://patchwork.libcamera.org/comment/37855/","msgid":"<176907340727.3882822.13107311074465051967@neptunite.rasen.tech>","date":"2026-01-22T09:16:47","subject":"Re: [PATCH v1 21/35] libcamera: v4l2_videodevice: Do not hide frame\n\tdrops","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:45)\n> From: Jacopo Mondi \n> \n> We want to be able to identify them correctly.\n\nafaict the patch contents don't match this message.\n\n\nPaul\n\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/internal/v4l2_videodevice.h | 1 -\n> src/libcamera/v4l2_videodevice.cpp | 15 ---------------\n> 2 files changed, 16 deletions(-)\n> \n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index 2d290971a0ee..a19fca1719d3 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -286,7 +286,6 @@ private:\n> EventNotifier *fdBufferNotifier_;\n> \n> State state_;\n> - std::optional firstFrame_;\n> \n> Timer watchdog_;\n> utils::Duration watchdogDuration_;\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 8ce739f4bc65..56a9f0ab546f 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1904,19 +1904,6 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> if (V4L2_TYPE_IS_OUTPUT(buf.type))\n> return buffer;\n> \n> - /*\n> - * Detect kernel drivers which do not reset the sequence number to zero\n> - * on stream start.\n> - */\n> - if (!firstFrame_.has_value()) {\n> - if (buf.sequence)\n> - LOG(V4L2, Info)\n> - << \"Zero sequence expected for first frame (got \"\n> - << buf.sequence << \")\";\n> - firstFrame_ = buf.sequence;\n> - }\n> - metadata.sequence -= firstFrame_.value();\n> -\n> Span framebufferPlanes = buffer->planes();\n> unsigned int numV4l2Planes = multiPlanar ? buf.length : 1;\n> \n> @@ -1993,8 +1980,6 @@ int V4L2VideoDevice::streamOn()\n> {\n> int ret;\n> \n> - firstFrame_.reset();\n> -\n> ret = ioctl(VIDIOC_STREAMON, &bufferType_);\n> if (ret < 0) {\n> LOG(V4L2, Error)\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C212BDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:16:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC59161FD9;\n\tThu, 22 Jan 2026 10:16:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73A6661FC4\n\tfor ;\n\tThu, 22 Jan 2026 10:16:53 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 86FB02DD;\n\tThu, 22 Jan 2026 10:16:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lUSbnb/Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073381;\n\tbh=JjRWsw2VsQMIU2+IEj9Y8Pxv33k7SB2YLwsFGnKDPc0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lUSbnb/QD39xU1qXkqVYxaymsF6E1XLiX4Q9y+QcPoQsWFGDcj7KMCrhs/UZwe7jD\n\tM7XSgjt03lPxsbOLkE/OqkQs6EzPR11sj1ByiHTqeXRpqmfbHzkIQUnkl87ghB+02p\n\t4j9OL+UWyPEGbM8LOdk2H2zG4bdOMpqmCybz1zFk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-22-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-22-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 21/35] libcamera: v4l2_videodevice: Do not hide frame\n\tdrops","From":"Paul Elder ","Cc":"Stefan Klug ,\n\tJacopo Mondi ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:16:47 +0900","Message-ID":"<176907340727.3882822.13107311074465051967@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]