{"id":24786,"url":"https://patchwork.libcamera.org/api/patches/24786/?format=json","web_url":"https://patchwork.libcamera.org/patch/24786/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-21-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:44","name":"[v1,20/35] libcamera: delayed_controls: Ignore double pushes for the same frame number","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a3ae43c2cae578f1d22636e48a130fc8cba50f68","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24786/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24786/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24786/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D179C3259\n\tfor ;\n\tFri, 24 Oct 2025 08:52:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D02C7608DF;\n\tFri, 24 Oct 2025 10:52:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51B60608C7\n\tfor ;\n\tFri, 24 Oct 2025 10:52:37 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D68E71AC5; \n\tFri, 24 Oct 2025 10:50:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gDnT7cTc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295851;\n\tbh=GHDBZhxUClPjiTGikBMuLaR34/ZPU/bFsMTzDclcYuU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gDnT7cTcwjVT64MFc6NleIwaCgDKYko1VWZpAZfbjqVPR10XpXgLcNQS0uH+ZG6D/\n\tqLx+EEdFn0JGhMBWcskypR/Ok1kbivogx5v1Nn2B1a9yzGgccxihVLKOG0JalF4rkV\n\tOsi0M4nBdI6PlbHHHbtl050FRMh+kShP5zUR4eUI=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 20/35] libcamera: delayed_controls: Ignore double pushes\n\tfor the same frame number","Date":"Fri, 24 Oct 2025 10:50:44 +0200","Message-ID":"<20251024085130.995967-21-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For successful PFC a single sequence must only be pushed once to delayed\ncontrols. Such a situation can occur if no-ops were pushed in delayed\ncontrols due to a buffer underrun.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/delayed_controls.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 8239f3dcf347..3dead0dc4429 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -176,6 +176,8 @@ bool DelayedControls::push(uint32_t sequence, const ControlList &controls)\n \t\tLOG(DelayedControls, Warning)\n \t\t\t<< \"Double push for sequence \" << sequence\n \t\t\t<< \" current queue index: \" << queueCount_;\n+\t\tLOG(DelayedControls, Warning) << \"ignore silently\";\n+\t\treturn true;\n \t}\n \n \twhile (sequence > queueCount_) {\n@@ -278,7 +280,11 @@ ControlList DelayedControls::get(uint32_t sequence)\n */\n void DelayedControls::applyControls(uint32_t sequence)\n {\n-\tLOG(DelayedControls, Debug) << \"frame \" << sequence << \" started\";\n+\tLOG(DelayedControls, Debug)\n+\t\t<< \"Apply controls for: \" << sequence\n+\t\t<< \" expected: \" << writeCount_\n+\t\t<< \" (instant controls for frame \"\n+\t\t<< (sequence - maxDelay_) << \")\";\n \n \twhile (queueCount_ - 1 < sequence) {\n \t\tLOG(DelayedControls, Warning)\n","prefixes":["v1","20/35"]}