[{"id":37852,"web_url":"https://patchwork.libcamera.org/comment/37852/","msgid":"<176907338485.3882822.979524862005553156@neptunite.rasen.tech>","date":"2026-01-22T09:16:24","subject":"Re: [PATCH v1 17/35] ipa: rkisp1: agc: Fix vblank,\n\twhen computeParams prepare is not called","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:41)\n> In raw capture mode, prepare() is not called at all. Ensure that vblank\n> is still calculated corresctly.\n\ns/corresctly/correctly/\n\n> \n> Signed-off-by: Stefan Klug \n\nI'd prefer this squashed with the previous patch.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 5ce77b7672f2..7c9538f95cbe 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -340,6 +340,9 @@ void Agc::queueRequest(IPAContext &context,\n> }\n> frameContext.agc.minFrameDuration = agc.minFrameDuration;\n> frameContext.agc.maxFrameDuration = agc.maxFrameDuration;\n> +\n> + /* V-blank needs to be valid for the start controls handling. Update it. */\n> + processFrameDuration(context, frameContext);\n> }\n> \n> /**\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DDECBDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:16:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0CA7861FE7;\n\tThu, 22 Jan 2026 10:16:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0CEB61FC4\n\tfor ;\n\tThu, 22 Jan 2026 10:16:30 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D15902DD;\n\tThu, 22 Jan 2026 10:15:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dpazEbgL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073358;\n\tbh=RElVQnlubAkEjf6hHK2uCbO8ZssO0LmHXfltYojZ+NQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=dpazEbgL2IakGNTNN71RIGdXEDg+o3KIPPubzLen45VLqHh+NapTXdbNeXNS0SeX3\n\t+FwOLegd+1/JNfwT8MrnHgLGzp48okjCg++oKX1LjBfs5ofjbK/Gml/a4SJkF5hKUc\n\tZqw2DzOU6UrJcvqAYnjoDqlHiNkZwpHwTZxaLEmg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-18-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-18-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 17/35] ipa: rkisp1: agc: Fix vblank,\n\twhen computeParams prepare is not called","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:16:24 +0900","Message-ID":"<176907338485.3882822.979524862005553156@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]