{"id":24783,"url":"https://patchwork.libcamera.org/api/patches/24783/?format=json","web_url":"https://patchwork.libcamera.org/patch/24783/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-18-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:41","name":"[v1,17/35] ipa: rkisp1: agc: Fix vblank, when computeParams prepare is not called","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2c590a0610d77de267f97ea91ad599adedc7c26f","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24783/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24783/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24783/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87598C3259\n\tfor ;\n\tFri, 24 Oct 2025 08:52:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 57269608D1;\n\tFri, 24 Oct 2025 10:52:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C63E3608C3\n\tfor ;\n\tFri, 24 Oct 2025 10:52:28 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 55D4921D0; \n\tFri, 24 Oct 2025 10:50:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"utCxFLu3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295843;\n\tbh=tJZqo5Jgcw4iWuPX5RG+D/HiDG+3K7kFUCiaYJdlh7E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=utCxFLu3vZU/xwqzajsGRbsOU0N3gw1DXPyi5S7LaNW8llWbDV2Q/6xGCOrAmBYmE\n\tqEVe9dhggNcaRvo+UstpVQbtMHvf2Xm+PBGK6OypInd3FAc4UVT54w6sZJPD89EmCN\n\t3ZW1R3cpcMPx6Hh8aGMO1vnK5tBPvEQwi3eD57ns=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 17/35] ipa: rkisp1: agc: Fix vblank,\n\twhen computeParams prepare is not called","Date":"Fri, 24 Oct 2025 10:50:41 +0200","Message-ID":"<20251024085130.995967-18-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In raw capture mode, prepare() is not called at all. Ensure that vblank\nis still calculated corresctly.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 5ce77b7672f2..7c9538f95cbe 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -340,6 +340,9 @@ void Agc::queueRequest(IPAContext &context,\n \t}\n \tframeContext.agc.minFrameDuration = agc.minFrameDuration;\n \tframeContext.agc.maxFrameDuration = agc.maxFrameDuration;\n+\n+\t/* V-blank needs to be valid for the start controls handling. Update it. */\n+\tprocessFrameDuration(context, frameContext);\n }\n \n /**\n","prefixes":["v1","17/35"]}