[{"id":37845,"web_url":"https://patchwork.libcamera.org/comment/37845/","msgid":"<176907332721.3882822.12322091810392561101@neptunite.rasen.tech>","date":"2026-01-22T09:15:27","subject":"Re: [PATCH v1 07/35] libipa: fc_queue: Rename template argument to\n\tFC","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:31)\n> The FCQueue has a template argument called FrameContext which is easily\n> confused with the class FrameContext defined in the same file.\n> \n> Reduce that confusion by renaming the template argument to FC.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/fc_queue.h | 16 ++++++++--------\n> 1 file changed, 8 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h\n> index a1d136521107..1f4f84c27fbc 100644\n> --- a/src/ipa/libipa/fc_queue.h\n> +++ b/src/ipa/libipa/fc_queue.h\n> @@ -28,7 +28,7 @@ private:\n> bool initialised = false;\n> };\n> \n> -template\n> +template\n> class FCQueue\n> {\n> public:\n> @@ -39,15 +39,15 @@ public:\n> \n> void clear()\n> {\n> - for (FrameContext &ctx : contexts_) {\n> + for (FC &ctx : contexts_) {\n> ctx.initialised = false;\n> ctx.frame = 0;\n> }\n> }\n> \n> - FrameContext &alloc(const uint32_t frame)\n> + FC &alloc(const uint32_t frame)\n> {\n> - FrameContext &frameContext = contexts_[frame % contexts_.size()];\n> + FC &frameContext = contexts_[frame % contexts_.size()];\n> \n> /*\n> * Do not re-initialise if a get() call has already fetched this\n> @@ -69,9 +69,9 @@ public:\n> return frameContext;\n> }\n> \n> - FrameContext &get(uint32_t frame)\n> + FC &get(uint32_t frame)\n> {\n> - FrameContext &frameContext = contexts_[frame % contexts_.size()];\n> + FC &frameContext = contexts_[frame % contexts_.size()];\n> \n> /*\n> * If the IPA algorithms try to access a frame context slot which\n> @@ -122,14 +122,14 @@ public:\n> }\n> \n> private:\n> - void init(FrameContext &frameContext, const uint32_t frame)\n> + void init(FC &frameContext, const uint32_t frame)\n> {\n> frameContext = {};\n> frameContext.frame = frame;\n> frameContext.initialised = true;\n> }\n> \n> - std::vector contexts_;\n> + std::vector contexts_;\n> };\n> \n> } /* namespace ipa */\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB0B6BDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:15:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5381E61FCA;\n\tThu, 22 Jan 2026 10:15:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB4C161FBF\n\tfor ;\n\tThu, 22 Jan 2026 10:15:32 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0FA24324;\n\tThu, 22 Jan 2026 10:14:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s3c80+Ub\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073300;\n\tbh=8uMaBjMd2hKg8sqMtqPvkFaotiw96WJVWx/OS+NaEJc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=s3c80+UbzDxVNiuJFVSVDG0I9zzwCDoyty5ZdCTjdY3AH96b2u79wVveEuiQtiYlB\n\t2Btd+hY8Y+6F8ytPEaXNgmF3pcrjRolUZDx0K6i6G2E0lvB5mheFCnFpJDStng1hR6\n\tugXUZLZegi2bAtzfqgMxk6YyH0MLmc0F7CrICYf4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-8-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-8-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 07/35] libipa: fc_queue: Rename template argument to\n\tFC","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:15:27 +0900","Message-ID":"<176907332721.3882822.12322091810392561101@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]