{"id":24773,"url":"https://patchwork.libcamera.org/api/patches/24773/?format=json","web_url":"https://patchwork.libcamera.org/patch/24773/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-8-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:31","name":"[v1,07/35] libipa: fc_queue: Rename template argument to FC","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6fd2a64bd6106a2a5e15cfbd9fb98a2e107d624c","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24773/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24773/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24773/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF60AC3259\n\tfor ;\n\tFri, 24 Oct 2025 08:51:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0F376088A;\n\tFri, 24 Oct 2025 10:51:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B15A160885\n\tfor ;\n\tFri, 24 Oct 2025 10:51:57 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 45C941E27; \n\tFri, 24 Oct 2025 10:50:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"INlwBde7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295812;\n\tbh=+ZZrzTMcv9YU/56qGVrqM49B6OtaxaqtMvBF+pG0kww=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=INlwBde7WR2/RlQpVcCj8trRxjBVIKwZlbCtB0L1vt7PWeXihPaaCnQGNreQfcj0M\n\tytnzc2H63xJ3LAGenyE+naCM3W6tLTdHvW1zMtVDcFXza1rSWA6Zx9kkzW7ha4t6rH\n\tEZzCEih5UPqPB8QKuYMkdezybRZ/qApFv1eT7d8Y=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 07/35] libipa: fc_queue: Rename template argument to FC","Date":"Fri, 24 Oct 2025 10:50:31 +0200","Message-ID":"<20251024085130.995967-8-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The FCQueue has a template argument called FrameContext which is easily\nconfused with the class FrameContext defined in the same file.\n\nReduce that confusion by renaming the template argument to FC.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/libipa/fc_queue.h | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/src/ipa/libipa/fc_queue.h b/src/ipa/libipa/fc_queue.h\nindex a1d136521107..1f4f84c27fbc 100644\n--- a/src/ipa/libipa/fc_queue.h\n+++ b/src/ipa/libipa/fc_queue.h\n@@ -28,7 +28,7 @@ private:\n \tbool initialised = false;\n };\n \n-template\n+template\n class FCQueue\n {\n public:\n@@ -39,15 +39,15 @@ public:\n \n \tvoid clear()\n \t{\n-\t\tfor (FrameContext &ctx : contexts_) {\n+\t\tfor (FC &ctx : contexts_) {\n \t\t\tctx.initialised = false;\n \t\t\tctx.frame = 0;\n \t\t}\n \t}\n \n-\tFrameContext &alloc(const uint32_t frame)\n+\tFC &alloc(const uint32_t frame)\n \t{\n-\t\tFrameContext &frameContext = contexts_[frame % contexts_.size()];\n+\t\tFC &frameContext = contexts_[frame % contexts_.size()];\n \n \t\t/*\n \t\t * Do not re-initialise if a get() call has already fetched this\n@@ -69,9 +69,9 @@ public:\n \t\treturn frameContext;\n \t}\n \n-\tFrameContext &get(uint32_t frame)\n+\tFC &get(uint32_t frame)\n \t{\n-\t\tFrameContext &frameContext = contexts_[frame % contexts_.size()];\n+\t\tFC &frameContext = contexts_[frame % contexts_.size()];\n \n \t\t/*\n \t\t * If the IPA algorithms try to access a frame context slot which\n@@ -122,14 +122,14 @@ public:\n \t}\n \n private:\n-\tvoid init(FrameContext &frameContext, const uint32_t frame)\n+\tvoid init(FC &frameContext, const uint32_t frame)\n \t{\n \t\tframeContext = {};\n \t\tframeContext.frame = frame;\n \t\tframeContext.initialised = true;\n \t}\n \n-\tstd::vector contexts_;\n+\tstd::vector contexts_;\n };\n \n } /* namespace ipa */\n","prefixes":["v1","07/35"]}