[{"id":37843,"web_url":"https://patchwork.libcamera.org/comment/37843/","msgid":"<176907331165.3882822.12897043857608695683@neptunite.rasen.tech>","date":"2026-01-22T09:15:11","subject":"Re: [PATCH v1 06/35] pipeline: rkisp1: Include frame number when\n\tpushing to delayed controls","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:30)\n> Pass the frame number when pushing to delayed controls, to ease further\n> development.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index fef6e23e39b7..17250cbd5ae6 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -524,10 +524,10 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n> selfPath_->queueBuffer(info->selfPathBuffer);\n> }\n> \n> -void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,\n> +void RkISP1CameraData::setSensorControls(unsigned int frame,\n> const ControlList &sensorControls)\n> {\n> - delayedCtrls_->push(sensorControls);\n> + delayedCtrls_->push(frame, sensorControls);\n> }\n> \n> void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 859AFBDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:15:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 392AB61FC8;\n\tThu, 22 Jan 2026 10:15:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5D3E61FBF\n\tfor ;\n\tThu, 22 Jan 2026 10:15:17 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B3AAD9CE;\n\tThu, 22 Jan 2026 10:14:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kNYrw++D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073285;\n\tbh=xAuDFZ6KbXSIT4lmoS3NO9+Gz+pqkY0nc47Shjv+4jM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=kNYrw++Dc30tjBqjkFr+drWcF/Dc7kzH99fYV751rjlLf6XohDjJdytl+zFL2cc1N\n\t+loaXDgcMnXFcSCc7DO7ETh4bmAUYqwBTn8u5LyDlq0kBdDLJdKSYC+LlpH/hYvc+J\n\tI6zLvhYAUk/1+6VZBJXJHmw1p1j5jVlPpFAoarIA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-7-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-7-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 06/35] pipeline: rkisp1: Include frame number when\n\tpushing to delayed controls","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:15:11 +0900","Message-ID":"<176907331165.3882822.12897043857608695683@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]