[{"id":37842,"web_url":"https://patchwork.libcamera.org/comment/37842/","msgid":"<176907330252.3882822.13234303056384614191@neptunite.rasen.tech>","date":"2026-01-22T09:15:02","subject":"Re: [PATCH v1 05/35] libcamera: delayed_controls: Add maxDelay()\n\tfunction","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:29)\n> Add a maxDelay() function to be able to query the maximum delay of\n> the sensor.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n\nExtra line :)\n\nOtherwise,\n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/delayed_controls.h | 2 ++\n> src/libcamera/delayed_controls.cpp | 7 +++++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\n> index c650e672d964..3182ebddd1fa 100644\n> --- a/include/libcamera/internal/delayed_controls.h\n> +++ b/include/libcamera/internal/delayed_controls.h\n> @@ -35,6 +35,8 @@ public:\n> bool push(uint32_t sequence, const ControlList &controls);\n> ControlList get(uint32_t sequence);\n> \n> + uint32_t maxDelay() const { return maxDelay_; }\n> +\n> void applyControls(uint32_t sequence);\n> \n> private:\n> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\n> index 67213fe87d53..35a624525b80 100644\n> --- a/src/libcamera/delayed_controls.cpp\n> +++ b/src/libcamera/delayed_controls.cpp\n> @@ -259,6 +259,13 @@ ControlList DelayedControls::get(uint32_t sequence)\n> return out;\n> }\n> \n> +/**\n> + * \\fn DelayedControls::maxDelay()\n> + * \\brief Get the maximum delay of the sensor\n> + *\n> + * \\return The maximum delay of the sensor\n> + */\n> +\n> /**\n> * \\brief Inform DelayedControls of the start of a new frame\n> * \\param[in] sequence Sequence number of the frame that started\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37D8CBDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:15:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D634B61FD3;\n\tThu, 22 Jan 2026 10:15:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFCEF61FBF\n\tfor ;\n\tThu, 22 Jan 2026 10:15:10 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C4E872DD;\n\tThu, 22 Jan 2026 10:14:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KpjhytuY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073278;\n\tbh=LAeBKzOl3u1zy1QWgYYee8foZC92e7begPl3ZcfQxAw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=KpjhytuYJ2jQCzXv9jo6F9eixriSxONEvt2lZsY4A+wANHacQKsGImSCmTvO8CGJt\n\tFII39x211JOQR+jou+YMLmUW6rAVZkwJwDr+ABDr/VPEcNY/ObPmmfxPjeqDlx/OK/\n\tiS3SBJRs3huotBzsDRri2feZFOk7podoh5tO0VPU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-6-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-6-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 05/35] libcamera: delayed_controls: Add maxDelay()\n\tfunction","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:15:02 +0900","Message-ID":"<176907330252.3882822.13234303056384614191@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]