[{"id":37839,"web_url":"https://patchwork.libcamera.org/comment/37839/","msgid":"<176907327821.3882822.2275641181310749679@neptunite.rasen.tech>","date":"2026-01-22T09:14:38","subject":"Re: [PATCH v1 02/35] libcamera: delayed_controls: Handle missed\n\tpushes","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-24 17:50:26)\n> In unstable systems it can happen, that some sequence numbers are missed\n> in the IPA. Gracefully handle that situation by queuing no-ops.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/delayed_controls.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\n> index 246e7cefa4e5..e5bdc374fd0e 100644\n> --- a/src/libcamera/delayed_controls.cpp\n> +++ b/src/libcamera/delayed_controls.cpp\n> @@ -178,6 +178,15 @@ bool DelayedControls::push(uint32_t sequence, const ControlList &controls)\n> << \" current queue index: \" << queueCount_;\n> }\n> \n> + while (sequence > queueCount_) {\n> + LOG(DelayedControls, Warning)\n> + << \"Missed push for sequence \" << queueCount_\n> + << \" Auto queue no-op.\";\n> + push(queueCount_, {});\n> + }\n> +\n> + ASSERT(sequence == queueCount_);\n> +\n> /* Copy state from previous frame. */\n> for (auto &ctrl : values_) {\n> Info &info = ctrl.second[queueCount_];\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 501E1BDCBF\n\tfor ;\n\tThu, 22 Jan 2026 09:14:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 135DE61FC5;\n\tThu, 22 Jan 2026 10:14:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B479B61FA0\n\tfor ;\n\tThu, 22 Jan 2026 10:14:46 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CA8962DD;\n\tThu, 22 Jan 2026 10:14:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ozhKSU7P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073254;\n\tbh=TqabmJfIfbNsi3MfwyUIlZtgDd0Bx9jNWUGjNWBd9Wk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ozhKSU7P5fZ2NfQIv87DLClgFBEppX3ujPozt4VKzv4wBTOIKedNQdReJ2rITQoOu\n\tZ45QMnuPEH7pQaGu0rdEXHw/73zlWoPTtothHcIDx75ncBmuCCHH2LKdTTujgc2wMe\n\tuL0u+A8S4OGn0j4DHK9u+Lek2nhB3OStKhg8pgLg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024085130.995967-3-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>\n\t<20251024085130.995967-3-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 02/35] libcamera: delayed_controls: Handle missed\n\tpushes","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 22 Jan 2026 18:14:38 +0900","Message-ID":"<176907327821.3882822.2275641181310749679@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]