{"id":24768,"url":"https://patchwork.libcamera.org/api/patches/24768/?format=json","web_url":"https://patchwork.libcamera.org/patch/24768/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024085130.995967-3-stefan.klug@ideasonboard.com>","date":"2025-10-24T08:50:26","name":"[v1,02/35] libcamera: delayed_controls: Handle missed pushes","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e3d89751a5153c518fba131dfc3ec78b4a9163c4","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24768/mbox/","series":[{"id":5524,"url":"https://patchwork.libcamera.org/api/series/5524/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5524","date":"2025-10-24T08:50:24","name":"rkisp1: pipeline rework for PFC","version":1,"mbox":"https://patchwork.libcamera.org/series/5524/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24768/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24768/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D99CDC3259\n\tfor ;\n\tFri, 24 Oct 2025 08:51:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 964C760880;\n\tFri, 24 Oct 2025 10:51:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1AD06085B\n\tfor ;\n\tFri, 24 Oct 2025 10:51:42 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7edc:62f4:c118:1549])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7E18A1AA6; \n\tFri, 24 Oct 2025 10:49:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ElW24RM9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295797;\n\tbh=nukIpOw0g1pYJyUv4O678RTC9+Rmqr1IOBx5HvTHMpU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ElW24RM9rIXhN334LY0KYIYCm3KsGj+NfbDZXT+vVquQJzTvjX6QTNG66vYog7zpF\n\trF5yFl8cd4APJPPybSnlSKG6YHMjNc4mKpbH6LuDo3zXXvT+Ym+VVnig13IT2+oDEw\n\tPFD3vJ85+2S1KAcDcJCHiuMal6/3XkZeOnCxfx14=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 02/35] libcamera: delayed_controls: Handle missed pushes","Date":"Fri, 24 Oct 2025 10:50:26 +0200","Message-ID":"<20251024085130.995967-3-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","References":"<20251024085130.995967-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In unstable systems it can happen, that some sequence numbers are missed\nin the IPA. Gracefully handle that situation by queuing no-ops.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/delayed_controls.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 246e7cefa4e5..e5bdc374fd0e 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -178,6 +178,15 @@ bool DelayedControls::push(uint32_t sequence, const ControlList &controls)\n \t\t\t<< \" current queue index: \" << queueCount_;\n \t}\n \n+\twhile (sequence > queueCount_) {\n+\t\tLOG(DelayedControls, Warning)\n+\t\t\t<< \"Missed push for sequence \" << queueCount_\n+\t\t\t<< \" Auto queue no-op.\";\n+\t\tpush(queueCount_, {});\n+\t}\n+\n+\tASSERT(sequence == queueCount_);\n+\n \t/* Copy state from previous frame. */\n \tfor (auto &ctrl : values_) {\n \t\tInfo &info = ctrl.second[queueCount_];\n","prefixes":["v1","02/35"]}