[{"id":36419,"web_url":"https://patchwork.libcamera.org/comment/36419/","msgid":"<176129428044.199266.13123043626327677551@ping.linuxembedded.co.uk>","date":"2025-10-24T08:24:40","subject":"Re: [RFC PATCH v2] libipa: camera_sensor_helper: Add imx708","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-10-24 08:54:59)\n> From: Daniel Scally \n> \n> The imx708 sensor driver has long been available, especially in raspberry\n> pi kernels; and the raspberry pi ipa module has had the corresponding\n> helper class since 2023 (952ef94ed78d71). The camera sensor properties\n> database also has an entry for it (2fb0f250196326), but the camera sensor\n> helper class is missing from the common libipa component. So add it, with\n> the same gain formula as the raspberry pi ipa module.\n> \n> Handling the raspberry pi specific \"wide\" / \"noir\" suffixes is omitted.\n> They are not present in the camera sensor properties database either.\n> \n> Signed-off-by: Daniel Scally \n> [Extend commit message.]\n> Signed-off-by: Barnabás Pőcze \n> ---\n> changes in v2:\n> * drop rpi specific suffixes\n> \n> v1: https://patchwork.libcamera.org/patch/24708/\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index ef3bd0d62..1f2a95e56 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -642,6 +642,16 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> \n> +class CameraSensorHelperImx708 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperImx708()\n> + {\n\nCan you add the blackLevel_ in here please? I expect it can be obtained\nfrom the Raspberry Pi tuning files.\n\n> + gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n> +\n> class CameraSensorHelperOv2685 : public CameraSensorHelper\n> {\n> public:\n> --\n> 2.51.1.dirty","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADB7FBE080\n\tfor ;\n\tFri, 24 Oct 2025 08:24:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2E8760871;\n\tFri, 24 Oct 2025 10:24:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37A2360817\n\tfor ;\n\tFri, 24 Oct 2025 10:24:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9E9AAB4;\n\tFri, 24 Oct 2025 10:22:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BgL+fyAH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761294177;\n\tbh=x7i0cYwEt32VX4PbCcvTIeriPv6WKkQybuMYbePnJGM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=BgL+fyAHCdC7Tpm/XoaZ0cZqsf/DeufH+LbpjwJ4X38fFqwgQivgVI0FuowXzPSNs\n\tTQxcs8tcbV9oZNXoXEikzf6KXQ0sR9upJ+ilAonviN9ZyZHfFylpfZITmSW0NtHkqA\n\tS9btdpEZvyonAuO3bAYjSUpbp8eLONVuvbmAXWWs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251024075459.1200809-1-barnabas.pocze@ideasonboard.com>","References":"<20251024075459.1200809-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v2] libipa: camera_sensor_helper: Add imx708","From":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tDaniel Scally ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Oct 2025 09:24:40 +0100","Message-ID":"<176129428044.199266.13123043626327677551@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36420,"web_url":"https://patchwork.libcamera.org/comment/36420/","msgid":"<0e261533-af97-4536-89ce-a52c14ab53c2@ideasonboard.com>","date":"2025-10-24T08:37:41","subject":"Re: [RFC PATCH v2] libipa: camera_sensor_helper: Add imx708","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 24. 10:24 keltezéssel, Kieran Bingham írta:\n> Quoting Barnabás Pőcze (2025-10-24 08:54:59)\n>> From: Daniel Scally \n>>\n>> The imx708 sensor driver has long been available, especially in raspberry\n>> pi kernels; and the raspberry pi ipa module has had the corresponding\n>> helper class since 2023 (952ef94ed78d71). The camera sensor properties\n>> database also has an entry for it (2fb0f250196326), but the camera sensor\n>> helper class is missing from the common libipa component. So add it, with\n>> the same gain formula as the raspberry pi ipa module.\n>>\n>> Handling the raspberry pi specific \"wide\" / \"noir\" suffixes is omitted.\n>> They are not present in the camera sensor properties database either.\n>>\n>> Signed-off-by: Daniel Scally \n>> [Extend commit message.]\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> changes in v2:\n>> * drop rpi specific suffixes\n>>\n>> v1: https://patchwork.libcamera.org/patch/24708/\n>> ---\n>> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n>> 1 file changed, 10 insertions(+)\n>>\n>> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n>> index ef3bd0d62..1f2a95e56 100644\n>> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n>> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n>> @@ -642,6 +642,16 @@ public:\n>> };\n>> REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n>>\n>> +class CameraSensorHelperImx708 : public CameraSensorHelper\n>> +{\n>> +public:\n>> + CameraSensorHelperImx708()\n>> + {\n> \n> Can you add the blackLevel_ in here please? I expect it can be obtained\n> from the Raspberry Pi tuning files.\n\nAhh, you're right, there is that as well. I will add:\n\n blackLevel_ = 4096;\n\n\n> \n>> + gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n>> + }\n>> +};\n>> +REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n>> +\n>> class CameraSensorHelperOv2685 : public CameraSensorHelper\n>> {\n>> public:\n>> --\n>> 2.51.1.dirty","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D96BC3259\n\tfor ;\n\tFri, 24 Oct 2025 08:37:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F6436085E;\n\tFri, 24 Oct 2025 10:37:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60BD560817\n\tfor ;\n\tFri, 24 Oct 2025 10:37:45 +0200 (CEST)","from [192.168.33.13] (185.221.141.231.nat.pool.zt.hu\n\t[185.221.141.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CAC9D177F;\n\tFri, 24 Oct 2025 10:35:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HjlKeM2D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761294960;\n\tbh=iTIq9BQK9wspTPAf7DQgbIW98tJWh9YR7MXk+3tQihY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=HjlKeM2Dw9F54NLHJ88HTnDOmw0HlQgWE8Sh26SwlQeHAlO8aNtHi4TtoWJHaENrr\n\tBAAEpQg7OJVKTeqACs/BGQ8UYWZeRERM5gJ4ve9eQOFccTjxAYPR0PYjgKus2Ab2UL\n\tSZLRfWf4Jjra3Fiirt62J2BJI2evUU91J5DTQuOw=","Message-ID":"<0e261533-af97-4536-89ce-a52c14ab53c2@ideasonboard.com>","Date":"Fri, 24 Oct 2025 10:37:41 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH v2] libipa: camera_sensor_helper: Add imx708","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ,\n\tDaniel Scally ","References":"<20251024075459.1200809-1-barnabas.pocze@ideasonboard.com>\n\t<176129428044.199266.13123043626327677551@ping.linuxembedded.co.uk>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<176129428044.199266.13123043626327677551@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36421,"web_url":"https://patchwork.libcamera.org/comment/36421/","msgid":"<176129541812.199266.204712889402732098@ping.linuxembedded.co.uk>","date":"2025-10-24T08:43:38","subject":"Re: [RFC PATCH v2] libipa: camera_sensor_helper: Add imx708","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-10-24 09:37:41)\n> 2025. 10. 24. 10:24 keltezéssel, Kieran Bingham írta:\n> > Quoting Barnabás Pőcze (2025-10-24 08:54:59)\n> >> From: Daniel Scally \n> >>\n> >> The imx708 sensor driver has long been available, especially in raspberry\n> >> pi kernels; and the raspberry pi ipa module has had the corresponding\n> >> helper class since 2023 (952ef94ed78d71). The camera sensor properties\n> >> database also has an entry for it (2fb0f250196326), but the camera sensor\n> >> helper class is missing from the common libipa component. So add it, with\n> >> the same gain formula as the raspberry pi ipa module.\n> >>\n> >> Handling the raspberry pi specific \"wide\" / \"noir\" suffixes is omitted.\n> >> They are not present in the camera sensor properties database either.\n> >>\n> >> Signed-off-by: Daniel Scally \n> >> [Extend commit message.]\n> >> Signed-off-by: Barnabás Pőcze \n> >> ---\n> >> changes in v2:\n> >> * drop rpi specific suffixes\n> >>\n> >> v1: https://patchwork.libcamera.org/patch/24708/\n> >> ---\n> >> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> >> 1 file changed, 10 insertions(+)\n> >>\n> >> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> >> index ef3bd0d62..1f2a95e56 100644\n> >> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> >> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> >> @@ -642,6 +642,16 @@ public:\n> >> };\n> >> REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> >>\n> >> +class CameraSensorHelperImx708 : public CameraSensorHelper\n> >> +{\n> >> +public:\n> >> + CameraSensorHelperImx708()\n> >> + {\n> > \n> > Can you add the blackLevel_ in here please? I expect it can be obtained\n> > from the Raspberry Pi tuning files.\n> \n> Ahh, you're right, there is that as well. I will add:\n> \n> blackLevel_ = 4096;\n\nWith that:\n\nReviewed-by: Kieran Bingham \n\n> \n> \n> > \n> >> + gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n> >> + }\n> >> +};\n> >> +REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n> >> +\n> >> class CameraSensorHelperOv2685 : public CameraSensorHelper\n> >> {\n> >> public:\n> >> --\n> >> 2.51.1.dirty\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33CBDBE080\n\tfor ;\n\tFri, 24 Oct 2025 08:43:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A50B60871;\n\tFri, 24 Oct 2025 10:43:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6526060817\n\tfor ;\n\tFri, 24 Oct 2025 10:43:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95D9A177F;\n\tFri, 24 Oct 2025 10:41:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UgZ29Ifb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761295315;\n\tbh=Xy9oNTLjTylLUK3XNvMLjjtCZ4FhiKgTCS/oeeBG4/g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=UgZ29Ifbyc/3qXPcikeOGDEYumKja/0gcnlyoOQ3yJgA+oiraxK7ZjUjdyEJdvHcR\n\tqrCo/cUYAOlo1TLSuXl7HrRv7KeVqComWp004sjLw/vHHz9I5AfYQ+nLXuVNq8YnHW\n\tITNY2ycgkhXPpwwFxEHyrTQJt5UNBTPWbvmDd5zk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<0e261533-af97-4536-89ce-a52c14ab53c2@ideasonboard.com>","References":"<20251024075459.1200809-1-barnabas.pocze@ideasonboard.com>\n\t<176129428044.199266.13123043626327677551@ping.linuxembedded.co.uk>\n\t<0e261533-af97-4536-89ce-a52c14ab53c2@ideasonboard.com>","Subject":"Re: [RFC PATCH v2] libipa: camera_sensor_helper: Add imx708","From":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tDaniel Scally ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Oct 2025 09:43:38 +0100","Message-ID":"<176129541812.199266.204712889402732098@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]