{"id":24765,"url":"https://patchwork.libcamera.org/api/patches/24765/?format=json","web_url":"https://patchwork.libcamera.org/patch/24765/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251024075459.1200809-1-barnabas.pocze@ideasonboard.com>","date":"2025-10-24T07:54:59","name":"[RFC,v2] libipa: camera_sensor_helper: Add imx708","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e3438258651691fd2de280caf5980d881a954467","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24765/mbox/","series":[{"id":5523,"url":"https://patchwork.libcamera.org/api/series/5523/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5523","date":"2025-10-24T07:54:59","name":"[RFC,v2] libipa: camera_sensor_helper: Add imx708","version":2,"mbox":"https://patchwork.libcamera.org/series/5523/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24765/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24765/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D712C3259\n\tfor ;\n\tFri, 24 Oct 2025 07:55:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ACF360835;\n\tFri, 24 Oct 2025 09:55:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ABBD606E1\n\tfor ;\n\tFri, 24 Oct 2025 09:55:03 +0200 (CEST)","from pb-laptop.local (185.221.141.231.nat.pool.zt.hu\n\t[185.221.141.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 73AAD1AA6;\n\tFri, 24 Oct 2025 09:53:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YtNQ2sNJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761292397;\n\tbh=XkCiTV1TIDfRI4ulTMarSLBMJxLmjqMOz28dwhckVW0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=YtNQ2sNJN/fTJuLz4GzUkbKsolDhK8oThIwNwolDg9TUWz8+Esw0TYPpCB/1zBy28\n\tkOiYCk+tzHvSvrvtYtNLfj/XA1K1Y+kcvHUq2qwg/qpys8ubm/LIZC0LTx7cPLj9hg\n\t27l6Uaz9swrdSj8ZQX0KfVHT79Wz0WMUfX8amPqk=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tNaushir Patuck ,\n\tDaniel Scally ","Subject":"[RFC PATCH v2] libipa: camera_sensor_helper: Add imx708","Date":"Fri, 24 Oct 2025 09:54:59 +0200","Message-ID":"<20251024075459.1200809-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1.dirty","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Daniel Scally \n\nThe imx708 sensor driver has long been available, especially in raspberry\npi kernels; and the raspberry pi ipa module has had the corresponding\nhelper class since 2023 (952ef94ed78d71). The camera sensor properties\ndatabase also has an entry for it (2fb0f250196326), but the camera sensor\nhelper class is missing from the common libipa component. So add it, with\nthe same gain formula as the raspberry pi ipa module.\n\nHandling the raspberry pi specific \"wide\" / \"noir\" suffixes is omitted.\nThey are not present in the camera sensor properties database either.\n\nSigned-off-by: Daniel Scally \n[Extend commit message.]\nSigned-off-by: Barnabás Pőcze \n---\nchanges in v2:\n * drop rpi specific suffixes\n\nv1: https://patchwork.libcamera.org/patch/24708/\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)\n\n--\n2.51.1.dirty","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex ef3bd0d62..1f2a95e56 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -642,6 +642,16 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n\n+class CameraSensorHelperImx708 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx708()\n+\t{\n+\t\tgain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx708\", CameraSensorHelperImx708)\n+\n class CameraSensorHelperOv2685 : public CameraSensorHelper\n {\n public:\n","prefixes":["RFC","v2"]}