{"id":24762,"url":"https://patchwork.libcamera.org/api/patches/24762/?format=json","web_url":"https://patchwork.libcamera.org/patch/24762/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023144841.403689-36-stefan.klug@ideasonboard.com>","date":"2025-10-23T14:48:36","name":"[v2,35/35] DNI pipeline: rkisp1: Workaround for customer kernels without requests","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"22a7ffad749d56be1fb6de9cc96210481c944d5b","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24762/mbox/","series":[{"id":5520,"url":"https://patchwork.libcamera.org/api/series/5520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5520","date":"2025-10-23T14:48:01","name":"Full dewarper support on imx8mp","version":2,"mbox":"https://patchwork.libcamera.org/series/5520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24762/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24762/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF636C3348\n\tfor ;\n\tThu, 23 Oct 2025 14:50:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C603860878;\n\tThu, 23 Oct 2025 16:50:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F4AB607ED\n\tfor ;\n\tThu, 23 Oct 2025 16:50:31 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 90F08195E; \n\tThu, 23 Oct 2025 16:48:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gIZdZStQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230926;\n\tbh=RIGwM8C3GNF2z+62dNHs6SG07ZN4k8+IAHkjnhUvA+Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gIZdZStQkRmHpFyafrqitY23kas5Fa25fuv/relqqylgltHroWnF+s3iE7WeesLtD\n\to3gvu0WfABQWlFna+hiOFPf/G6cvEZqkj3mpxRDbzKL1zsQX6OUdtKbiwoPu3ySzuX\n\tQrGDsdXgvTBfWvguEk7osc5Ke15NBVB5NAQW48Aw=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 35/35] DNI pipeline: rkisp1: Workaround for customer\n\tkernels without requests","Date":"Thu, 23 Oct 2025 16:48:36 +0200","Message-ID":"<20251023144841.403689-36-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There are a few kernels out there that have dynamic vertex map support,\nbut no requests support. Allow full dewarp usage on these.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 6538fbcc9698..fef6e23e39b7 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -183,6 +183,13 @@ static constexpr unsigned int kRkISP1MaxQueuedRequests = 4;\n */\n static constexpr unsigned int kRkISP1MinBufferCount = 4;\n \n+/*\n+ * This flag allows to use dynamic dewarp maps to support pan, zoom, rotate when\n+ * the kernel driver doesn't support requests. Only needed for legacy customer\n+ * kernels.\n+ */\n+static constexpr bool kAllowDynamicDewarpMapsWithoutRequests = true;\n+\n } /* namespace */\n \n class PipelineHandlerRkISP1 : public PipelineHandler\n@@ -1500,7 +1507,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\t\t\t\t\t\t\t maxCrop);\n \t\t}\n \n-\t\tif (dewarper_->supportsRequests()) {\n+\t\tif (dewarper_->supportsRequests() || kAllowDynamicDewarpMapsWithoutRequests) {\n \t\t\tcontrols[&controls::draft::Dw100Scale] = ControlInfo(0.2f, 8.0f, 1.0f);\n \t\t\tcontrols[&controls::draft::Dw100Rotation] = ControlInfo(-180.0f, 180.0f, 0.0f);\n \t\t\tcontrols[&controls::draft::Dw100Offset] = ControlInfo(Point(-10000, -10000), Point(10000, 10000), Point(0, 0));\n","prefixes":["v2","35/35"]}