[{"id":36466,"web_url":"https://patchwork.libcamera.org/comment/36466/","msgid":"","date":"2025-10-25T13:19:11","subject":"Re: [PATCH v2 33/35] pipeline: rkisp1: Add warning to unclear format\n\thandling","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Thu, Oct 23, 2025 at 04:48:34PM +0200, Stefan Klug wrote:\n> It is not mentioned when the sensorFormat is allowed to have zero size.\n> Add a warning and todo to that case but leave it in place for now.\n> \n\nCameraSensor::getformat() documentation mentions this no ?\n\nand both derived classes seem to log a debug message if a size\ncannot be decided.\n\n\tif (!bestSize) {\n\t\tLOG(CameraSensor, Debug) << \"No supported format or size found\";\n\t\treturn {};\n\t}\n\n\n> Signed-off-by: Stefan Klug \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index da3cfc0ffdeb..9a156d4a01f2 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -782,8 +782,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> \tsensorFormat_ = sensor->getFormat(mbusCodes, accumulatedSensorSize,\n> \t\t\t\t\t mainPath->maxResolution());\n> \n> -\tif (sensorFormat_.size.isNull())\n> +\tif (sensorFormat_.size.isNull()) {\n> +\t\t/*\n> +\t\t * \\todo When can this happen? Should we return a failure in\n> +\t\t * this case?\n> +\t\t */\n> \t\tsensorFormat_.size = sensor->resolution();\n> +\t\tLOG(RkISP1, Warning)\n> +\t\t\t<< \"Failed to select sensor format. Default to \"\n> +\t\t\t<< sensorFormat_;\n> +\t}\n> \n> \treturn status;\n> }\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01943C3259\n\tfor ;\n\tSat, 25 Oct 2025 13:18:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5320C60697;\n\tSat, 25 Oct 2025 15:18:45 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 947DC60697\n\tfor ;\n\tSat, 25 Oct 2025 15:18:42 +0200 (CEST)","from amazon1-vf-gw.lnd.cw.net ([195.89.103.118] helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vCeAL-00F74v-Rx; Sat, 25 Oct 2025 15:18:41 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"VW7YRqc5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=rVM9AePz9G4zSf1Jnzm8e5s6guo01hdgpHoyT2hjgpo=;\n\tb=VW7YRqc52vnRunxKDIaCZOALHn\n\t3wthtD63r+G3jpNzW2N4gMI5qabgB7mbCCGy+phsBx2zGkRirwI5PROvBvJi7g+JzaKWo6WXRGn3X\n\thiPI6ZT+GnEE450ZITnCx2nIGY2SqpnSFWq2oe0HwpqzJCQvP23bRfYOO/SffKHFfZlcuA1dxVS46\n\tfV4NAxCvorZSUavYHLPwDfak1miUwWh2SOQk/rnNo4jjGXefNoxZI74rSj9eMRmLq6Al9AFs8ghkX\n\t65slNGwmhllTfPdzQj6g9hRZXhVJdz40ZvTm2bRS+D9Nn76VGLfOUfBIKpO10B96TmZbodcIbCrDt\n\tfKAYcPmw==;","Date":"Sat, 25 Oct 2025 14:19:11 +0100","From":"Umang Jain ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 33/35] pipeline: rkisp1: Add warning to unclear format\n\thandling","Message-ID":"","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-34-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20251023144841.403689-34-stefan.klug@ideasonboard.com>","User-Agent":"NeoMutt/20250905-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]