{"id":24754,"url":"https://patchwork.libcamera.org/api/patches/24754/?format=json","web_url":"https://patchwork.libcamera.org/patch/24754/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023144841.403689-28-stefan.klug@ideasonboard.com>","date":"2025-10-23T14:48:28","name":"[v2,27/35] libcamera: internal: camera_sensor: Add accessor for mountingOrientation_","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f710b2a139a27e5396522d93ea4ab28c7a7e7adb","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24754/mbox/","series":[{"id":5520,"url":"https://patchwork.libcamera.org/api/series/5520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5520","date":"2025-10-23T14:48:01","name":"Full dewarper support on imx8mp","version":2,"mbox":"https://patchwork.libcamera.org/series/5520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24754/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24754/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F479C3342\n\tfor ;\n\tThu, 23 Oct 2025 14:50:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B125160858;\n\tThu, 23 Oct 2025 16:50:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E45A60844\n\tfor ;\n\tThu, 23 Oct 2025 16:50:08 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2AA05195E; \n\tThu, 23 Oct 2025 16:48:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e3CHCrC5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230903;\n\tbh=rkOkPBkXLjQV0VPKMB8Po4PHfV5o2kMxP1oYCdtChjk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=e3CHCrC5fAZyxnz9ZmUzNUSU9Td541xBQagxMZVj93sH06y8KifZmSxt3Ay3Tph3M\n\ttp610Y3Ej/B4kL6KJiVaUt8PI5s4P4uVSUs+qkY3CHEq4EGjkPhYrq0jT14O2H0u1I\n\tFU2Ya5qDMetAvknG/eQzba+8BDH0qhHzqLJkvros=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ","Subject":"[PATCH v2 27/35] libcamera: internal: camera_sensor: Add accessor\n\tfor mountingOrientation_","Date":"Thu, 23 Oct 2025 16:48:28 +0200","Message-ID":"<20251023144841.403689-28-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"To properly handle the orientation in the dewarper, the mounting\norientation of the sensor needs to be queryable. Add that.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \n\n---\n\nChanges in v2:\n- Collected tag\n- Add documentation\n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/sensor/camera_sensor.cpp | 7 +++++++\n src/libcamera/sensor/camera_sensor_legacy.cpp | 1 +\n src/libcamera/sensor/camera_sensor_raw.cpp | 1 +\n 4 files changed, 10 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex f6ef4df170d4..e6b72d22ac21 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -73,6 +73,7 @@ public:\n \tvirtual int sensorInfo(IPACameraSensorInfo *info) const = 0;\n \tvirtual Transform computeTransform(Orientation *orientation) const = 0;\n \tvirtual BayerFormat::Order bayerOrder(Transform t) const = 0;\n+\tvirtual Orientation mountingOrientation() const = 0;\n \n \tvirtual const ControlInfoMap &controls() const = 0;\n \tvirtual ControlList getControls(Span ids) = 0;\ndiff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex 4f2fd2690eb5..05390d1e1b60 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -331,6 +331,13 @@ int CameraSensor::setEmbeddedDataEnabled(bool enable)\n * \\return The Bayer order produced by the sensor when the Transform is applied\n */\n \n+/**\n+ * \\fn CameraSensor::mountingOrientation()\n+ * \\brief Fetch the mounting orientation of the sensor\n+ *\n+ * \\return The mounting orientation of the sensor\n+ */\n+\n /**\n * \\fn CameraSensor::controls()\n * \\brief Retrieve the supported V4L2 controls and their information\ndiff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex f9e685a9acc4..39c34200b0ff 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -88,6 +88,7 @@ public:\n \tint sensorInfo(IPACameraSensorInfo *info) const override;\n \tTransform computeTransform(Orientation *orientation) const override;\n \tBayerFormat::Order bayerOrder(Transform t) const override;\n+\tOrientation mountingOrientation() const override { return mountingOrientation_; }\n \n \tconst ControlInfoMap &controls() const override;\n \tControlList getControls(Span ids) override;\ndiff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\nindex 8ea4423698cd..759cccafe4a9 100644\n--- a/src/libcamera/sensor/camera_sensor_raw.cpp\n+++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n@@ -94,6 +94,7 @@ public:\n \tint sensorInfo(IPACameraSensorInfo *info) const override;\n \tTransform computeTransform(Orientation *orientation) const override;\n \tBayerFormat::Order bayerOrder(Transform t) const override;\n+\tOrientation mountingOrientation() const override { return mountingOrientation_; }\n \n \tconst ControlInfoMap &controls() const override;\n \tControlList getControls(Span ids) override;\n","prefixes":["v2","27/35"]}