[{"id":36465,"web_url":"https://patchwork.libcamera.org/comment/36465/","msgid":"<3mrcqnu4bljhdkxmgl5kufjxsk5iq2jrraltuxh4udca2zvvdx@ktw7zbeyngpj>","date":"2025-10-25T12:59:23","subject":"Re: [PATCH v2 25/35] pipeline: rkisp1: Drop rawFormat variable","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Thu, Oct 23, 2025 at 04:48:26PM +0200, Stefan Klug wrote:\n> In raw mode we know there is only a single configuration so there\n> is no need to iterate over all configurations to find the format.\n> Drop that.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++-------\n> 1 file changed, 2 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 35cb54c812bc..d7bb30f20668 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -677,21 +677,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> \t}\n> \n> \t/* Select the sensor format. */\n> -\tPixelFormat rawFormat;\n> \tSize maxSize;\n> \n> \tfor (const StreamConfiguration &cfg : config_) {\n> -\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n> -\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> -\t\t\trawFormat = cfg.pixelFormat;\n> -\n> \t\tmaxSize = std::max(maxSize, cfg.size);\n> \t}\n> \n> \tstd::vector mbusCodes;\n> \n> -\tif (rawFormat.isValid()) {\n> -\t\tmbusCodes = { rawFormats.at(rawFormat) };\n> +\tif (isRaw) {\n> +\t\tmbusCodes = { rawFormats.at(config_[0].pixelFormat) };\n> \t} else {\n> \t\tstd::transform(rawFormats.begin(), rawFormats.end(),\n> \t\t\t std::back_inserter(mbusCodes),\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB099BE080\n\tfor ;\n\tSat, 25 Oct 2025 12:58:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CFBE606CE;\n\tSat, 25 Oct 2025 14:58:56 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55A0C60697\n\tfor ;\n\tSat, 25 Oct 2025 14:58:54 +0200 (CEST)","from amazon1-vf-gw.lnd.cw.net ([195.89.103.118] helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vCdrB-00F6mn-L7; Sat, 25 Oct 2025 14:58:53 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Tm6pqxun\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=+xhb4XwT3PVMNSKwK2LmuVLLDz8Ngxkud+W7zzwlpl8=;\n\tb=Tm6pqxunz2d/mqVWTtuTqeDA88\n\tBmBAVv/rgNi0jQnr5H/qBFEixNJoaPoNDq1l7ufPk6rrgxg9Txw29Rj9KzBXksT3Cm45bMSVRnkML\n\t4MzsFethdEv/0xo9fEknIGZY+QftNhbP8VB3FglcbS0/0/Lfnjsee29E/U5kNGFVI8PDTIftXrFxl\n\tEn0pcOhvIYuRi4pmg3nYMUJOJs47Qa/1/Ml/HBSdOsv+qTQX4PosJOGjA/X6yoyGUXOnA/2eOLJ5q\n\tCOiJQjhhv76dKCcobGD9XzXsd/bDK3E4GDgTzPWO1nfxmmTzqdL3O0I/x9NMNlJKN9ueNQUv46rCG\n\tXevoJQgw==;","Date":"Sat, 25 Oct 2025 13:59:23 +0100","From":"Umang Jain ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 25/35] pipeline: rkisp1: Drop rawFormat variable","Message-ID":"<3mrcqnu4bljhdkxmgl5kufjxsk5iq2jrraltuxh4udca2zvvdx@ktw7zbeyngpj>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-26-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20251023144841.403689-26-stefan.klug@ideasonboard.com>","User-Agent":"NeoMutt/20250905-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36491,"web_url":"https://patchwork.libcamera.org/comment/36491/","msgid":"<6192d600-3d12-4328-b0c0-b5865cdd06d6@protonmail.com>","date":"2025-10-27T15:06:33","subject":"Re: [PATCH v2 25/35] pipeline: rkisp1: Drop rawFormat variable","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2025. 10. 23. 16:48 keltezéssel, Stefan Klug írta:\n> In raw mode we know there is only a single configuration so there\n> is no need to iterate over all configurations to find the format.\n> Drop that.\n> \n> Signed-off-by: Stefan Klug \n> ---\n\nReviewed-by: Barnabás Pőcze \n\nAlthough I'm wondering if you might want to keep `rawFormat`\nand remove `isRaw` instead.\n\n\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++-------\n> 1 file changed, 2 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 35cb54c812bc..d7bb30f20668 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -677,21 +677,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> \t}\n> \n> \t/* Select the sensor format. */\n> -\tPixelFormat rawFormat;\n> \tSize maxSize;\n> \n> \tfor (const StreamConfiguration &cfg : config_) {\n> -\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n> -\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> -\t\t\trawFormat = cfg.pixelFormat;\n> -\n> \t\tmaxSize = std::max(maxSize, cfg.size);\n> \t}\n> \n> \tstd::vector mbusCodes;\n> \n> -\tif (rawFormat.isValid()) {\n> -\t\tmbusCodes = { rawFormats.at(rawFormat) };\n> +\tif (isRaw) {\n> +\t\tmbusCodes = { rawFormats.at(config_[0].pixelFormat) };\n> \t} else {\n> \t\tstd::transform(rawFormats.begin(), rawFormats.end(),\n> \t\t\t std::back_inserter(mbusCodes),\n> --\n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8F03C3259\n\tfor ;\n\tMon, 27 Oct 2025 15:06:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC55D60758;\n\tMon, 27 Oct 2025 16:06:38 +0100 (CET)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E07B6069A\n\tfor ;\n\tMon, 27 Oct 2025 16:06:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"LcnAZOaV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1761577596; x=1761836796;\n\tbh=7XBw7HDCu8k2lVe2SSXWyL89Rb8m5EFuvdfg0qBHaCY=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=LcnAZOaVIuab0NbrtxaHefJyyJ9NQm15N21hRTOCsPO20Udxex8UgA65bAsykvkyi\n\tcCbCXOUjKiR2tpSo94ZAhEjHSh0zPlhlMzbaZH9/YlOMjKCOHAoX+b182S00FaXZLU\n\tV7uRPE4AiMABZGODki7qdAeMMi5ZGDLo8hVW5EAfzS5vlcfEGB93d3P9hVyetjWkDt\n\tGKBD6T3oqIB5cbE0C2zu8vKObhAZXF5X+JE1ujOkqIFoX7+ewH/PzX+FhXzhYcwiSs\n\tY5vKUe4fJE8SCHXTHJuP9zyKTh7gJGG9AQNAbyv0+HQHs3y/oKLiHpsu2Qs/KvIRV0\n\tM5HDeeU8wHogg==","Date":"Mon, 27 Oct 2025 15:06:33 +0000","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","From":"=?utf-8?q?P=C5=91cze_Barnab=C3=A1s?= ","Subject":"Re: [PATCH v2 25/35] pipeline: rkisp1: Drop rawFormat variable","Message-ID":"<6192d600-3d12-4328-b0c0-b5865cdd06d6@protonmail.com>","In-Reply-To":"<20251023144841.403689-26-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-26-stefan.klug@ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"2fb3e1b2f48f14edf816bed0f7f5d40f28a400d4","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36725,"web_url":"https://patchwork.libcamera.org/comment/36725/","msgid":"<176242953248.2116251.13094175354507307613@neptunite.rasen.tech>","date":"2025-11-06T11:45:32","subject":"Re: [PATCH v2 25/35] pipeline: rkisp1: Drop rawFormat variable","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 23:48:26)\n> In raw mode we know there is only a single configuration so there\n> is no need to iterate over all configurations to find the format.\n> Drop that.\n> \n> Signed-off-by: Stefan Klug \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++-------\n> 1 file changed, 2 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 35cb54c812bc..d7bb30f20668 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -677,21 +677,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> }\n> \n> /* Select the sensor format. */\n> - PixelFormat rawFormat;\n> Size maxSize;\n> \n> for (const StreamConfiguration &cfg : config_) {\n> - const PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat);\n> - if (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW)\n> - rawFormat = cfg.pixelFormat;\n> -\n> maxSize = std::max(maxSize, cfg.size);\n> }\n> \n> std::vector mbusCodes;\n> \n> - if (rawFormat.isValid()) {\n> - mbusCodes = { rawFormats.at(rawFormat) };\n> + if (isRaw) {\n> + mbusCodes = { rawFormats.at(config_[0].pixelFormat) };\n> } else {\n> std::transform(rawFormats.begin(), rawFormats.end(),\n> std::back_inserter(mbusCodes),\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56D1EC3241\n\tfor ;\n\tThu, 6 Nov 2025 11:45:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E547D609D8;\n\tThu, 6 Nov 2025 12:45:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F4CC606E6\n\tfor ;\n\tThu, 6 Nov 2025 12:45:38 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d4d0:27ea:7a74:8a9e])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D2F576A6;\n\tThu, 6 Nov 2025 12:43:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tGVaSzny\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762429423;\n\tbh=rpbbZZHfHc1WYS2xNO0+9qUh9sEShH/It08pqj7HzMY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tGVaSznylRQy8kCgad0HSpKsdjPb4uLNuRxqXne5d321Beu0iLyHB/+IngoHi84zt\n\tpXZqxg9/u7Vzr/vy5bfFL1tJt69DNYL/4mqaRONt49sKqKJbthytkV0pu65y5adTKv\n\tNQ5QAFOsKoDPiLyuN9/O9NEt16wnqwzoG/TkxB8Y=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-26-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-26-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 25/35] pipeline: rkisp1: Drop rawFormat variable","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 20:45:32 +0900","Message-ID":"<176242953248.2116251.13094175354507307613@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]