{"id":24751,"url":"https://patchwork.libcamera.org/api/patches/24751/?format=json","web_url":"https://patchwork.libcamera.org/patch/24751/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023144841.403689-25-stefan.klug@ideasonboard.com>","date":"2025-10-23T14:48:25","name":"[v2,24/35] pipeline: rksip1: Move isRaw up in scope","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c85405992a84a0f20c43e0241550082ed2396043","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24751/mbox/","series":[{"id":5520,"url":"https://patchwork.libcamera.org/api/series/5520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5520","date":"2025-10-23T14:48:01","name":"Full dewarper support on imx8mp","version":2,"mbox":"https://patchwork.libcamera.org/series/5520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24751/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24751/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C468BE080\n\tfor ;\n\tThu, 23 Oct 2025 14:50:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 802446083D;\n\tThu, 23 Oct 2025 16:50:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71ECE6082F\n\tfor ;\n\tThu, 23 Oct 2025 16:49:58 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8267D177F; \n\tThu, 23 Oct 2025 16:48:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MZpv9SG9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230893;\n\tbh=YD8/Fc4sV3lxt4nPYvG9lORTvpOnOCp/4zQKsFVq1Jc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MZpv9SG94Fw5wGlr4NFeq39MUwPlq0TsdwKlwr8JlAZ7cM0x9gQ4UASEF6md0yIjv\n\tbGap88PaG+QnAJkMkHlSgoKXIG7rkUOilcifAR2+E7k3j6r7S3OtfBUhKRgbZgP4SZ\n\t8oeG66tfuQg6y+N1I59RXkPQVHwmxrn3sd9afe6w=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 24/35] pipeline: rksip1: Move isRaw up in scope","Date":"Thu, 23 Oct 2025 16:48:25 +0200","Message-ID":"<20251023144841.403689-25-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In raw mode the number of configurations is actively limited to 1. It is\ntherefore safe to move isRaw up one level to simplify the code and\nprepare for later use.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 ++++----------\n 1 file changed, 4 insertions(+), 10 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 0b31b8077c8d..35cb54c812bc 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -559,28 +559,22 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t * Simultaneous capture of raw and processed streams isn't possible. If\n \t * there is any raw stream, cap the number of streams to one.\n \t */\n+\tbool isRaw = false;\n \tif (config_.size() > 1) {\n \t\tfor (const auto &cfg : config_) {\n \t\t\tif (PixelFormatInfo::info(cfg.pixelFormat).colourEncoding ==\n \t\t\t PixelFormatInfo::ColourEncodingRAW) {\n \t\t\t\tconfig_.resize(1);\n \t\t\t\tstatus = Adjusted;\n+\t\t\t\tisRaw = true;\n \t\t\t\tbreak;\n \t\t\t}\n \t\t}\n \t}\n \n \tbool useDewarper = false;\n-\tif (pipe->dewarper_) {\n-\t\t/*\n-\t\t * Platforms with dewarper support, such as i.MX8MP, support\n-\t\t * only a single stream. We can inspect config_[0] only here.\n-\t\t */\n-\t\tbool isRaw = PixelFormatInfo::info(config_[0].pixelFormat).colourEncoding ==\n-\t\t\t PixelFormatInfo::ColourEncodingRAW;\n-\t\tif (!isRaw)\n-\t\t\tuseDewarper = true;\n-\t}\n+\tif (pipe->dewarper_ && !isRaw)\n+\t\tuseDewarper = true;\n \n \t/*\n \t * If there are more than one stream in the configuration figure out the\n","prefixes":["v2","24/35"]}