[{"id":36728,"web_url":"https://patchwork.libcamera.org/comment/36728/","msgid":"<176242955777.2116251.10366129929407692263@neptunite.rasen.tech>","date":"2025-11-06T11:45:57","subject":"Re: [PATCH v2 22/35] libcamera: rkisp1: Use the dw100 class instead\n\tof the generic v4l2 converter","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 23:48:23)\n> To be able to access the dw100 specific functions and as there is no\n> known other dewarper in combination with the rkisp1, use the dw100\n\ns/known other/other known/ (I think it's because \"no other\" is a group and\n\"known\" modifies \"dewarper\")\n\n> specific converter directly.\n> \n> Signed-off-by: Stefan Klug \n\nOtherwise looks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 77442b25b809..e22f05408931 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -36,7 +36,7 @@\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> #include \"libcamera/internal/camera_sensor_properties.h\"\n> -#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> +#include \"libcamera/internal/converter/converter_dw100.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> @@ -234,7 +234,7 @@ private:\n> RkISP1MainPath mainPath_;\n> RkISP1SelfPath selfPath_;\n> \n> - std::unique_ptr dewarper_;\n> + std::unique_ptr dewarper_;\n> Rectangle scalerMaxCrop_;\n> \n> std::optional activeCrop_;\n> @@ -1500,7 +1500,7 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n> \n> std::shared_ptr dwpMediaDevice = enumerator->search(dwp);\n> if (dwpMediaDevice) {\n> - dewarper_ = std::make_unique(dwpMediaDevice);\n> + dewarper_ = std::make_unique(dwpMediaDevice);\n> if (dewarper_->isValid()) {\n> dewarper_->outputBufferReady.connect(\n> this, &PipelineHandlerRkISP1::dewarpBufferReady);\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F0FCC3241\n\tfor ;\n\tThu, 6 Nov 2025 11:46:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29C7F60A85;\n\tThu, 6 Nov 2025 12:46:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D66D609E0\n\tfor ;\n\tThu, 6 Nov 2025 12:46:03 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d4d0:27ea:7a74:8a9e])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1FE506A6;\n\tThu, 6 Nov 2025 12:44:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z0YNfaO3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762429448;\n\tbh=ypR0aDKoHxiUlw2cyIO9k4h6aEM0JcJ4jrfiQWlpBuo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Z0YNfaO3e0Xb0+4Fu3bTgUl/EsNdBi5Y0rGy2+E/98+KpDVf4CtQiF9wY8s7IKGgF\n\tM34lEcUjy3vXHvKaga6D9Vyq08g9HhrrGGzyVKwLlMpA0NxK4kSwUPmDZR7c/+HFvk\n\trv0eonn2FTPorlaDApi1b5MiNPPFdiBpVgHRQIIo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-23-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-23-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 22/35] libcamera: rkisp1: Use the dw100 class instead\n\tof the generic v4l2 converter","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 20:45:57 +0900","Message-ID":"<176242955777.2116251.10366129929407692263@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]