[{"id":36719,"web_url":"https://patchwork.libcamera.org/comment/36719/","msgid":"<176236127267.2116251.6994606818179904288@neptunite.rasen.tech>","date":"2025-11-05T16:47:52","subject":"Re: [PATCH v2 18/35] libcamera: converter_m2m: Make some parts\n\tprotected","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 23:48:19)\n> In order to derive from V4L2M2MConverter and also from V4L2M2MStream in\n> a subclass, raise the visibility of most of the private parts to\n> protected and document them.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n> \n> Changes in v2:\n> - Added this patch\n> ---\n> .../internal/converter/converter_v4l2_m2m.h | 7 +-\n> .../converter/converter_v4l2_m2m.cpp | 107 ++++++++++++++++++\n> 2 files changed, 111 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 2d6f361c17e1..79d008fc6918 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -81,7 +81,7 @@ public:\n> \n> bool supportsRequests();\n> \n> -private:\n> +protected:\n> class V4L2M2MStream : protected Loggable\n> {\n> public:\n> @@ -130,12 +130,13 @@ private:\n> virtual std::unique_ptr makeStream(const Stream *stream);\n> \n> std::unique_ptr m2m_;\n> + std::shared_ptr media_;\n> \n> std::map> streams_;\n> +\n> +private:\n> std::map queue_;\n> std::pair inputCropBounds_;\n> -\n> - std::shared_ptr media_;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 2e3966444361..3a05e45ac33c 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -86,6 +86,28 @@ int getCropBounds(V4L2VideoDevice *device, Rectangle &minCrop,\n> * V4L2M2MConverter::V4L2M2MStream\n> */\n> \n> +/**\n> + * \\class libcamera::V4L2M2MConverter::V4L2M2MStream\n> + * \\brief The V4L2 M2M stream represents a stream in a V4L2M2MConverter\n> + *\n> + * The Converter interface allows to create multiple output image streams from\n> + * a single input image stream. This class represents one such stream.\n> + */\n> +\n> +/**\n> + * \\fn V4L2M2MConverter::V4L2M2MStream::isValid\n> + * \\brief Checks if the stream is valid\n> + *\n> + * This function checks if the underlying m2m device is valid.\n> + *\n> + * \\return True if the stream is valid, false otherwise\n> + */\n> +\n> +/**\n> + * \\brief Constructs a V4L2M2MStream\n> + * \\param[in] converter The converter this stream belongs to\n> + * \\param[in] stream The stream this V4L2M2MStream represents\n> + */\n> V4L2M2MConverter::V4L2M2MStream::V4L2M2MStream(V4L2M2MConverter *converter, const Stream *stream)\n> : converter_(converter), stream_(stream)\n> {\n> @@ -99,6 +121,13 @@ V4L2M2MConverter::V4L2M2MStream::V4L2M2MStream(V4L2M2MConverter *converter, cons\n> m2m_.reset();\n> }\n> \n> +/**\n> + * \\brief Configure the stream\n> + * \\param[in] inputCfg The input config\n> + * \\param[in] outputCfg The output config\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputCfg,\n> const StreamConfiguration &outputCfg)\n> {\n> @@ -161,12 +190,24 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> return 0;\n> }\n> \n> +/**\n> + * \\brief Export buffers\n> + * \\param[in] count The number of buffers\n> + * \\param[out] buffers The exported buffers\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::exportBuffers(unsigned int count,\n> std::vector> *buffers)\n> {\n> return m2m_->capture()->exportBuffers(count, buffers);\n> }\n> \n> +/**\n> + * \\brief Start the stream\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::start()\n> {\n> int ret = m2m_->output()->importBuffers(inputBufferCount_);\n> @@ -194,6 +235,9 @@ int V4L2M2MConverter::V4L2M2MStream::start()\n> return 0;\n> }\n> \n> +/**\n> + * \\brief Stop the stream\n> + */\n> void V4L2M2MConverter::V4L2M2MStream::stop()\n> {\n> m2m_->capture()->streamOff();\n> @@ -202,6 +246,14 @@ void V4L2M2MConverter::V4L2M2MStream::stop()\n> m2m_->output()->releaseBuffers();\n> }\n> \n> +/**\n> + * \\brief Queue buffers\n> + * \\param[in] input The input buffer\n> + * \\param[in] output The output buffer\n> + * \\param[in] request An optional request\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::queueBuffers(FrameBuffer *input,\n> FrameBuffer *output,\n> const V4L2Request *request)\n> @@ -217,16 +269,35 @@ int V4L2M2MConverter::V4L2M2MStream::queueBuffers(FrameBuffer *input,\n> return 0;\n> }\n> \n> +/**\n> + * \\brief Get the input selection rectangle\n> + * \\param[in] target The selection target\n> + * \\param[out] rect The selection rectangle\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::getInputSelection(unsigned int target, Rectangle *rect)\n> {\n> return m2m_->output()->getSelection(target, rect);\n> }\n> \n> +/**\n> + * \\brief Set the input selection rectangle\n> + * \\param[in] target The selection target\n> + * \\param[in] rect The selection rectangle\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::setInputSelection(unsigned int target, Rectangle *rect)\n> {\n> return m2m_->output()->setSelection(target, rect);\n> }\n> \n> +/**\n> + * \\brief Get the input crop bounds\n> + *\n> + * \\return A pair of rectangles representing the min and max input crop bounds\n> + */\n> std::pair V4L2M2MConverter::V4L2M2MStream::inputCropBounds()\n> {\n> return inputCropBounds_;\n> @@ -461,6 +532,19 @@ Size V4L2M2MConverter::adjustOutputSize(const PixelFormat &pixFmt,\n> return adjustSizes(size, it->second, align);\n> }\n> \n> +/**\n> + * \\brief Adjust the converter output \\a size to a valid value\n> + * \\param[in] cfgSize The requested size\n> + * \\param[in] ranges The possible sizes\n> + * \\param[in] align The desired alignment\n> + *\n> + * Selects the best fitting size from \\a ranges according to \\a align and\n> + * returns that.\n> + *\n> + * \\return The adjusted converter output size or a null Size if \\a size cannot\n> + * be adjusted\n> + * \\see libcamera::Converter::adjustOutputSize\n> + */\n> Size V4L2M2MConverter::adjustSizes(const Size &cfgSize,\n> const std::vector &ranges,\n> Alignment align)\n> @@ -810,11 +894,34 @@ bool V4L2M2MConverter::supportsRequests()\n> return ret;\n> }\n> \n> +/**\n> + * \\brief Create a V4L2M2MStream\n> + * \\param[in] stream The stream to wrap\n> + *\n> + * This function creates a new V4L2M2MConverter::V4L2M2MStream for this\n> + * converter and the provided \\a stream.\n> + *\n> + * This function can be overwritten by subclasses to be able provide their own\n\ns/be able //\n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> + * stream implementation.\n> + *\n> + * \\return The created V4L2M2MStream\n> + */\n> std::unique_ptr V4L2M2MConverter::makeStream(const Stream *stream)\n> {\n> return std::make_unique(this, stream);\n> }\n> \n> +/**\n> + * \\var V4L2M2MConverter::m2m_\n> + * \\brief The underlying m2m device\n> + *\n> + * \\var V4L2M2MConverter::media_\n> + * \\brief The underlying media device\n> + *\n> + * \\var V4L2M2MConverter::streams_\n> + * \\brief Map of Stream pointers to V4L2M2MStream unique pointers\n> + */\n> +\n> /*\n> * \\todo This should be extended to include Feature::Flag to denote\n> * what each converter supports feature-wise.\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 603FDC3241\n\tfor ;\n\tWed, 5 Nov 2025 16:48:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19E1F60AA8;\n\tWed, 5 Nov 2025 17:48:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F74160AA4\n\tfor ;\n\tWed, 5 Nov 2025 17:47:59 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d4d0:27ea:7a74:8a9e])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4557EE45;\n\tWed, 5 Nov 2025 17:46:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YQVwwRwu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762361164;\n\tbh=Xi2HvFwdTfHTkxRnyKoelx0b9aafK1+vN13b0Ey+J5M=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=YQVwwRwux+fZ/c68nigF/8nrPSqD+cgDZvlzjoOpmM+FQSyYGU9LcV8cNu4Fn1ctU\n\tK7hGxCVBtd0pjQIbK7QN4X3OWc5q86C2Behn//p/TNFPybx+n2BRQT57sYyroNTp8p\n\tPyl5BcuW5h9cc9X2oqSUjJqsM1Ljh+UVLZRHZncQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-19-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-19-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 18/35] libcamera: converter_m2m: Make some parts\n\tprotected","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 01:47:52 +0900","Message-ID":"<176236127267.2116251.6994606818179904288@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36731,"web_url":"https://patchwork.libcamera.org/comment/36731/","msgid":"<176243190147.3666756.16729460143904645546@ping.linuxembedded.co.uk>","date":"2025-11-06T12:25:01","subject":"Re: [PATCH v2 18/35] libcamera: converter_m2m: Make some parts\n\tprotected","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 15:48:19)\n> In order to derive from V4L2M2MConverter and also from V4L2M2MStream in\n> a subclass, raise the visibility of most of the private parts to\n> protected and document them.\n> \n> Signed-off-by: Stefan Klug \n> \n> ---\n> \n> Changes in v2:\n> - Added this patch\n> ---\n> .../internal/converter/converter_v4l2_m2m.h | 7 +-\n> .../converter/converter_v4l2_m2m.cpp | 107 ++++++++++++++++++\n> 2 files changed, 111 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 2d6f361c17e1..79d008fc6918 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -81,7 +81,7 @@ public:\n> \n> bool supportsRequests();\n> \n> -private:\n> +protected:\n> class V4L2M2MStream : protected Loggable\n> {\n> public:\n> @@ -130,12 +130,13 @@ private:\n> virtual std::unique_ptr makeStream(const Stream *stream);\n> \n> std::unique_ptr m2m_;\n> + std::shared_ptr media_;\n> \n> std::map> streams_;\n> +\n> +private:\n> std::map queue_;\n> std::pair inputCropBounds_;\n> -\n> - std::shared_ptr media_;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 2e3966444361..3a05e45ac33c 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -86,6 +86,28 @@ int getCropBounds(V4L2VideoDevice *device, Rectangle &minCrop,\n> * V4L2M2MConverter::V4L2M2MStream\n> */\n> \n> +/**\n> + * \\class libcamera::V4L2M2MConverter::V4L2M2MStream\n> + * \\brief The V4L2 M2M stream represents a stream in a V4L2M2MConverter\n> + *\n> + * The Converter interface allows to create multiple output image streams from\n> + * a single input image stream. This class represents one such stream.\n\nThe Convertor interface allows creating multiple \n\n> + */\n> +\n> +/**\n> + * \\fn V4L2M2MConverter::V4L2M2MStream::isValid\n> + * \\brief Checks if the stream is valid\n> + *\n> + * This function checks if the underlying m2m device is valid.\n> + *\n> + * \\return True if the stream is valid, false otherwise\n> + */\n> +\n> +/**\n> + * \\brief Constructs a V4L2M2MStream\n> + * \\param[in] converter The converter this stream belongs to\n> + * \\param[in] stream The stream this V4L2M2MStream represents\n> + */\n> V4L2M2MConverter::V4L2M2MStream::V4L2M2MStream(V4L2M2MConverter *converter, const Stream *stream)\n> : converter_(converter), stream_(stream)\n> {\n> @@ -99,6 +121,13 @@ V4L2M2MConverter::V4L2M2MStream::V4L2M2MStream(V4L2M2MConverter *converter, cons\n> m2m_.reset();\n> }\n> \n> +/**\n> + * \\brief Configure the stream\n> + * \\param[in] inputCfg The input config\n> + * \\param[in] outputCfg The output config\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputCfg,\n> const StreamConfiguration &outputCfg)\n> {\n> @@ -161,12 +190,24 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> return 0;\n> }\n> \n> +/**\n> + * \\brief Export buffers\n> + * \\param[in] count The number of buffers\n> + * \\param[out] buffers The exported buffers\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::exportBuffers(unsigned int count,\n> std::vector> *buffers)\n> {\n> return m2m_->capture()->exportBuffers(count, buffers);\n> }\n> \n> +/**\n> + * \\brief Start the stream\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::start()\n> {\n> int ret = m2m_->output()->importBuffers(inputBufferCount_);\n> @@ -194,6 +235,9 @@ int V4L2M2MConverter::V4L2M2MStream::start()\n> return 0;\n> }\n> \n> +/**\n> + * \\brief Stop the stream\n> + */\n> void V4L2M2MConverter::V4L2M2MStream::stop()\n> {\n> m2m_->capture()->streamOff();\n> @@ -202,6 +246,14 @@ void V4L2M2MConverter::V4L2M2MStream::stop()\n> m2m_->output()->releaseBuffers();\n> }\n> \n> +/**\n> + * \\brief Queue buffers\n> + * \\param[in] input The input buffer\n> + * \\param[in] output The output buffer\n> + * \\param[in] request An optional request\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::queueBuffers(FrameBuffer *input,\n> FrameBuffer *output,\n> const V4L2Request *request)\n> @@ -217,16 +269,35 @@ int V4L2M2MConverter::V4L2M2MStream::queueBuffers(FrameBuffer *input,\n> return 0;\n> }\n> \n> +/**\n> + * \\brief Get the input selection rectangle\n> + * \\param[in] target The selection target\n> + * \\param[out] rect The selection rectangle\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::getInputSelection(unsigned int target, Rectangle *rect)\n> {\n> return m2m_->output()->getSelection(target, rect);\n> }\n> \n> +/**\n> + * \\brief Set the input selection rectangle\n> + * \\param[in] target The selection target\n> + * \\param[in] rect The selection rectangle\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> int V4L2M2MConverter::V4L2M2MStream::setInputSelection(unsigned int target, Rectangle *rect)\n> {\n> return m2m_->output()->setSelection(target, rect);\n> }\n> \n> +/**\n> + * \\brief Get the input crop bounds\n> + *\n> + * \\return A pair of rectangles representing the min and max input crop bounds\n> + */\n\nOhhh I've been thinking about proposing a min/max type and I ended up\ncalling it bounds, and now you've shown me why Bounds might be a good\nchoice as we can perhaps have :\n\n\tBounds bounds;\n\n(see\nhttps://git.uk.ideasonboard.com/kbingham/libcamera/commit/4097f65b72ffd1a7b7f32aa9bf18488b3c7f7152)\n\nPerhaps it could be useful outside of libipa...\n\nMight have to check what happens in Rectangles for the constructor where\nthere is something like this:\n\nBounds\nBounds(T a, T b) {\n\tif (a < b)\n\t\tstd::swap(a, b)\n}\n\n\nBut that's all work that could be on top.\n\n\nReviewed-by: Kieran Bingham \n\n> std::pair V4L2M2MConverter::V4L2M2MStream::inputCropBounds()\n> {\n> return inputCropBounds_;\n> @@ -461,6 +532,19 @@ Size V4L2M2MConverter::adjustOutputSize(const PixelFormat &pixFmt,\n> return adjustSizes(size, it->second, align);\n> }\n> \n> +/**\n> + * \\brief Adjust the converter output \\a size to a valid value\n> + * \\param[in] cfgSize The requested size\n> + * \\param[in] ranges The possible sizes\n> + * \\param[in] align The desired alignment\n> + *\n> + * Selects the best fitting size from \\a ranges according to \\a align and\n> + * returns that.\n> + *\n> + * \\return The adjusted converter output size or a null Size if \\a size cannot\n> + * be adjusted\n> + * \\see libcamera::Converter::adjustOutputSize\n> + */\n> Size V4L2M2MConverter::adjustSizes(const Size &cfgSize,\n> const std::vector &ranges,\n> Alignment align)\n> @@ -810,11 +894,34 @@ bool V4L2M2MConverter::supportsRequests()\n> return ret;\n> }\n> \n> +/**\n> + * \\brief Create a V4L2M2MStream\n> + * \\param[in] stream The stream to wrap\n> + *\n> + * This function creates a new V4L2M2MConverter::V4L2M2MStream for this\n> + * converter and the provided \\a stream.\n> + *\n> + * This function can be overwritten by subclasses to be able provide their own\n> + * stream implementation.\n> + *\n> + * \\return The created V4L2M2MStream\n> + */\n> std::unique_ptr V4L2M2MConverter::makeStream(const Stream *stream)\n> {\n> return std::make_unique(this, stream);\n> }\n> \n> +/**\n> + * \\var V4L2M2MConverter::m2m_\n> + * \\brief The underlying m2m device\n> + *\n> + * \\var V4L2M2MConverter::media_\n> + * \\brief The underlying media device\n> + *\n> + * \\var V4L2M2MConverter::streams_\n> + * \\brief Map of Stream pointers to V4L2M2MStream unique pointers\n> + */\n> +\n> /*\n> * \\todo This should be extended to include Feature::Flag to denote\n> * what each converter supports feature-wise.\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B292BDE4C\n\tfor ;\n\tThu, 6 Nov 2025 12:25:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41DF1606E6;\n\tThu, 6 Nov 2025 13:25:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F10FC606E6\n\tfor ;\n\tThu, 6 Nov 2025 13:25:03 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B63EA6DF;\n\tThu, 6 Nov 2025 13:23:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jXuV0tLg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762431788;\n\tbh=PJ3nNfY7Ora/QKof//ERGyXcs4k+oUvjaojxGQ31808=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=jXuV0tLgK6fKX4JTXvSPqijZnxqFFBAK8CON42WHMZH43Ej18/s4lhQnH7tRe9RjY\n\tIolrEMVJ3gQTBBR2qIjgYML2wVZdXA15sdI69Cb0XTFHdD3e+pumJsfKzcGJbGXM2R\n\tIb1dH7QcL+uPqdd7toYyhnEh4qh9YnUZh7beXLw0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-19-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-19-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 18/35] libcamera: converter_m2m: Make some parts\n\tprotected","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 12:25:01 +0000","Message-ID":"<176243190147.3666756.16729460143904645546@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]