[{"id":36717,"web_url":"https://patchwork.libcamera.org/comment/36717/","msgid":"<176236125394.2116251.3372451034965566348@neptunite.rasen.tech>","date":"2025-11-05T16:47:33","subject":"Re: [PATCH v2 16/35] libcamera: rkisp1: Allow upscaling when the\n\tdewarper is present","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 23:48:17)\n> When the dewarper is present, there is no need to forbid upscaling of\n> the image data.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 46bc81f2483c..77442b25b809 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -614,6 +614,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> return false;\n> \n> if (useDewarper) {\n> + /*\n> + * The dewarper output is independent of the ISP path.\n> + * Reset to the originally requested size.\n> + */\n> + tryCfg.size = cfg.size;\n> bool adjusted;\n> \n> pipe->dewarper_->validateOutput(&tryCfg, &adjusted,\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FD4CC3241\n\tfor ;\n\tWed, 5 Nov 2025 16:47:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F339160AA4;\n\tWed, 5 Nov 2025 17:47:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F202760A86\n\tfor ;\n\tWed, 5 Nov 2025 17:47:39 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d4d0:27ea:7a74:8a9e])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 27601C71;\n\tWed, 5 Nov 2025 17:45:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bX9OljV+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762361145;\n\tbh=IAIYARqlxJJyhFEGwcxHENRYQGvb1Nsb/sxvNhS3uJw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=bX9OljV+2DEx/OgvLI03LHMz+hhTD7FXQ/fQYaHrWCg+fR+IMPve7fQ6JSRvlC2Zz\n\tdaKYtdRNLnavF4qU+vTnDqq3y6kcTwXwqkyEUXPQL1xBTc/Wh0Rw8u89UKYIBJ3Uke\n\tYoX8lZxv3ByXMQCDMfMLv2RB8wxAfevLGRytkquc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-17-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-17-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 16/35] libcamera: rkisp1: Allow upscaling when the\n\tdewarper is present","From":"Paul Elder ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 01:47:33 +0900","Message-ID":"<176236125394.2116251.3372451034965566348@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]