{"id":24744,"url":"https://patchwork.libcamera.org/api/patches/24744/?format=json","web_url":"https://patchwork.libcamera.org/patch/24744/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023144841.403689-17-stefan.klug@ideasonboard.com>","date":"2025-10-23T14:48:17","name":"[v2,16/35] libcamera: rkisp1: Allow upscaling when the dewarper is present","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"86250ad76805c58fb3c9633374b276e6e3a1a045","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24744/mbox/","series":[{"id":5520,"url":"https://patchwork.libcamera.org/api/series/5520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5520","date":"2025-10-23T14:48:01","name":"Full dewarper support on imx8mp","version":2,"mbox":"https://patchwork.libcamera.org/series/5520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24744/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24744/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E1D3C333B\n\tfor ;\n\tThu, 23 Oct 2025 14:49:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24A0060815;\n\tThu, 23 Oct 2025 16:49:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4806E60805\n\tfor ;\n\tThu, 23 Oct 2025 16:49:34 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 59870EFE;\n\tThu, 23 Oct 2025 16:47:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OvWcuz/z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230869;\n\tbh=kg+s632GFTl2fgzosj6Jq2H2VdCgjkp2sbqQIpqgexA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OvWcuz/zUGaHB2OxVJGA9HrxFf8JfdkqiZTQ7SNAgf7bU/EmtQy2/L+p6AGcNPIfB\n\tTBg6AFS+HzSvTgUqiK/zrcHnjMg/97CivkMbXl2uU6fkoM1Ygvj+6tZBRm64WSPT+v\n\tM/FOhA1o57kIlyqhFUhHuZsc02rE3sB04+AEvFOg=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 16/35] libcamera: rkisp1: Allow upscaling when the\n\tdewarper is present","Date":"Thu, 23 Oct 2025 16:48:17 +0200","Message-ID":"<20251023144841.403689-17-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the dewarper is present, there is no need to forbid upscaling of\nthe image data.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 46bc81f2483c..77442b25b809 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -614,6 +614,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t\t\treturn false;\n \n \t\tif (useDewarper) {\n+\t\t\t/*\n+\t\t\t * The dewarper output is independent of the ISP path.\n+\t\t\t * Reset to the originally requested size.\n+\t\t\t */\n+\t\t\ttryCfg.size = cfg.size;\n \t\t\tbool adjusted;\n \n \t\t\tpipe->dewarper_->validateOutput(&tryCfg, &adjusted,\n","prefixes":["v2","16/35"]}