[{"id":36442,"web_url":"https://patchwork.libcamera.org/comment/36442/","msgid":"<5980ba80-1c6b-4045-9138-3df021746edb@ideasonboard.com>","date":"2025-10-24T14:43:09","subject":"Re: [PATCH v2 13/35] libcamera: converter_v4l2_m2m: Add debug\n\tlogging for formats","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 23. 16:48 keltezéssel, Stefan Klug írta:\n> Getting the requested input/output format is crucial for debugging. Add\n> log statements for that.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> \n\nReviewed-by: Barnabás Pőcze \n\nBut I feel like this should be moved in to the `V4L2VideoDevice::setFormat()`\nclass to have it in a single place. That could also log the actual format\nif it was adjusted (which is probably just as important for debugging).\n\n\n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 48e49f143cf1..37377ab24952 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -111,6 +111,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> \tformat.planesCount = 1;\n> \tformat.planes[0].bpl = inputCfg.stride;\n> \n> +\tLOG(Converter, Debug) << \"Set input format to: \" << format;\n> \tint ret = m2m_->output()->setFormat(&format);\n> \tif (ret < 0) {\n> \t\tLOG(Converter, Error)\n> @@ -133,6 +134,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> \tformat.fourcc = videoFormat;\n> \tformat.size = outputCfg.size;\n> \n> +\tLOG(Converter, Debug) << \"Set output format to: \" << format;\n> \tret = m2m_->capture()->setFormat(&format);\n> \tif (ret < 0) {\n> \t\tLOG(Converter, Error)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68849BE080\n\tfor ;\n\tFri, 24 Oct 2025 14:43:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC2A86099B;\n\tFri, 24 Oct 2025 16:43:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B67C60976\n\tfor ;\n\tFri, 24 Oct 2025 16:43:12 +0200 (CEST)","from [192.168.33.13] (185.221.141.231.nat.pool.zt.hu\n\t[185.221.141.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A785CEFF;\n\tFri, 24 Oct 2025 16:41:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MnjgCylp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761316886;\n\tbh=SSy19MwDE7SIsclF6JtmGyhe2i9aHj7PhoBvPSKZcBI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=MnjgCylpXXg6P9CHGldfuseRrGXCq4/4pUyb3dYX7tAdPziiivxgBfrL8VNPgsrEa\n\tcMiutZHnt60ShKrUDF1vqmPmT8AafV3cvtSGq4Y+h4IHmJZn+IU9xhS/4J1R2pa06h\n\tmPw0W59lz0vrqu+oc2m+yUnRxt00ZeW/PZrNTmXw=","Message-ID":"<5980ba80-1c6b-4045-9138-3df021746edb@ideasonboard.com>","Date":"Fri, 24 Oct 2025 16:43:09 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 13/35] libcamera: converter_v4l2_m2m: Add debug\n\tlogging for formats","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-14-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251023144841.403689-14-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36714,"web_url":"https://patchwork.libcamera.org/comment/36714/","msgid":"<176236122981.2116251.7133962044448183696@neptunite.rasen.tech>","date":"2025-11-05T16:47:09","subject":"Re: [PATCH v2 13/35] libcamera: converter_v4l2_m2m: Add debug\n\tlogging for formats","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 23:48:14)\n> Getting the requested input/output format is crucial for debugging. Add\n> log statements for that.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 48e49f143cf1..37377ab24952 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -111,6 +111,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> format.planesCount = 1;\n> format.planes[0].bpl = inputCfg.stride;\n> \n> + LOG(Converter, Debug) << \"Set input format to: \" << format;\n> int ret = m2m_->output()->setFormat(&format);\n> if (ret < 0) {\n> LOG(Converter, Error)\n> @@ -133,6 +134,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> format.fourcc = videoFormat;\n> format.size = outputCfg.size;\n> \n> + LOG(Converter, Debug) << \"Set output format to: \" << format;\n> ret = m2m_->capture()->setFormat(&format);\n> if (ret < 0) {\n> LOG(Converter, Error)\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D4F3C3241\n\tfor ;\n\tWed, 5 Nov 2025 16:47:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9E7E60A86;\n\tWed, 5 Nov 2025 17:47:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DE8460AA9\n\tfor ;\n\tWed, 5 Nov 2025 17:47:16 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d4d0:27ea:7a74:8a9e])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id AF111129;\n\tWed, 5 Nov 2025 17:45:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oHoBn0Gg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762361122;\n\tbh=SpMtJqfFQWVLzIZZ7xMDWhr0zt4Uq1G6f6G/HqvccIg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oHoBn0GgXfexOD+8wKiYLzkzIAzLLr9d4sOmvVY+ygjKwfdzsuyY5Tr+Yd0Rkueq5\n\t3Nt6u6KRhGcIAfG7pSmoCFBEFZOWVGunH5iHZAnHS7FPJqt2C1zv8dcllM/GsB1a2U\n\toAivVU+FRTeSNyHPbsJOPllQJJcLNctkdbM7crz4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-14-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-14-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 13/35] libcamera: converter_v4l2_m2m: Add debug\n\tlogging for formats","From":"Paul Elder ","Cc":"Stefan Klug ,\n\tKieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 01:47:09 +0900","Message-ID":"<176236122981.2116251.7133962044448183696@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]