[{"id":36425,"web_url":"https://patchwork.libcamera.org/comment/36425/","msgid":"<176129962186.114750.11126835949420374056@isaac-ThinkPad-T16-Gen-2>","date":"2025-10-24T09:53:41","subject":"Re: [PATCH v2 08/35] libcamera: converter_v4l2_m2m: Always set\n\tstride","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch!\n\nQuoting Stefan Klug (2025-10-23 15:48:09)\n> Ensure the stride is properly set after a call to validateOutput().\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index c6153d728c9a..e57db8a438ab 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -680,6 +680,7 @@ int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,\n> \n> const Size cfgSize = cfg->size;\n> cfg->size = adjustSizes(cfgSize, it->second, align);\n> + cfg->stride = PixelFormatInfo::info(cfg->pixelFormat).stride(cfg->size.width, 0);\n\nReviewed-by: Isaac Scott \n\n> \n> if (cfg->size.isNull())\n> return -EINVAL;\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 130ABBE080\n\tfor ;\n\tFri, 24 Oct 2025 09:53:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63DCC608C9;\n\tFri, 24 Oct 2025 11:53:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CABC86088F\n\tfor ;\n\tFri, 24 Oct 2025 11:53:44 +0200 (CEST)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E4D81AC5;\n\tFri, 24 Oct 2025 11:51:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ftBaj/Z6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761299519;\n\tbh=E9pa8a6Ob2YhpMb/TLpIKhkkE8lsVcx8ItyFOCZrfkI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ftBaj/Z6hnF3RZ7ayQZce0u6EQSzi/Vpatc4Uw0ZyVHMNBJadBQHWppkteLlAYukT\n\tt6opPtfqFxzjg5tDsXT+UQevRe+TE8hKognmcqe9IIlbR6TwTxvbUyj7I75RzN05Oc\n\tHthoS2lvRChpc1Ts2kcZOaUaI92EMM5GJVtVTB78=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-9-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-9-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 08/35] libcamera: converter_v4l2_m2m: Always set\n\tstride","From":"Isaac Scott ","Cc":"Stefan Klug ,\n\tKieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 24 Oct 2025 10:53:41 +0100","Message-ID":"<176129962186.114750.11126835949420374056@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36468,"web_url":"https://patchwork.libcamera.org/comment/36468/","msgid":"","date":"2025-10-25T13:44:24","subject":"Re: [PATCH v2 08/35] libcamera: converter_v4l2_m2m: Always set\n\tstride","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Thu, Oct 23, 2025 at 04:48:09PM +0200, Stefan Klug wrote:\n> Ensure the stride is properly set after a call to validateOutput().\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index c6153d728c9a..e57db8a438ab 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -680,6 +680,7 @@ int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,\n> \n> \tconst Size cfgSize = cfg->size;\n> \tcfg->size = adjustSizes(cfgSize, it->second, align);\n> +\tcfg->stride = PixelFormatInfo::info(cfg->pixelFormat).stride(cfg->size.width, 0);\n> \n> \tif (cfg->size.isNull())\n> \t\treturn -EINVAL;\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBFFCC3259\n\tfor ;\n\tSat, 25 Oct 2025 13:43:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BFC4606D6;\n\tSat, 25 Oct 2025 15:43:57 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4623D60697\n\tfor ;\n\tSat, 25 Oct 2025 15:43:55 +0200 (CEST)","from amazon1-vf-gw.lnd.cw.net ([195.89.103.118] helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vCeYk-00F7O9-Ip; Sat, 25 Oct 2025 15:43:54 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"kLYooyXL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=LXHccccN1Waysw+aUdly+iscN1CImset4xOyhwmrMRE=;\n\tb=kLYooyXLSEXoUBwB6hL0znvw7b\n\th9+Bs5RxzrKtxeEzhz1sGZBaVKZEXIqb6r1jW7Kqj3mTg3o24HAgclYGrBhM+A5TJ9GCgS8/yMUXQ\n\tX1QCOgkmgwDDwnzn+ALgIXM7BK6lZk0fVIle8GevJ0HRisZEqh/1mSN42Br9w0rYTtN2R5wh3WJVw\n\tGB1HvAkJQm4OSOyUnNBcbwNhgHrVkDg97luZj395U2SKUnFxmDbSimgStmk7jL4kP1JJ5ZrRtTevV\n\tSnBPPhkVH2jiKKo+VMZx03FXU/vB1tAqVF0nBBZ/kkvIp2nWkwpmMZKsOaefmDOARi+mLY7ZSYHoO\n\tn5zhgY1g==;","Date":"Sat, 25 Oct 2025 14:44:24 +0100","From":"Umang Jain ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham ","Subject":"Re: [PATCH v2 08/35] libcamera: converter_v4l2_m2m: Always set\n\tstride","Message-ID":"","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-9-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20251023144841.403689-9-stefan.klug@ideasonboard.com>","User-Agent":"NeoMutt/20250905-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36709,"web_url":"https://patchwork.libcamera.org/comment/36709/","msgid":"<176236118891.2116251.16116801820342111811@neptunite.rasen.tech>","date":"2025-11-05T16:46:28","subject":"Re: [PATCH v2 08/35] libcamera: converter_v4l2_m2m: Always set\n\tstride","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-23 23:48:09)\n> Ensure the stride is properly set after a call to validateOutput().\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> \n> ---\n> \n> Changes in v2:\n> - Collected tag\n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index c6153d728c9a..e57db8a438ab 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -680,6 +680,7 @@ int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,\n> \n> const Size cfgSize = cfg->size;\n> cfg->size = adjustSizes(cfgSize, it->second, align);\n> + cfg->stride = PixelFormatInfo::info(cfg->pixelFormat).stride(cfg->size.width, 0);\n> \n> if (cfg->size.isNull())\n> return -EINVAL;\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69EF0BDE4C\n\tfor ;\n\tWed, 5 Nov 2025 16:46:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25CC760A80;\n\tWed, 5 Nov 2025 17:46:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6702C609DE\n\tfor ;\n\tWed, 5 Nov 2025 17:46:35 +0100 (CET)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:d4d0:27ea:7a74:8a9e])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 894AD1129; \n\tWed, 5 Nov 2025 17:44:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fNaVYSvQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762361081;\n\tbh=3wrXW4d7QiuPH/RFYswiqhtrGK4NoEINeLG8gmv+AWg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fNaVYSvQNUirUYXvcBP0Wn89Z3geOcbln/uyrOxrC6Xrf1a4QtBVWIlf/R6Es+eii\n\tnF+YdqW9Eik/puFWgk7qyOn/4un+NizPegptruOJwuacbrmRP3PYYFW4/RqlrErRL8\n\tUOM6LvhMVlohYmwU7NQzdz+w6BXjqXQ0RJAqau/E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-9-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-9-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 08/35] libcamera: converter_v4l2_m2m: Always set\n\tstride","From":"Paul Elder ","Cc":"Stefan Klug ,\n\tKieran Bingham ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 06 Nov 2025 01:46:28 +0900","Message-ID":"<176236118891.2116251.16116801820342111811@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]