{"id":24734,"url":"https://patchwork.libcamera.org/api/patches/24734/?format=json","web_url":"https://patchwork.libcamera.org/patch/24734/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023144841.403689-7-stefan.klug@ideasonboard.com>","date":"2025-10-23T14:48:07","name":"[v2,06/35] libcamera: converter: Add V4L2 request support","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"69ab37c36f61b91aa9446b8a04feb0d4fd681142","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24734/mbox/","series":[{"id":5520,"url":"https://patchwork.libcamera.org/api/series/5520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5520","date":"2025-10-23T14:48:01","name":"Full dewarper support on imx8mp","version":2,"mbox":"https://patchwork.libcamera.org/series/5520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24734/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24734/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA314BE080\n\tfor ;\n\tThu, 23 Oct 2025 14:49:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E594607FE;\n\tThu, 23 Oct 2025 16:49:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2ABF607ED\n\tfor ;\n\tThu, 23 Oct 2025 16:49:04 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BB2A9192B; \n\tThu, 23 Oct 2025 16:47:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hQW+jv+N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230839;\n\tbh=xBaT0D20jSTsUMVoqorXpecGMHSBSZegT7R0a+xjw0A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hQW+jv+Nk4O3vYkDuyV0h7JTrnAGihFCvxzdHvt8UwWhmaBjSnhMZH17qkNV/ub35\n\trlEZ1EG3xVFs6QppGxon3V/vEELk8Hw90mtOb1CyBej2rwYsAnxM9IvdiijXBIT6xM\n\tH1pHUCGL126lwSLW6jukmXDsZzd3KLOx/xEJvqvI=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v2 06/35] libcamera: converter: Add V4L2 request support","Date":"Thu, 23 Oct 2025 16:48:07 +0200","Message-ID":"<20251023144841.403689-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add V4L2 request support to the V4L2M2MConverter class. Extend the\nfunctions related to buffer queuing with an optional request parameter\nthat gets passed to the lower layers.\n\nSigned-off-by: Stefan Klug \n---\n include/libcamera/internal/converter.h | 4 +++-\n .../internal/converter/converter_v4l2_m2m.h | 6 ++++--\n src/libcamera/converter.cpp | 3 +++\n src/libcamera/converter/converter_v4l2_m2m.cpp | 12 ++++++++----\n 4 files changed, 18 insertions(+), 7 deletions(-)","diff":"diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\nindex 4915af7ac5de..4b811686fcf6 100644\n--- a/include/libcamera/internal/converter.h\n+++ b/include/libcamera/internal/converter.h\n@@ -22,6 +22,7 @@\n #include \n \n #include \n+#include \"libcamera/internal/v4l2_request.h\"\n \n namespace libcamera {\n \n@@ -79,7 +80,8 @@ public:\n \tvirtual void stop() = 0;\n \n \tvirtual int queueBuffers(FrameBuffer *input,\n-\t\t\t\t const std::map &outputs) = 0;\n+\t\t\t\t const std::map &outputs,\n+\t\t\t\t const V4L2Request *request = nullptr) = 0;\n \n \tvirtual int setInputCrop(const Stream *stream, Rectangle *rect) = 0;\n \tvirtual std::pair inputCropBounds() = 0;\ndiff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\nindex d316754040dd..1b2a88c4a608 100644\n--- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n+++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n@@ -66,7 +66,8 @@ public:\n \t\t\t Alignment align = Alignment::Down) override;\n \n \tint queueBuffers(FrameBuffer *input,\n-\t\t\t const std::map &outputs) override;\n+\t\t\t const std::map &outputs,\n+\t\t\t const V4L2Request *request = nullptr) override;\n \n \tint setInputCrop(const Stream *stream, Rectangle *rect) override;\n \tstd::pair inputCropBounds() override { return inputCropBounds_; }\n@@ -88,7 +89,8 @@ private:\n \t\tint start();\n \t\tvoid stop();\n \n-\t\tint queueBuffers(FrameBuffer *input, FrameBuffer *output);\n+\t\tint queueBuffers(FrameBuffer *input, FrameBuffer *output,\n+\t\t\t\t const V4L2Request *request = nullptr);\n \n \t\tint setInputSelection(unsigned int target, Rectangle *rect);\n \t\tint getInputSelection(unsigned int target, Rectangle *rect);\ndiff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\nindex 142fb29a1272..ec0a6db6c035 100644\n--- a/src/libcamera/converter.cpp\n+++ b/src/libcamera/converter.cpp\n@@ -205,11 +205,14 @@ Converter::~Converter()\n * \\param[in] input The frame buffer to apply the conversion\n * \\param[out] outputs The container holding the output stream pointers and\n * their respective frame buffer outputs.\n+ * \\param[in] request An optional request\n *\n * This function queues the \\a input frame buffer on the output streams of the\n * \\a outputs map key and retrieve the output frame buffer indicated by the\n * buffer map value.\n *\n+ * If \\a request is provided the buffers are tied to that request.\n+ *\n * \\return 0 on success or a negative error code otherwise\n */\n \ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex b2bd54f368d8..ff11a9735db7 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -22,6 +22,7 @@\n #include \n \n #include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/v4l2_request.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n /**\n@@ -197,9 +198,11 @@ void V4L2M2MConverter::V4L2M2MStream::stop()\n \tm2m_->output()->releaseBuffers();\n }\n \n-int V4L2M2MConverter::V4L2M2MStream::queueBuffers(FrameBuffer *input, FrameBuffer *output)\n+int V4L2M2MConverter::V4L2M2MStream::queueBuffers(FrameBuffer *input,\n+\t\t\t\t\t\t FrameBuffer *output,\n+\t\t\t\t\t\t const V4L2Request *request)\n {\n-\tint ret = m2m_->output()->queueBuffer(input);\n+\tint ret = m2m_->output()->queueBuffer(input, request);\n \tif (ret < 0)\n \t\treturn ret;\n \n@@ -696,7 +699,8 @@ int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,\n * \\copydoc libcamera::Converter::queueBuffers\n */\n int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n-\t\t\t\t const std::map &outputs)\n+\t\t\t\t const std::map &outputs,\n+\t\t\t\t const V4L2Request *request)\n {\n \tstd::set outputBufs;\n \tint ret;\n@@ -721,7 +725,7 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n \n \t/* Queue the input and output buffers to all the streams. */\n \tfor (auto [stream, buffer] : outputs) {\n-\t\tret = streams_.at(stream)->queueBuffers(input, buffer);\n+\t\tret = streams_.at(stream)->queueBuffers(input, buffer, request);\n \t\tif (ret < 0)\n \t\t\treturn ret;\n \t}\n","prefixes":["v2","06/35"]}