[{"id":36489,"web_url":"https://patchwork.libcamera.org/comment/36489/","msgid":"<176157666222.59544.2052023765385793974@isaac-ThinkPad-T16-Gen-2>","date":"2025-10-27T14:51:02","subject":"Re: [PATCH v2 03/35] libcamera: v4l2: Remove\n\tfromEntityName(MediaDevice*)","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch!\n\nQuoting Stefan Klug (2025-10-23 15:48:04)\n> From: Kieran Bingham \n> \n> Now that all users of the fromEntityName() helpers use the shared_ptr\n> variant, remove the original functions that are no longer used.\n> \n> Signed-off-by: Kieran Bingham \n> Signed-off-by: Paul Elder \n> ---\n> include/libcamera/internal/v4l2_subdevice.h | 2 --\n> include/libcamera/internal/v4l2_videodevice.h | 2 --\n> src/libcamera/v4l2_subdevice.cpp | 17 +----------------\n> src/libcamera/v4l2_videodevice.cpp | 17 +----------------\n> 4 files changed, 2 insertions(+), 36 deletions(-)\n> \n> diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\n> index d1c8b838d49b..b4b41806638c 100644\n> --- a/include/libcamera/internal/v4l2_subdevice.h\n> +++ b/include/libcamera/internal/v4l2_subdevice.h\n> @@ -161,8 +161,6 @@ public:\n> const std::string &model();\n> const V4L2SubdeviceCapability &caps() const { return caps_; }\n> \n> - static std::unique_ptr\n> - fromEntityName(const MediaDevice *media, const std::string &entity);\n> static std::unique_ptr\n> fromEntityName(std::shared_ptr, const std::string &entity);\n> \n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index 4f80f7176174..5a7dcfdda118 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -226,8 +226,6 @@ public:\n> void setDequeueTimeout(utils::Duration timeout);\n> Signal<> dequeueTimeout;\n> \n> - static std::unique_ptr\n> - fromEntityName(const MediaDevice *media, const std::string &entity);\n> static std::unique_ptr\n> fromEntityName(std::shared_ptr, const std::string &entity);\n> \n\nReviewed-by: Isaac Scott \n\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 1825e9e55ca4..643d63ea18bd 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -1758,7 +1758,7 @@ const std::string &V4L2Subdevice::model()\n> * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n> */\n> std::unique_ptr\n> -V4L2Subdevice::fromEntityName(const MediaDevice *media,\n> +V4L2Subdevice::fromEntityName(std::shared_ptr media,\n> const std::string &entity)\n> {\n> MediaEntity *mediaEntity = media->getEntityByName(entity);\n> @@ -1768,21 +1768,6 @@ V4L2Subdevice::fromEntityName(const MediaDevice *media,\n> return std::make_unique(mediaEntity);\n> }\n> \n> -/**\n> - * \\brief Create a new video subdevice instance from \\a entity in media device\n> - * \\a media\n> - * \\param[in] media The media device where the entity is registered\n> - * \\param[in] entity The media entity name\n> - *\n> - * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n> - */\n> -std::unique_ptr\n> -V4L2Subdevice::fromEntityName(std::shared_ptr media,\n> - const std::string &entity)\n> -{\n> - return fromEntityName(media.get(), entity);\n> -}\n> -\n> std::string V4L2Subdevice::logPrefix() const\n> {\n> return \"'\" + entity_->name() + \"'\";\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 9be5cfbc0395..bb57c1b76a5b 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -2104,7 +2104,7 @@ void V4L2VideoDevice::watchdogExpired()\n> * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n> */\n> std::unique_ptr\n> -V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n> +V4L2VideoDevice::fromEntityName(std::shared_ptr media,\n> const std::string &entity)\n> {\n> MediaEntity *mediaEntity = media->getEntityByName(entity);\n> @@ -2114,21 +2114,6 @@ V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n> return std::make_unique(mediaEntity);\n> }\n> \n> -/**\n> - * \\brief Create a new video device instance from \\a entity in media device\n> - * \\a media\n> - * \\param[in] media The media device where the entity is registered\n> - * \\param[in] entity The media entity name\n> - *\n> - * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n> - */\n> -std::unique_ptr\n> -V4L2VideoDevice::fromEntityName(std::shared_ptr media,\n> - const std::string &entity)\n> -{\n> - return fromEntityName(media.get(), entity);\n> -}\n> -\n> /**\n> * \\brief Convert \\a PixelFormat to a V4L2PixelFormat supported by the device\n> * \\param[in] pixelFormat The PixelFormat to convert\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A0A1C3259\n\tfor ;\n\tMon, 27 Oct 2025 14:51:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3708660758;\n\tMon, 27 Oct 2025 15:51:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03DF56069A\n\tfor ;\n\tMon, 27 Oct 2025 15:51:04 +0100 (CET)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C714D7E0;\n\tMon, 27 Oct 2025 15:49:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LTbG9u6f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761576556;\n\tbh=60sd22jo1NfPZ4wOIZv548s7s52MDnuQ2udJERAWN2c=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=LTbG9u6fp38SfUtTVOQaIR79M4D6dlrfp3UCosuE3lqwmwhtmpa3Ijw5EzCi0CKLV\n\tuuGohNcAn8u/Buq1KpqBF6ZGifIElCLuAUktCtzvsEN8gczfVxWrF+DL4Z/Tc40ehY\n\t2iTS5ZBp3ra7C7qBcMVZUizXXWfzTjAJchV0OER4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251023144841.403689-4-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>\n\t<20251023144841.403689-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v2 03/35] libcamera: v4l2: Remove\n\tfromEntityName(MediaDevice*)","From":"Isaac Scott ","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tPaul Elder ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 27 Oct 2025 14:51:02 +0000","Message-ID":"<176157666222.59544.2052023765385793974@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]