{"id":24729,"url":"https://patchwork.libcamera.org/api/patches/24729/?format=json","web_url":"https://patchwork.libcamera.org/patch/24729/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023144841.403689-2-stefan.klug@ideasonboard.com>","date":"2025-10-23T14:48:02","name":"[v2,01/35] libcamera: v4l2: Support fromEntityName with shared_ptr","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ca12c702ea1625164b98307f9f7f1dfa46d916ab","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24729/mbox/","series":[{"id":5520,"url":"https://patchwork.libcamera.org/api/series/5520/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5520","date":"2025-10-23T14:48:01","name":"Full dewarper support on imx8mp","version":2,"mbox":"https://patchwork.libcamera.org/series/5520/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24729/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24729/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E1DDC32CE\n\tfor ;\n\tThu, 23 Oct 2025 14:48:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD5F2607DB;\n\tThu, 23 Oct 2025 16:48:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 491FA607C9\n\tfor ;\n\tThu, 23 Oct 2025 16:48:49 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7328:357b:4ce1:72b6])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 57EFC1127; \n\tThu, 23 Oct 2025 16:47:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MGU2p1oh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761230824;\n\tbh=il1MPl9gegwLqBk2WXmpryeIZ0Js/Yid7F7UPXStGWk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MGU2p1ohPv/06gvmJWoCLIZW3bFqDEf+/i8u23EQdvgRPiRH744Gg4ulWjDELEZLi\n\tOg+7BAioytt3jWAJP1SSydUoc6K5Bqjh+6+vzBoB8CtDMerDx5iApne+TsTDUvRyz3\n\t9Msz0EMd85kIPtyN74a0ZUpbzXFawYmpw7pW1+o8=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"[PATCH v2 01/35] libcamera: v4l2: Support fromEntityName with\n\tshared_ptr","Date":"Thu, 23 Oct 2025 16:48:02 +0200","Message-ID":"<20251023144841.403689-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","References":"<20251023144841.403689-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham \n\nTo facilitate expanding the use of a shared_ptr in\npreference of a raw MediaDevice* pointer, add an additional\nimplementation for fromEntityName for both of v4l2_videodevice and\nv4l2_subdevice to support this type.\n\nSigned-off-by: Kieran Bingham \nSigned-off-by: Paul Elder \n---\n include/libcamera/internal/v4l2_subdevice.h | 2 ++\n include/libcamera/internal/v4l2_videodevice.h | 2 ++\n src/libcamera/v4l2_subdevice.cpp | 15 +++++++++++++++\n src/libcamera/v4l2_videodevice.cpp | 15 +++++++++++++++\n 4 files changed, 34 insertions(+)","diff":"diff --git a/include/libcamera/internal/v4l2_subdevice.h b/include/libcamera/internal/v4l2_subdevice.h\nindex c1cde1df2e36..d1c8b838d49b 100644\n--- a/include/libcamera/internal/v4l2_subdevice.h\n+++ b/include/libcamera/internal/v4l2_subdevice.h\n@@ -163,6 +163,8 @@ public:\n \n \tstatic std::unique_ptr\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n+\tstatic std::unique_ptr\n+\tfromEntityName(std::shared_ptr, const std::string &entity);\n \n protected:\n \tstd::string logPrefix() const override;\ndiff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex 6caafc4dcf08..4f80f7176174 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -228,6 +228,8 @@ public:\n \n \tstatic std::unique_ptr\n \tfromEntityName(const MediaDevice *media, const std::string &entity);\n+\tstatic std::unique_ptr\n+\tfromEntityName(std::shared_ptr, const std::string &entity);\n \n \tV4L2PixelFormat toV4L2PixelFormat(const PixelFormat &pixelFormat) const;\n \ndiff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\nindex 31a2ac72a7ee..1825e9e55ca4 100644\n--- a/src/libcamera/v4l2_subdevice.cpp\n+++ b/src/libcamera/v4l2_subdevice.cpp\n@@ -1768,6 +1768,21 @@ V4L2Subdevice::fromEntityName(const MediaDevice *media,\n \treturn std::make_unique(mediaEntity);\n }\n \n+/**\n+ * \\brief Create a new video subdevice instance from \\a entity in media device\n+ * \\a media\n+ * \\param[in] media The media device where the entity is registered\n+ * \\param[in] entity The media entity name\n+ *\n+ * \\return A newly created V4L2Subdevice on success, nullptr otherwise\n+ */\n+std::unique_ptr\n+V4L2Subdevice::fromEntityName(std::shared_ptr media,\n+\t\t\t const std::string &entity)\n+{\n+\treturn fromEntityName(media.get(), entity);\n+}\n+\n std::string V4L2Subdevice::logPrefix() const\n {\n \treturn \"'\" + entity_->name() + \"'\";\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 7b48d911db73..9be5cfbc0395 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -2114,6 +2114,21 @@ V4L2VideoDevice::fromEntityName(const MediaDevice *media,\n \treturn std::make_unique(mediaEntity);\n }\n \n+/**\n+ * \\brief Create a new video device instance from \\a entity in media device\n+ * \\a media\n+ * \\param[in] media The media device where the entity is registered\n+ * \\param[in] entity The media entity name\n+ *\n+ * \\return A newly created V4L2VideoDevice on success, nullptr otherwise\n+ */\n+std::unique_ptr\n+V4L2VideoDevice::fromEntityName(std::shared_ptr media,\n+\t\t\t\tconst std::string &entity)\n+{\n+\treturn fromEntityName(media.get(), entity);\n+}\n+\n /**\n * \\brief Convert \\a PixelFormat to a V4L2PixelFormat supported by the device\n * \\param[in] pixelFormat The PixelFormat to convert\n","prefixes":["v2","01/35"]}