{"id":24726,"url":"https://patchwork.libcamera.org/api/patches/24726/?format=json","web_url":"https://patchwork.libcamera.org/patch/24726/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251023115034.2207-2-david.plowman@raspberrypi.com>","date":"2025-10-23T11:49:13","name":"[v2,1/5] ipa: rpi: Fix the set function for floating statistics regions","commit_ref":"557622308ff347bf98e42dc159337d5126029ca7","pull_url":null,"state":"accepted","archived":false,"hash":"31292b0aeecc0db121c9cb7056ba17001b226c03","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24726/mbox/","series":[{"id":5519,"url":"https://patchwork.libcamera.org/api/series/5519/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5519","date":"2025-10-23T11:49:12","name":"Fix and improve full image Y statistics","version":2,"mbox":"https://patchwork.libcamera.org/series/5519/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24726/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24726/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C213CC32CE\n\tfor ;\n\tThu, 23 Oct 2025 11:50:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE18960763;\n\tThu, 23 Oct 2025 13:50:42 +0200 (CEST)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F708606E0\n\tfor ;\n\tThu, 23 Oct 2025 13:50:40 +0200 (CEST)","by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-4270a0127e1so476435f8f.3\n\tfor ;\n\tThu, 23 Oct 2025 04:50:40 -0700 (PDT)","from davidp-pi.pitowers.org\n\t([2a00:1098:3142:1f:f75f:a9a5:3eb7:34d4])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4298b996aaasm1900760f8f.3.2025.10.23.04.50.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 23 Oct 2025 04:50:39 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"L2VxCyfj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1761220240; x=1761825040;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=PSNl1fKNYqqrXL9+8+lTPsK2c3rNasItZ3vGAP/DQ3Q=;\n\tb=L2VxCyfjCa9x+W9X8kOXsI1mWQTTbYtvmk3+shC/vCV2Pp5x6JJBiuAdJ5dUVTinTQ\n\t02Ua/k06WLIxdy9TvFrOW2aaaZFPPNeZufjwnmJHkHlT7BURMcAWJQycMnQdXxIQwiaP\n\tE2EmlSIVg1xuEdttM0reZYvXb2cCevxvwPTcu08eezmHXIXb8BaJ8DJaEePAev9+xZgi\n\tTIBnO9x0bo7nNEfntF+lQlMLJjV1rvLJvHX4zpQRwAysab4Z15rNn+9mc5RWKBbRKcwL\n\tzk4QqecGP1faFet1t9Ad+DnD4MThu6cpKRrXOK/Myh8v1gd4RiBvFMpXRp9xw5+i61sA\n\txslw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1761220240; x=1761825040;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=PSNl1fKNYqqrXL9+8+lTPsK2c3rNasItZ3vGAP/DQ3Q=;\n\tb=pDriTIV/E9hOV+GlCgtV3KuegblllczJclKOdpt6ieThgLUUkD4psuHcGPDYi4vAL5\n\tOIxNoR2uMApYI6FtCqGxc4btVNEbhgfGUAfUhB7Jkmn0VXM+SDVAhGh5yvc+u53F9HF5\n\tHP1cnH1Lby1NxT4wbbkIcO0RSAvIszCwg/PrmYm4GZnEIUjNLlbJjv0UcaiKc1Bdcs6O\n\ttli7PEkKcxO3jaDZfjSRG59255gAgZINKugXTwbU50KUj1FEHC3EeU9PxM+FC6+Zlf3I\n\tKNcMMwiVc3yNRgJ830ZuOi6ZoOmgP7/JRIefDNbK7QHFGLVn3RloiJ8ewyzneW56uADC\n\tqfLA==","X-Gm-Message-State":"AOJu0YwTU9158QKwJ52k/Yj4zwIYrrO/5Ax8kzomJ2lHzq3KYrhi7bTW\n\tdIGQ8X8JXth3cupAghSuTQ0rey/GC0mJzqdMsvytRofwzvCpj8y9eAlu5q20vYKO9nrsZ9Ypslr\n\tuPGQHvSA=","X-Gm-Gg":"ASbGncubCzowtAYSYAOFjoXoXtGMX6CBYmnKcBpM8zfg1ijsdmWay87LxDSGABZ+/7a\n\tAMo+zr9DTt2alzLzOnpyuIeOFKaJetqFjyLc+vlTxkZlo93lJC9W7pkqOS/BT0l+XwbaUu2SHeh\n\t81meA4yCVzkHMAEGD4aXtIfV1Pi+jzcyLbgLKo4Zu9NjRy+xsfDoH5H/3rRl0sGSUEvgJuYmFLJ\n\tXUQhhyu5CEJYLEOunj8cX84isFpSNdgn8ZAI0x3+reIiPgfzssdAAcL3D/qDb2ZmKWcsejH1Vmu\n\toc/B4JphjevGLwqTULn+Zld67JTQEmkS3f8Mb8cr5r18k/3gSa5IG/Rw4xBeKhFG9fS0074qtNN\n\tGCsuO4v6WqE5rDAW0iCRw9AXox7v/yIac22YULE22LJj0Uk5/nlEBifUOIAP1j2r/6Nn9jt6JiV\n\t2RDX8NylAOiseN+/RkTPPwur3YDzt3ftjQmrYtyc9yCEX/g2YNg1FC8QB3a74uaefJzHwhx0eu2\n\tuBiEEIGK6VC5+AidUlxir7s8Hnl","X-Google-Smtp-Source":"AGHT+IGbhRN+qq3Z9z6JiQW0ZVh8wg7+9uOnfl74KhmEkABF5sdfWdNBSEp9ZMlNcFK25UnndBzsRQ==","X-Received":"by 2002:a05:6000:612:b0:3fe:efa8:7f1d with SMTP id\n\tffacd0b85a97d-42704d4431cmr14886080f8f.7.1761220239833; \n\tThu, 23 Oct 2025 04:50:39 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Cc":"David Plowman ,\n\tStefan Klug ,\n\tNaushir Patuck ","Subject":"[PATCH v2 1/5] ipa: rpi: Fix the set function for floating\n\tstatistics regions","Date":"Thu, 23 Oct 2025 12:49:13 +0100","Message-ID":"<20251023115034.2207-2-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20251023115034.2207-1-david.plowman@raspberrypi.com>","References":"<20251023115034.2207-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Previously it was calling the wrong internal function which would do\nnothing.\n\nSigned-off-by: David Plowman \nReviewed-by: Stefan Klug \nReviewed-by: Naushir Patuck \n---\n src/ipa/rpi/controller/region_stats.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/controller/region_stats.h b/src/ipa/rpi/controller/region_stats.h\nindex c60f7d9a..0f8c276a 100644\n--- a/src/ipa/rpi/controller/region_stats.h\n+++ b/src/ipa/rpi/controller/region_stats.h\n@@ -76,7 +76,7 @@ public:\n \t{\n \t\tif (index >= numFloatingRegions())\n \t\t\treturn;\n-\t\tset(numRegions() + index, region);\n+\t\tset_(numRegions() + index, region);\n \t}\n \n \tconst Region &get(unsigned int index) const\n","prefixes":["v2","1/5"]}