[{"id":36435,"web_url":"https://patchwork.libcamera.org/comment/36435/","msgid":"","date":"2025-10-24T11:54:11","subject":"Re: [PATCH v13 5/8] libcamera: simple: Don't enforce conversion with\n\tan added raw stream","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Tue, Oct 21, 2025 at 08:27:12PM +0200, Milan Zamazal wrote:\n> When a raw stream is requested, either alone or together with a\n> processed stream, it can be produced without conversion. Let's amend\n> the corresponding check on the number of configurations, so that the\n> mere presence of a raw stream doesn't enforce conversion.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 1943b6e72..703917a68 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1228,7 +1228,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> \t * require any conversion, similar to raw capture use cases). This is\n> \t * left as a future improvement.\n> \t */\n> -\tneedConversion_ = config_.size() > 1;\n> +\tneedConversion_ = config_.size() > 1 + (rawFormat ? 1 : 0);\n> \n> \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n> \t\tStreamConfiguration &cfg = config_[i];\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F14E9BE080\n\tfor ;\n\tFri, 24 Oct 2025 11:53:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D88E6096D;\n\tFri, 24 Oct 2025 13:53:44 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD076608F6\n\tfor ;\n\tFri, 24 Oct 2025 13:53:42 +0200 (CEST)","from 62-244-186-53.cust.exponential-e.net ([62.244.186.53]\n\thelo=uajain) by fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vCGMY-00EkAy-0K; Fri, 24 Oct 2025 13:53:42 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"Q8F85Vwu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=ERzRJqHy9EuGhBVCc4p+3AMwb5jQExaYfGdGZbSqtw4=;\n\tb=Q8F85VwuhjlYar84y0YL7RkBqr\n\t1TMit0K2KsSqrO6XF+lQmZV3L/x6ikRMJx+Hgm7SccPFduhXRs93QOoNarCuCFwOpCrssccmGsqPs\n\txD1TO7b4zTFjg07cnh0UBPlZdNaOFJhlUdLkZCixEPqfswvRV5lyn7ZBsOWkVXywZdeeFhd4HWVY6\n\tLsjNbEdH2KDFP2DTjiLgetOMjyZsLZkA244NTsAN2B5V05caZ5Z2YO9q2LZKcxSRmM6Cp7quioe/N\n\t0VNP1CiOTtFPEWueaodEFZU5rgwVcsaONY/lZgWWqj2J7PN/8FJ+zA82cVk9OEaQCrz+ssAQo8Anu\n\t8IDOmf/g==;","Date":"Fri, 24 Oct 2025 12:54:11 +0100","From":"Umang Jain ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t","Subject":"Re: [PATCH v13 5/8] libcamera: simple: Don't enforce conversion with\n\tan added raw stream","Message-ID":"","References":"<20251021182716.29274-1-mzamazal@redhat.com>\n\t<20251021182716.29274-6-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20251021182716.29274-6-mzamazal@redhat.com>","User-Agent":"NeoMutt/20250905-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]