[{"id":36432,"web_url":"https://patchwork.libcamera.org/comment/36432/","msgid":"","date":"2025-10-24T11:47:53","subject":"Re: [PATCH v13 2/8] libcamera: simple: Exclude raw configurations\n\tfrom output conversions","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/","name":"Umang Jain","email":"uajain@igalia.com"},"content":"On Tue, Oct 21, 2025 at 08:27:09PM +0200, Milan Zamazal wrote:\n> In order to support raw streams, we need to add raw formats to software\n> ISP configurations. In this preparatory patch, the raw formats are\n> excluded from output configurations for conversions.\n> \n> Signed-off-by: Milan Zamazal \n> Reviewed-by: Umang Jain \n> Signed-off-by: Milan Zamazal \n\nDouble S-o-B things here... and other patches..\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 2f5103a18..1f67094db 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -27,6 +27,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n> @@ -264,6 +265,12 @@ static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"sun6i-csi\", {}, false },\n> };\n> \n> +bool isRaw(const StreamConfiguration &cfg)\n> +{\n> +\treturn libcamera::PixelFormatInfo::info(cfg.pixelFormat).colourEncoding ==\n> +\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n> +}\n> +\n> } /* namespace */\n> \n> class SimpleCameraData : public Camera::Private\n> @@ -1445,7 +1452,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \n> \t\tcfg.setStream(&data->streams_[i]);\n> \n> -\t\tif (data->useConversion_)\n> +\t\tif (data->useConversion_ && !isRaw(cfg))\n> \t\t\toutputCfgs.push_back(cfg);\n> \t}\n> \n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 675BBBE080\n\tfor ;\n\tFri, 24 Oct 2025 11:47:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20AA1608D0;\n\tFri, 24 Oct 2025 13:47:25 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 39A4A608BD\n\tfor ;\n\tFri, 24 Oct 2025 13:47:24 +0200 (CEST)","from 62-244-186-53.cust.exponential-e.net ([62.244.186.53]\n\thelo=uajain) by fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1vCGGR-00Ek3w-JZ; Fri, 24 Oct 2025 13:47:23 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"GBuSmfx7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=BOco8NHgmQuFLt/pBYhABFMTL05DtzaTxsUKOA2v+/k=;\n\tb=GBuSmfx7ywm5ER05By33s8vp4Y\n\tGBdH8RuHPCwaLGPQXI4zGlAWlG2vc6Y0nmT/L0n4aDXZA4vUht2lnXWCtXVstPVAD1KRsKL9bcnsd\n\tgMOwzcMS+2v8zKBtWNVTSdY6d6WrNX/yXAYjfPAc22NrFPpqWkvPQ5D9jhf7ama7i9c/n2GwNTenj\n\t/3Qa5aqAox9Takp9TPPGG6qPDU6/fXyPSgyDxX6BdJMUpylYH8wuG/wwphBtRWw+7xp49FtoyVL9D\n\tWVV7Ys1lncczA0eO3NoZjpXG3XCh2O1qw2pfNp+WQvqHCJJBKUsAcO4sqdiemBPOHlaI1F2gJj83J\n\twzuEfJIw==;","Date":"Fri, 24 Oct 2025 12:47:53 +0100","From":"Umang Jain ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t","Subject":"Re: [PATCH v13 2/8] libcamera: simple: Exclude raw configurations\n\tfrom output conversions","Message-ID":"","References":"<20251021182716.29274-1-mzamazal@redhat.com>\n\t<20251021182716.29274-3-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20251021182716.29274-3-mzamazal@redhat.com>","User-Agent":"NeoMutt/20250905-dirty","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]