{"id":24712,"url":"https://patchwork.libcamera.org/api/patches/24712/?format=json","web_url":"https://patchwork.libcamera.org/patch/24712/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251021182716.29274-3-mzamazal@redhat.com>","date":"2025-10-21T18:27:09","name":"[v13,2/8] libcamera: simple: Exclude raw configurations from output conversions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"616c72732193c71cff33afebd9240619557dc716","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24712/mbox/","series":[{"id":5515,"url":"https://patchwork.libcamera.org/api/series/5515/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5515","date":"2025-10-21T18:27:07","name":"Enable raw streams with software ISP","version":13,"mbox":"https://patchwork.libcamera.org/series/5515/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24712/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24712/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8675BBE080\n\tfor ;\n\tTue, 21 Oct 2025 18:27:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B2B360787;\n\tTue, 21 Oct 2025 20:27:41 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3B226077D\n\tfor ;\n\tTue, 21 Oct 2025 20:27:39 +0200 (CEST)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-319-jPdQaVv0NLG0B_mhJE8TBA-1;\n\tTue, 21 Oct 2025 14:27:35 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2678E18009C2; Tue, 21 Oct 2025 18:27:34 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.124])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id F2830180044F; Tue, 21 Oct 2025 18:27:30 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ctCWtB1I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1761071259;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=po5AD+xrMEYFeHSA4A1neM/at3nJ8iTpJCMF1ddLtfg=;\n\tb=ctCWtB1IwRPVtefu6Q/lgCj6YIhlQ6j/D4can6eJqHjZABwLICzdOi1MTVyXIGnLweXZaZ\n\txFuKvrsk/ipbSPdKdE00PO/yiLnErmLQWrTrzyKnny+SSHAVbWITh13xKDUWUpTUV3IPHT\n\tWP3ruCyxkLbi9YkB4mpc/3SysW4+pOw=","X-MC-Unique":"jPdQaVv0NLG0B_mhJE8TBA-1","X-Mimecast-MFC-AGG-ID":"jPdQaVv0NLG0B_mhJE8TBA_1761071254","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Umang Jain ","Subject":"[PATCH v13 2/8] libcamera: simple: Exclude raw configurations from\n\toutput conversions","Date":"Tue, 21 Oct 2025 20:27:09 +0200","Message-ID":"<20251021182716.29274-3-mzamazal@redhat.com>","In-Reply-To":"<20251021182716.29274-1-mzamazal@redhat.com>","References":"<20251021182716.29274-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"lKFmUD84GREYcYczLbAcBq-hd08Mkp7AZvvovHL-5VI_1761071254","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to support raw streams, we need to add raw formats to software\nISP configurations. In this preparatory patch, the raw formats are\nexcluded from output configurations for conversions.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Umang Jain \nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 2f5103a18..1f67094db 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -27,6 +27,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -264,6 +265,12 @@ static const SimplePipelineInfo supportedDevices[] = {\n \t{ \"sun6i-csi\", {}, false },\n };\n \n+bool isRaw(const StreamConfiguration &cfg)\n+{\n+\treturn libcamera::PixelFormatInfo::info(cfg.pixelFormat).colourEncoding ==\n+\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n+}\n+\n } /* namespace */\n \n class SimpleCameraData : public Camera::Private\n@@ -1445,7 +1452,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \n \t\tcfg.setStream(&data->streams_[i]);\n \n-\t\tif (data->useConversion_)\n+\t\tif (data->useConversion_ && !isRaw(cfg))\n \t\t\toutputCfgs.push_back(cfg);\n \t}\n \n","prefixes":["v13","2/8"]}