[{"id":36350,"web_url":"https://patchwork.libcamera.org/comment/36350/","msgid":"<176095331128.336133.2857783940397074999@localhost>","date":"2025-10-20T09:41:51","subject":"Re: [PATCH 1/5] ipa: rpi: Fix the set function for floating\n\tstatistics regions","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi David,\n\nQuoting David Plowman (2025-10-17 12:05:37)\n> Previously it was calling the wrong internal function which would do\n> nothing.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/ipa/rpi/controller/region_stats.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/controller/region_stats.h b/src/ipa/rpi/controller/region_stats.h\n> index c60f7d9a..0f8c276a 100644\n> --- a/src/ipa/rpi/controller/region_stats.h\n> +++ b/src/ipa/rpi/controller/region_stats.h\n> @@ -76,7 +76,7 @@ public:\n> {\n> if (index >= numFloatingRegions())\n> return;\n> - set(numRegions() + index, region);\n> + set_(numRegions() + index, region);\n> }\n> \n> const Region &get(unsigned int index) const\n> -- \n> 2.47.3\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F142C3259\n\tfor ;\n\tMon, 20 Oct 2025 09:41:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5AFD606FF;\n\tMon, 20 Oct 2025 11:41:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF412606F1\n\tfor ;\n\tMon, 20 Oct 2025 11:41:54 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9f50:5b33:d3ec:e1ea])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0BD2AF52;\n\tMon, 20 Oct 2025 11:40:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wR0BZMiF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760953212;\n\tbh=Yzksf7Neyo01t1Ysb5rcJ4DNmRTpLmH2aBIBnjSrQwQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=wR0BZMiF7P3u+19RtgfqlVlg0NdfP0UX+9R5j6oS1wJb1HV3iOxG0Z03dSOeNRTM1\n\tiAlZrZVz638l3KmbMrjK4UgOQqlBK2H+cjxzoJXLayHMcmAjS2r6II3/kv2oiRv5Dp\n\tYGaTgAXaSweVeyfOeDPrWIKqsGDcCT7FTeTH17ZM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251017102704.3887-2-david.plowman@raspberrypi.com>","References":"<20251017102704.3887-1-david.plowman@raspberrypi.com>\n\t<20251017102704.3887-2-david.plowman@raspberrypi.com>","Subject":"Re: [PATCH 1/5] ipa: rpi: Fix the set function for floating\n\tstatistics regions","From":"Stefan Klug ","Cc":"David Plowman ","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 20 Oct 2025 11:41:51 +0200","Message-ID":"<176095331128.336133.2857783940397074999@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36395,"web_url":"https://patchwork.libcamera.org/comment/36395/","msgid":"","date":"2025-10-23T07:24:39","subject":"Re: [PATCH 1/5] ipa: rpi: Fix the set function for floating\n\tstatistics regions","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\n\nOn Fri, 17 Oct 2025 at 11:27, David Plowman \nwrote:\n\n> Previously it was calling the wrong internal function which would do\n> nothing.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/rpi/controller/region_stats.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/controller/region_stats.h\n> b/src/ipa/rpi/controller/region_stats.h\n> index c60f7d9a..0f8c276a 100644\n> --- a/src/ipa/rpi/controller/region_stats.h\n> +++ b/src/ipa/rpi/controller/region_stats.h\n> @@ -76,7 +76,7 @@ public:\n> {\n> if (index >= numFloatingRegions())\n> return;\n> - set(numRegions() + index, region);\n> + set_(numRegions() + index, region);\n> }\n>\n> const Region &get(unsigned int index) const\n> --\n> 2.47.3\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A3DEBE080\n\tfor ;\n\tThu, 23 Oct 2025 07:25:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7699B607AC;\n\tThu, 23 Oct 2025 09:25:18 +0200 (CEST)","from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com\n\t[IPv6:2607:f8b0:4864:20::e2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CBAF6074E\n\tfor ;\n\tThu, 23 Oct 2025 09:25:16 +0200 (CEST)","by mail-vs1-xe2c.google.com with SMTP id\n\tada2fe7eead31-5c3cd705475so24773137.0\n\tfor ;\n\tThu, 23 Oct 2025 00:25:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Akou8/gq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1761204315; x=1761809115;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ttwcMblcP4JDGNAMaEFeBA4yDWaTaHmmdRwkL3fzJg8=;\n\tb=Akou8/gqkCEjPmqG0cotHE4/W6wJopux1C75e0YjIO+Oe15ObnXTDFvwP16mTnL3SB\n\tJuxpq6c1iinMJ9noAf90Bgl+s/in/VNqX3LRcAkbcIKqlhYk6g0YJh6WirtNC4uhYZGj\n\tabWzUlZqWp2RfLbGOL24mG0kiOPCPqQkjopVlyn0udxRyn33ueF+wKs5VYuv+fsF2dOc\n\t1CI/HenXlVry0gOpxTInLENu60WeOeAg43FvAA09Tk4AN+Hn24JQIGkzkVL4xZqArda/\n\ts3dFMVuwCpexs9DPemRKx0pDfjryWoo2OLBsh4eeU0nm3uQ3DhyE9axDLkYA/mbfDRcp\n\tuZhw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1761204315; x=1761809115;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ttwcMblcP4JDGNAMaEFeBA4yDWaTaHmmdRwkL3fzJg8=;\n\tb=f8Q+YzyKRgv0u0auMhZ6CbzXetFSTIMKFMStOdKBNYYcYV9REyxL4na7Y1hdYvNyCv\n\t9+UgtaInPy1ng4mcf7sx0OyQSzcr8hOMpF8hEyLfFF382aV9I57R/FZ1HoLIaI2daOwo\n\tsEnkojdIqPMcpnxPBr7bVHnJPsH/Mv4+LdFHzbKd9tO8t88W0buzSZCy3KiqnERSQzOT\n\t1ZsTkMsSKq24IR0PtirjcOwSlqPTJmo00rbZHZp8eaYr6f0phqKZKxf7r9QJ7L+qPoN8\n\ttpiesF3FuRL1Tmkc9Hr48r3PRJlOfPGBYOK+CUcl0eOzHyudlJzWyQ+75Lgkfdo0bC0A\n\tfkCA==","X-Gm-Message-State":"AOJu0YybdaHjMJqfe+g7XCXoAksG2goJugwfeAyTqVJk+AaIXTNBFbsK\n\tQVZU31x+tzGa/HwpwZinv9df7E+XG5Hf38szyrScXhIrte1j0NED0qNGyYtCiNUGcwQC0u3gR4F\n\tKZait72fjcviHo7oMdzkCdOI8nSnHjOJwEwCNtrXfLQ==","X-Gm-Gg":"ASbGncsGYXTD1CIb9mUGm59QAH1Im6Nzo8tkldpoxuQwCpLCiMBa8R1bTLvr2+eZHft\n\t5ND9APYfGYOR7b4MpBuK5WE4dHAzgE+vJDKQzapV/4n1nXqQYHeyqsKLB0Lk5Q3ADsHnC1iDyzy\n\tI0VGREx/pR6W69WkozQMiLhEsj/e96+qELhIz8i6J+jTj39wSanLhN33BEx941ZR43ngnik4ZGk\n\ts8MngO0l8MlvwtP6vwgwdvHXumvng5iaVe+M8a+X1/dmKIrc1BkoI6v9C1RaU9aX5X0Ve3CMahl\n\t+8G31+bGiSY9/nUC5Ky5KUzdQg==","X-Google-Smtp-Source":"AGHT+IF4aimq3Yx6tVP4ifzZx0wZAt4R4PB1IrWUv9z7GqpbNyPP2hjWdIalcT6BBY9Mwpt1wN9h2v7/8gJBhcvdhv0=","X-Received":"by 2002:a05:6102:3ec4:b0:4e9:924f:eea9 with SMTP id\n\tada2fe7eead31-5db0dfe10b2mr1434415137.1.1761204314759;\n\tThu, 23 Oct 2025 00:25:14 -0700 (PDT)","MIME-Version":"1.0","References":"<20251017102704.3887-1-david.plowman@raspberrypi.com>\n\t<20251017102704.3887-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20251017102704.3887-2-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Thu, 23 Oct 2025 08:24:39 +0100","X-Gm-Features":"AWmQ_bkgMttL1B2XoDaV6Io5P7WfxVFc8v8t_filEIzMrORbOl1labXbtj6JPUo","Message-ID":"","Subject":"Re: [PATCH 1/5] ipa: rpi: Fix the set function for floating\n\tstatistics regions","To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"0000000000008f04420641ce5573\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]