{"id":24698,"url":"https://patchwork.libcamera.org/api/patches/24698/?format=json","web_url":"https://patchwork.libcamera.org/patch/24698/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251017102704.3887-2-david.plowman@raspberrypi.com>","date":"2025-10-17T10:05:37","name":"[1/5] ipa: rpi: Fix the set function for floating statistics regions","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"31292b0aeecc0db121c9cb7056ba17001b226c03","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24698/mbox/","series":[{"id":5509,"url":"https://patchwork.libcamera.org/api/series/5509/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5509","date":"2025-10-17T10:05:36","name":"Fix and improve full image Y statistics","version":1,"mbox":"https://patchwork.libcamera.org/series/5509/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24698/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24698/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75054C3259\n\tfor ;\n\tFri, 17 Oct 2025 10:27:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7220606BD;\n\tFri, 17 Oct 2025 12:27:10 +0200 (CEST)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6EDB960697\n\tfor ;\n\tFri, 17 Oct 2025 12:27:09 +0200 (CEST)","by mail-wr1-x429.google.com with SMTP id\n\tffacd0b85a97d-421851bcb25so962873f8f.2\n\tfor ;\n\tFri, 17 Oct 2025 03:27:09 -0700 (PDT)","from localhost.localdomain ([2a06:61c0:f337:0:8aba:2a85:b765:a23e])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47114428dedsm73811905e9.7.2025.10.17.03.27.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Oct 2025 03:27:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"g1kpg2R1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1760696829; x=1761301629;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=/2QN7fWMQGXqIpyN9QKsxBjaJCwKW5I0LT90q69/hIo=;\n\tb=g1kpg2R13+qemDB6Dpclo3E9YDWN/UXB6vvTP7d79sEKzuUOMklh/Sdov/7r+oeXHo\n\txF5uAIrCN2+Sse9II7vV6uNzhJD8vHnVJmc6XuzVkYTiVPmyzXzBgmRFv6n0Ia3hU/d8\n\tSlBPaIFXJT972QXCGD64u+yQYX3M1b2f42IfRpCNEeDCboTdPPja2v6xIMKke9ifQmpp\n\tBxxJrvtjZzz7/3kf0p7w5ScQt4rP/9zP/OrV47YUoiEIvJu9egB7vZoze1h6yfDDTnc2\n\tZKxoPM7sLgaahNm/ixB7Hm8ri5zBfVsBArupv9QN8CJ6VLynU5BSppXvquXEdL80bgk/\n\tF+2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760696829; x=1761301629;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=/2QN7fWMQGXqIpyN9QKsxBjaJCwKW5I0LT90q69/hIo=;\n\tb=B2xZF3V71GFIIF7mSltnPkQ4X66mFEhGvoBoSO+G3gBOhtLtuTNCNBfad6CuX53xx4\n\tqTTgZ7gDf1IU3HjcjXm2CD1WQayNF75FPMSkRADezncMj3kiN4zF6/UoRcU5R5KOeCZ3\n\tJloDc5AKgh5z8AsdTY0YOnngnLiDaguWkD8aUjAknWeF/yIfBg/FogKmULU5An2yWekW\n\tJdNQ3l8w8PhCLzTPH2dcgExEUqU5rnOxIVTdOwti8UTEhcDF8z1GNFZUZCWBogdP11up\n\te9xNEqXvQnD6HoEbev4IiGzo2I4Kib74spKRU6c7L+IDjyQXUz3cZEX/qfFOsAPksUU9\n\t/ZUg==","X-Gm-Message-State":"AOJu0YyL1af2dOIVmalZC+rhYUuGD2fgK0HNopxflrKIMOyFln88IiZG\n\tIXkWyAj4rSWDqy3ZbRrAE5fO4wBCP27OFbyJ7zWp6eQk8vKj0lqUha4l68b/JeialnLiYKLBo1Z\n\tn68z4Jys=","X-Gm-Gg":"ASbGncvN3+/YAsArEVgD8nH91e84NDo/Vc72LG1TGgRfMr8KW/a3exLTiR+gUtJ8CDT\n\tlhtedf22nsQwyu5/Kc+5ZKDgRAjE/nqNJ8R3Ov1PNqu3QjaNjj58RPHubwXXWApq2V5gg6jRM6h\n\tlPHGXf4cxZpUhm5DEGAUIelOS2RQxl8mw/cGN/CPMUh4WcGwves5vx4hYWGlDP0573oRCqEjq57\n\tGazhAjeaELFpzm5ltR54o7W0SBe2pU0T3MlCSg6h+Vp3VckvfATYGJP2DMvn5eix6Hy1oM7+R0r\n\tpsrorR43rQ31Kjv7Vlf1HanswBfhTQu7SLqdGIal6K/eZpWJ6kzd4mpjpreDJEwtpMUY+amszIu\n\tbTiDd3n0bxzEv4BYCqQ+3rG6KnoS8nLSBJ2UC9kPmAPvQRdaF4iPBAKm81eKUwLmJP/qrXdeYF0\n\te1uAHBbVEzx5jJDSaBE9FvuMTUASGhzEmC/+QvsDJPwGXClSa4MqLVR31P25f54I5rqty1sQu4p\n\tWgQvjgCrD+M9cg=","X-Google-Smtp-Source":"AGHT+IFxLIgTn9cS09Wodb0g/3DTznwGYvtHMoRgIaXgKcXOwl71mJaiRWdjKofwZQ9aShP52NDyHQ==","X-Received":"by 2002:a05:6000:200f:b0:401:5ad1:682 with SMTP id\n\tffacd0b85a97d-42704d521e8mr2130346f8f.14.1760696828656; \n\tFri, 17 Oct 2025 03:27:08 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Cc":"David Plowman ","Subject":"[PATCH 1/5] ipa: rpi: Fix the set function for floating statistics\n\tregions","Date":"Fri, 17 Oct 2025 11:05:37 +0100","Message-ID":"<20251017102704.3887-2-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.47.3","In-Reply-To":"<20251017102704.3887-1-david.plowman@raspberrypi.com>","References":"<20251017102704.3887-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Previously it was calling the wrong internal function which would do\nnothing.\n\nSigned-off-by: David Plowman \n---\n src/ipa/rpi/controller/region_stats.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/controller/region_stats.h b/src/ipa/rpi/controller/region_stats.h\nindex c60f7d9a..0f8c276a 100644\n--- a/src/ipa/rpi/controller/region_stats.h\n+++ b/src/ipa/rpi/controller/region_stats.h\n@@ -76,7 +76,7 @@ public:\n \t{\n \t\tif (index >= numFloatingRegions())\n \t\t\treturn;\n-\t\tset(numRegions() + index, region);\n+\t\tset_(numRegions() + index, region);\n \t}\n \n \tconst Region &get(unsigned int index) const\n","prefixes":["1/5"]}