[{"id":36332,"web_url":"https://patchwork.libcamera.org/comment/36332/","msgid":"","date":"2025-10-17T07:55:15","subject":"Re: [PATCH v2] libcamera: request: Clarify ReuseBuffers flag usage\n\twith fences","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 16. 16:07 keltezéssel, Umang Jain írta:\n> Explicitly clarify the usage of Request::ReuseBuffers flag in context\n> of buffer fences. Fences are user-supplied and are not re-cycled as\n> part of Request::reuse(), hence document this behaviour explicitly.\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Kieran Bingham \n> ---\n> Changes in v2:\n> - Use \\note annotation suggested by Barnabás\n> \n> v1: https://patchwork.libcamera.org/patch/24070/\n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/request.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 26bba8f2..992d476e 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -327,6 +327,9 @@ void Request::Private::timeout()\n> * Don't reuse buffers\n> * \\var Request::ReuseBuffers\n> * Reuse the buffers that were previously added by addBuffer()\n> + *\n> + * \\note Fences associated with the buffers are not reused.\n> + * This flag should not be used if fences are used.\n> */\n> \n> /**\n> --\n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FFA5C3259\n\tfor ;\n\tFri, 17 Oct 2025 07:55:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51548606A0;\n\tFri, 17 Oct 2025 09:55:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE34760453\n\tfor ;\n\tFri, 17 Oct 2025 09:55:18 +0200 (CEST)","from [192.168.33.25] (185.182.214.105.nat.pool.zt.hu\n\t[185.182.214.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 045651118;\n\tFri, 17 Oct 2025 09:53:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z3heKMYd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760687618;\n\tbh=86MpLiUYJ03XoGQltctP5VnC/Pc0FXVOd9gYgoRNkx0=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Z3heKMYd19s3dc+2n0CHtmFvMbAa7g13iYXG6HkLrXmvqex390OtpJyZv0d38h4LT\n\tOTVrbNMOxAOAJYbjh3ebbv9WBLFFQtIWaIjbSVGM2F3uSk7TsgTdbFJdUYTee1rv7M\n\tpbfIbGAKeM1P+wRnMYo07vGg4iL7VLHYZVQAXYh8=","Message-ID":"","Date":"Fri, 17 Oct 2025 09:55:15 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] libcamera: request: Clarify ReuseBuffers flag usage\n\twith fences","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tKieran Bingham ","References":"\n\t<20251016140720.216006-1-uajain@igalia.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251016140720.216006-1-uajain@igalia.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]