[{"id":36328,"web_url":"https://patchwork.libcamera.org/comment/36328/","msgid":"<20251016183603.GE856714@ragnatech.se>","date":"2025-10-16T18:36:03","subject":"Re: [PATCH v3 3/4] ipa: meson.build: Remove duplicated variable","submitter":{"id":230,"url":"https://patchwork.libcamera.org/api/people/230/","name":"Niklas Söderlund","email":"niklas.soderlund+renesas@ragnatech.se"},"content":"Hello Jacopo,\n\nThanks for your patch.\n\nOn 2025-10-15 17:55:26 +0200, Jacopo Mondi wrote:\n> The 'ipa_names' variable is declared twice. Remove it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/ipa/meson.build | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 68f64b9a6fa39cceae291a9662bd6048d0e59422..eb7846e47888d4056b81e4a68f1903f134e6a662 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -24,8 +24,6 @@ subdir('libipa')\n> \n> ipa_sign = files('ipa-sign.sh')\n> \n> -ipa_names = []\n> -\n> ipa_modules = get_option('ipas')\n> \n> # Tests require the vimc IPA, similar to vimc pipline-handler for their\n> \n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF03FC3259\n\tfor ;\n\tThu, 16 Oct 2025 18:36:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5C1B6069A;\n\tThu, 16 Oct 2025 20:36:09 +0200 (CEST)","from fout-b8-smtp.messagingengine.com\n\t(fout-b8-smtp.messagingengine.com [202.12.124.151])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8F1C605D7\n\tfor ;\n\tThu, 16 Oct 2025 20:36:07 +0200 (CEST)","from phl-compute-10.internal (phl-compute-10.internal\n\t[10.202.2.50])\n\tby mailfout.stl.internal (Postfix) with ESMTP id 6C28C1D00091;\n\tThu, 16 Oct 2025 14:36:06 -0400 (EDT)","from phl-mailfrontend-02 ([10.202.2.163])\n\tby phl-compute-10.internal (MEProxy); Thu, 16 Oct 2025 14:36:06 -0400","by mail.messagingengine.com (Postfix) with ESMTPA; Thu,\n\t16 Oct 2025 14:36:05 -0400 (EDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech.se header.i=@ragnatech.se\n\theader.b=\"Lr94zjtk\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"H76M/CQc\"; \n\tdkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h=\n\tcc:cc:content-transfer-encoding:content-type:content-type:date\n\t:date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm1; t=1760639766;\n\tx=1760726166; bh=qNuY5wXrDCXcb8hl0A60/cqWkr5mj35CP8Z8rKq2qnA=; b=\n\tLr94zjtkMpjxYq+1a2mgMGBU+XdfTu7Ve035AYYiKUbyLzhM8z3U33JVDKNaUvrS\n\tx/YGolD2/sqiv6VQ8qxtdu5itCEGfRfo2DhjlAv/nnejxBnP/Mt4avvWfT81z+/o\n\tjdRSQDbIepSZfe0GLj4IIrcjdO+PwK2NnxKug3C9Dqo1jZp5+5Y5hD+Zmp1Oi6C3\n\tCzOIYW7NuDx9iKnrw47hyVyMQaqxDlbtwr0QXopggjt34I5WAS+R0K7tNghZpo2z\n\tuYFaGvfc6RG3byVrnoYvsgXyyunUskbc47z8jD9gjRHDubeW99bDPZsgHZSAJ6Tc\n\thRTQWo74qVFPierTWm2dRA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1760639766; x=\n\t1760726166; bh=qNuY5wXrDCXcb8hl0A60/cqWkr5mj35CP8Z8rKq2qnA=; b=H\n\t76M/CQcBvSxJda1ojJTFhWS7+Qd+looGT+OMmZ647wdcdUrLIjGyRq447dk5ciUE\n\tycGbA4tIueQIEZ2dWABAsytu1kshwye7W9+Eg1ymM63YmzbuClxgrCB+oIP8qquJ\n\trwEF3+5dUhaCQ/z2pRy6VRYWyN3/LCRneMotCM0EXrzFqbqKmfBed3xs3CEBVwin\n\tngrOOiHhzGjeo+gngEYApKfq5wRiGyBYRSkhbbSM22oq12PWSd5XQ+toZVnbgtGI\n\ttEFTQR06gGrCRYUnDYtgbES9gp5zoQjk1GuymnXkIURwE5VCLTqyVEKvetEPj5dU\n\tkOq8/cgDHN09hU4Lo7axA=="],"X-ME-Sender":"\n\t","X-ME-Received":"","X-ME-Proxy-Cause":"gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdduvdejtdefucetufdoteggodetrf\n\tdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n\trghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf\n\tgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefpihhklhgr\n\tshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhouggvrhhluhhnugdorhgvnhgvsh\n\tgrshesrhgrghhnrghtvggthhdrshgvqeenucggtffrrghtthgvrhhnpeefhfellefhffej\n\tgfefudfggeejlefhveehieekhfeulefgtdefueehffdtvdelieenucevlhhushhtvghruf\n\thiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshhouggvrhhl\n\tuhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrshgvpdhnsggprhgtphhtthhope\n\tegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjrggtohhpohdrmhhonhguihes\n\tihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtoheplhhisggtrghmvghrrgdqug\n\tgvvhgvlheslhhishhtshdrlhhisggtrghmvghrrgdrohhrghdprhgtphhtthhopehhrghn\n\tshhgsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmiigrmhgriigrlhesrhgvughhrg\n\thtrdgtohhm","X-ME-Proxy":"\n\t\n\t\n\t\n\t","Feedback-ID":"i80c9496c:Fastmail","Date":"Thu, 16 Oct 2025 20:36:03 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?=\n\t","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, Hans de Goede ,\n\tMilan Zamazal ","Subject":"Re: [PATCH v3 3/4] ipa: meson.build: Remove duplicated variable","Message-ID":"<20251016183603.GE856714@ragnatech.se>","References":"<20251015-ipa-match-by-name-v3-0-11f9c774c7fc@ideasonboard.com>\n\t<20251015-ipa-match-by-name-v3-3-11f9c774c7fc@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20251015-ipa-match-by-name-v3-3-11f9c774c7fc@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36331,"web_url":"https://patchwork.libcamera.org/comment/36331/","msgid":"<660ea837-f041-4b00-9478-b4c695c8fb81@protonmail.com>","date":"2025-10-17T07:36:39","subject":"Re: [PATCH v3 3/4] ipa: meson.build: Remove duplicated variable","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2025. 10. 15. 17:55 keltezéssel, Jacopo Mondi írta:\n> The 'ipa_names' variable is declared twice. Remove it.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/meson.build | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 68f64b9a6fa39cceae291a9662bd6048d0e59422..eb7846e47888d4056b81e4a68f1903f134e6a662 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -24,8 +24,6 @@ subdir('libipa')\n> \n> ipa_sign = files('ipa-sign.sh')\n> \n> -ipa_names = []\n> -\n> ipa_modules = get_option('ipas')\n> \n> # Tests require the vimc IPA, similar to vimc pipline-handler for their\n> \n> --\n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D6DEBE080\n\tfor ;\n\tFri, 17 Oct 2025 07:36:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 679FD60697;\n\tFri, 17 Oct 2025 09:36:45 +0200 (CEST)","from mail-10630.protonmail.ch (mail-10630.protonmail.ch\n\t[79.135.106.30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C856C60453\n\tfor ;\n\tFri, 17 Oct 2025 09:36:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"LPeK55VA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1760686602; x=1760945802;\n\tbh=EgW64s17L/UQTltUSU62Xm9iQmCzrsxrzE+H31msWJ4=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=LPeK55VADnfvLfFsR0bKmDjXY0DnunTvPt+D2SznmmBjCAmamUlPtl8FgCThT7v8P\n\tn1UTd7jRHP5a/pEzReCpVng3j4ezbc6Sa2bKChHslf2qwGu3stxu2xs4Ji+JWUaiHV\n\tFYlek+w3QMQuPlQ6cFCYeppbW1eE15EfuIv3mWt9i+tUUKj1YwzL4lr/ukMqyZHLX/\n\trShteLdaePMJDbEkMQi8QblYx2gBJg0XoQleeSxDmAk3Df9eikrlwRar/RzUFT+C/W\n\tL453bRhevz/i02XP0FGKONZHJUK191yaygaIgGpI2zTW5OyzMRN215ibjnFAC/c7Ei\n\tdINrR6nOn1xkQ==","Date":"Fri, 17 Oct 2025 07:36:39 +0000","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t, Hans de Goede\n\t, Milan Zamazal ","From":"=?utf-8?q?P=C5=91cze_Barnab=C3=A1s?= ","Subject":"Re: [PATCH v3 3/4] ipa: meson.build: Remove duplicated variable","Message-ID":"<660ea837-f041-4b00-9478-b4c695c8fb81@protonmail.com>","In-Reply-To":"<20251015-ipa-match-by-name-v3-3-11f9c774c7fc@ideasonboard.com>","References":"<20251015-ipa-match-by-name-v3-0-11f9c774c7fc@ideasonboard.com>\n\t<20251015-ipa-match-by-name-v3-3-11f9c774c7fc@ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"8a2b3a56beab10e52a83082532fce8b1ab33bdfe","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]