[{"id":36287,"web_url":"https://patchwork.libcamera.org/comment/36287/","msgid":"<176057123641.635357.2529143304865970356@ping.linuxembedded.co.uk>","date":"2025-10-15T23:33:56","subject":"Re: [PATCH v3 38/39] libcamera: software_isp: Switch on uncalibrated\n\tCCM to validate eGLDebayer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-10-15 02:22:50)\n> As a validation step switch on uncalibrated CCM.\n> \n> Signed-off-by: Bryan O'Donoghue \n\nI think we've discussed that this one would get dropped and GPU ISP will\nalways default to an identity matrix for CCM.\n\n> ---\n> src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\n> index 5508e668..8b6df9af 100644\n> --- a/src/ipa/simple/data/uncalibrated.yaml\n> +++ b/src/ipa/simple/data/uncalibrated.yaml\n> @@ -8,12 +8,12 @@ algorithms:\n> # Color correction matrices can be defined here. The CCM algorithm\n> # has a significant performance impact, and should only be enabled\n> # if tuned.\n> - # - Ccm:\n> - # ccms:\n> - # - ct: 6500\n> - # ccm: [ 1, 0, 0,\n> - # 0, 1, 0,\n> - # 0, 0, 1]\n> + - Ccm:\n> + ccms:\n> + - ct: 6500\n> + ccm: [ 1, 0, 0,\n> + 0, 1, 0,\n> + 0, 0, 1]\n> - Lut:\n> - Agc:\n> ...\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10602C3259\n\tfor ;\n\tWed, 15 Oct 2025 23:34:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBEAF60651;\n\tThu, 16 Oct 2025 01:34:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7971360643\n\tfor ;\n\tThu, 16 Oct 2025 01:33:59 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 196D31306;\n\tThu, 16 Oct 2025 01:32:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HwqoZvNa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760571140;\n\tbh=wQ3ZG59J4I8J0/c7U/jBgMON+1X96Gark/4V/GLao1I=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=HwqoZvNaGknUzAGvOtJ0iJBoS1gtxri5L7DnqjBJiujsOviJsqO1Cm2jcQjzvRoLm\n\tHFPkGIc2T9N4Lh2sqS5v7FJLwv8YfD43KqjIUrLVKLeyYbHLGH3mvOgI2tj7OAnl82\n\tipu3jOeeoSM3If/F6dBdQFM6TdDHzAxGL+yxg0ss=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251015012251.17508-39-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-39-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v3 38/39] libcamera: software_isp: Switch on uncalibrated\n\tCCM to validate eGLDebayer","From":"Kieran Bingham ","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 16 Oct 2025 00:33:56 +0100","Message-ID":"<176057123641.635357.2529143304865970356@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36326,"web_url":"https://patchwork.libcamera.org/comment/36326/","msgid":"<85qzv2aing.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-10-16T16:57:55","subject":"Re: [PATCH v3 38/39] libcamera: software_isp: Switch on\n\tuncalibrated CCM to validate eGLDebayer","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> As a validation step switch on uncalibrated CCM.\n\nWith this, I can reproduce the problem with darker output, as discussed\nyesterday at the sync. I'll look at it.\n\nI'm done with reviewing the v3 for now.\n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/ipa/simple/data/uncalibrated.yaml | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\n> index 5508e668..8b6df9af 100644\n> --- a/src/ipa/simple/data/uncalibrated.yaml\n> +++ b/src/ipa/simple/data/uncalibrated.yaml\n> @@ -8,12 +8,12 @@ algorithms:\n> # Color correction matrices can be defined here. The CCM algorithm\n> # has a significant performance impact, and should only be enabled\n> # if tuned.\n> - # - Ccm:\n> - # ccms:\n> - # - ct: 6500\n> - # ccm: [ 1, 0, 0,\n> - # 0, 1, 0,\n> - # 0, 0, 1]\n> + - Ccm:\n> + ccms:\n> + - ct: 6500\n> + ccm: [ 1, 0, 0,\n> + 0, 1, 0,\n> + 0, 0, 1]\n> - Lut:\n> - Agc:\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DF8DC3259\n\tfor ;\n\tThu, 16 Oct 2025 16:58:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 748DC60693;\n\tThu, 16 Oct 2025 18:58:02 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C3F16068C\n\tfor ;\n\tThu, 16 Oct 2025 18:58:01 +0200 (CEST)","from mail-ej1-f72.google.com (mail-ej1-f72.google.com\n\t[209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-428-XGUHN98yPEKSmk8KRkZ9bg-1; Thu, 16 Oct 2025 12:57:59 -0400","by mail-ej1-f72.google.com with SMTP id\n\ta640c23a62f3a-b4544f46392so122926466b.0\n\tfor ;\n\tThu, 16 Oct 2025 09:57:58 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd3a467bsm562255066b.71.2025.10.16.09.57.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Oct 2025 09:57:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"UWVLklAG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1760633880;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Qs5JbCOF9bENKZEoJ6oYLlGJg+ecxgR0Er13ZRyQat4=;\n\tb=UWVLklAGU1ir6wMiMEVhFt2ZXNP4FBUIqutAFlBFnreyi9abndN+AHBOc60l2XnQQBbKlR\n\tAsw9CUcgnMXgl0JHOoyunRpbOsp9HhIFgi1vm3xR4L2gH/RpFQfVzZoXx2OwU7cP9AMbDa\n\tH4LQwjWLYIntpvK4dT0aRhKsUB6UTd8=","X-MC-Unique":"XGUHN98yPEKSmk8KRkZ9bg-1","X-Mimecast-MFC-AGG-ID":"XGUHN98yPEKSmk8KRkZ9bg_1760633878","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760633877; x=1761238677;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Qs5JbCOF9bENKZEoJ6oYLlGJg+ecxgR0Er13ZRyQat4=;\n\tb=xVZyl7Un4zvCRJzuGVFHyfgRn0tM2vMfs44i90bpHgIpp0OsoiWBuXLT2S52e6ha1K\n\tdQ9Y8XAjajQNVOYDlUOT3Zxvll2FSWiovnW6U2TfkNFGGB54L8UWli7jyBi7HL4wFv3J\n\tFLzp2SF35lUerqMgeBziLNhNKDNUkI7BAyzmQKZhM1SfRYFCTGaNUd7JdM4XpIH1Vpj+\n\tNBNWRBH4wtNZ+0cOGdBMImZIGFwUkr98NVYi0cybfybASy9QxKr7tRgFtXNe+hRC0nN6\n\tw1QYX0ZzKgomEQrUWzO9U1su4lMZQ8v8jkQEpm+LWj+YUUPBg3KuyvAY9LCQA7sKrLfc\n\tyhbw==","X-Gm-Message-State":"AOJu0YylnKWhOidFmBuVqjzfaRebiFOmBMist6ZBizs0R13jUFyuIuaf\n\tFVBOX2s5JWIDq864s6VE1zTIG3PG4cVNmFRzZc+Fe0qC4jmWdNP0wSdq7xokz96TkTM7lwhpR9A\n\t5JMkLzHy2r78sU9XeBJ/qepT1TM41a990w40wy2ureCl8S1TztR0G3510Hs4sKlBUGj+BVIsgRH\n\tAgK6sxNtk=","X-Gm-Gg":"ASbGncvUtn7XZ/8k00U2hAvGI3Go7e6xH+iNsAXKS4YjWSeEmA7wnso0LMFcQFf/aG6\n\tR71ukpVJPLEu3Wujpu7/7nurvdD657gCVF3S28t1pyHybHPhW+zAIjhIqRyVhj0X66X2nndqWKZ\n\tWe9/MSCBsKg4bT7DFdNSnQw5aJ9YErpA1ZqH6tbfGN3G7vKDNfORputOjyHFkRB/l4C+95CiCPq\n\tbKkTOBQoOERP51v/kpR4ECVKRMJbbWfzoTCmszpRG+DbKmTuYcbaiEJYYH/kINEIAf1oYFP57jz\n\tBytlqdAB+6zldqY9tCtNobXgrIeB2ze1VgDZU4wcnfI0uG5hUNUElX9Cc88ZPJFLbf+lTHb/+6L\n\tCPnY+jQ1z6qHd0n4dcCw/MzsF493mUFcYLxeN6uXCWhwzCLetqqFJ","X-Received":["by 2002:a17:907:971e:b0:b45:60ad:daf1 with SMTP id\n\ta640c23a62f3a-b6473244100mr75195466b.22.1760633877343; \n\tThu, 16 Oct 2025 09:57:57 -0700 (PDT)","by 2002:a17:907:971e:b0:b45:60ad:daf1 with SMTP id\n\ta640c23a62f3a-b6473244100mr75193866b.22.1760633876976; \n\tThu, 16 Oct 2025 09:57:56 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEqsVuu0b1zHqm5CgSG66ZP9iOPaUbYLeMu7z8+nFwWbyZF8NCLj8qCki23mc/W/EKbwkSTkw==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, hdegoede@redhat.com,\n\tbod.linux@nxsw.ie","Subject":"Re: [PATCH v3 38/39] libcamera: software_isp: Switch on\n\tuncalibrated CCM to validate eGLDebayer","In-Reply-To":"<20251015012251.17508-39-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 15 Oct 2025 02:22:50 +0100\")","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-39-bryan.odonoghue@linaro.org>","Date":"Thu, 16 Oct 2025 18:57:55 +0200","Message-ID":"<85qzv2aing.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"6igCiGgywLlDRBQmFPz7X57T9e3XCK7pYj4rIKDhXxI_1760633878","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]