[{"id":36288,"web_url":"https://patchwork.libcamera.org/comment/36288/","msgid":"<176057131901.635357.7854138406808544226@ping.linuxembedded.co.uk>","date":"2025-10-15T23:35:19","subject":"Re: [PATCH v3 36/39] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-10-15 02:22:48)\n> Make getInputConfig and getOutputConfig static so as to allow for\n> interrogation of the supported pixel formats prior to object instantiation.\n> Do this so as to allow the higher level logic make an informed choice\n> between CPU and GPU ISP based on which pixel formats are supported.\n> \n> Curretnly CPU ISP supports more diverse input and output schemes.\n\nCurrently\n\nWhy is this only _cpu and not the gpu ... perhaps I guess that gets\nadded as static directly ?\n\nSo \n\nAcked-by: Kieran Bingham \n\n> \n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> index 3cc07028..3bf34ac3 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.h\n> +++ b/src/libcamera/software_isp/debayer_cpu.h\n> @@ -104,8 +104,8 @@ private:\n> template\n> void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n> \n> - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> int setupStandardBayerOrder(BayerFormat::Order order);\n> int setDebayerFunctions(PixelFormat inputFormat,\n> PixelFormat outputFormat,\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAE75C3259\n\tfor ;\n\tWed, 15 Oct 2025 23:35:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96B9260660;\n\tThu, 16 Oct 2025 01:35:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DBF460643\n\tfor ;\n\tThu, 16 Oct 2025 01:35:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AEED71306;\n\tThu, 16 Oct 2025 01:33:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y8WZ3fcv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760571222;\n\tbh=SUHW3+DPqhxOzN7PFUO0lHx9gAiao1BbRi52RPY7xfE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Y8WZ3fcva3rgKodoLvkSdbmf+B/aDhxXzXkEZVsJVXktTUccytA28KR2syfSD/fE7\n\tkHa41lJd+B+nRDv4oOKCGZbf+p012Wh2f+1UeTA6NdYniWUQ0dY/D6X9MHiW5WAfF2\n\tkKOAf4UgRJGkqIEmQyZg4b2PSXz5PvG56czOOlJM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251015012251.17508-37-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-37-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v3 36/39] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","From":"Kieran Bingham ","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 16 Oct 2025 00:35:19 +0100","Message-ID":"<176057131901.635357.7854138406808544226@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36289,"web_url":"https://patchwork.libcamera.org/comment/36289/","msgid":"<176057139155.635357.10579792279286750728@ping.linuxembedded.co.uk>","date":"2025-10-15T23:36:31","subject":"Re: [PATCH v3 36/39] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2025-10-16 00:35:19)\n> Quoting Bryan O'Donoghue (2025-10-15 02:22:48)\n> > Make getInputConfig and getOutputConfig static so as to allow for\n> > interrogation of the supported pixel formats prior to object instantiation.\n> > Do this so as to allow the higher level logic make an informed choice\n> > between CPU and GPU ISP based on which pixel formats are supported.\n> > \n> > Curretnly CPU ISP supports more diverse input and output schemes.\n> \n> Currently\n> \n> Why is this only _cpu and not the gpu ... perhaps I guess that gets\n> added as static directly ?\n\nHrm ... I don't understand how this is so late in the series too. Is it\nout of order breaking bisection? or is it not used /needed ?\n\n> \n> So \n> \n> Acked-by: Kieran Bingham \n> \n> > \n> > Signed-off-by: Bryan O'Donoghue \n> > ---\n> > src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> > index 3cc07028..3bf34ac3 100644\n> > --- a/src/libcamera/software_isp/debayer_cpu.h\n> > +++ b/src/libcamera/software_isp/debayer_cpu.h\n> > @@ -104,8 +104,8 @@ private:\n> > template\n> > void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n> > \n> > - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> > - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> > + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> > + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> > int setupStandardBayerOrder(BayerFormat::Order order);\n> > int setDebayerFunctions(PixelFormat inputFormat,\n> > PixelFormat outputFormat,\n> > -- \n> > 2.51.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4DCBBE080\n\tfor ;\n\tWed, 15 Oct 2025 23:36:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5419B605F3;\n\tThu, 16 Oct 2025 01:36:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7956B605F3\n\tfor ;\n\tThu, 16 Oct 2025 01:36:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1DF1E1306;\n\tThu, 16 Oct 2025 01:34:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AB+qpcU8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760571295;\n\tbh=rzKJBsbReLHOZkNI8HiiXgpKeOFz5dnBZWGcWRn+/Do=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=AB+qpcU8ngVUkIJtTzhbF64dY+rxeQ71XElEF4gRHqJouMQhBb7zY1y+v7hT+Ia3i\n\tG6Jxvgas14+4sgxUWHow5QkvtWvxIo4A7MlO4t/+oIIWFr5ZySQHlvqgfQt79nSw3h\n\tGR6jYit1WFgXQ7xHbrewVA1U1sOm/CVaxNx+EyyU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<176057131901.635357.7854138406808544226@ping.linuxembedded.co.uk>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-37-bryan.odonoghue@linaro.org>\n\t<176057131901.635357.7854138406808544226@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v3 36/39] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","From":"Kieran Bingham ","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 16 Oct 2025 00:36:31 +0100","Message-ID":"<176057139155.635357.10579792279286750728@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36308,"web_url":"https://patchwork.libcamera.org/comment/36308/","msgid":"","date":"2025-10-16T09:47:00","subject":"Re: [PATCH v3 36/39] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 16/10/2025 00:36, Kieran Bingham wrote:\n>> Currently\n>>\n>> Why is this only _cpu and not the gpu ... perhaps I guess that gets\n>> added as static directly ?\n> Hrm ... I don't understand how this is so late in the series too. Is it\n> out of order breaking bisection? or is it not used /needed ?\n\nBecause I was rebasing at 2:20 am :)\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4214FBE080\n\tfor ;\n\tThu, 16 Oct 2025 09:47:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4673F6066F;\n\tThu, 16 Oct 2025 11:47:04 +0200 (CEST)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91FF3600CC\n\tfor ;\n\tThu, 16 Oct 2025 11:47:02 +0200 (CEST)","by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-4710022571cso3900715e9.3\n\tfor ;\n\tThu, 16 Oct 2025 02:47:02 -0700 (PDT)","from [192.168.0.19] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4710e7050c6sm17308665e9.1.2025.10.16.02.47.01\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 16 Oct 2025 02:47:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Sm+Z9B2X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760608022; x=1761212822;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=TJvpPWHMbfnHMaIb8XseswTO8ERscONRzEa/njqXMg4=;\n\tb=Sm+Z9B2XbXj17JQjtso9T/ZElzI0P/aszx+3IvDGkJ2I36P/ZDgjSnXsA6EDFGZImO\n\tUDkTIpyQeyKNsFWeCmz6CnAGZcOEcna0XCVhaBevi39PRnZ8cTxDsBxYIG/st18PO4O7\n\tA6NP0HKMrj0lfvPAkhnlAZ3EAD7AF/8e3M2zs2cRTRcQsltOE1Kl87zII7JXpYIGiDds\n\tLvEuf/KtUMCqrd8j1saDPOEMYKUpcunfCEdUOHiHrx/y4hVvYuyTsiEBFq7WNINWIGp6\n\tVaREO6PODcF45Vl+qXgwxruWX0gHSJ5Bf0Z3fR14ot7HA2X0/ms4G8/H7DQ/nSqspDhj\n\tVJXw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760608022; x=1761212822;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=TJvpPWHMbfnHMaIb8XseswTO8ERscONRzEa/njqXMg4=;\n\tb=PAIXeocJsFt+wRThipzkxiIQdZYeWmOvgaGJ6YCgs6t+EldDd5TfsRgXHek0Vwnqvq\n\tbKnaJOtgc5I5wC4wXSubZTDdjtm08s2R7T+qkNHevya7uGTpgh2BpN9Z+NhnaGug1IdK\n\t1K2OUZYFy/cnjph5pv1+QoFQ3vQ+O5zTxAxSBlhKLWs34K4LOglQV2A4vdFA881pxrkx\n\tSJZ5EYHwcRhoFzasoBZCnpKXqNqBJR//tTXEv+55gOId0ZuF5/tduGeexRdRVFqV2vhr\n\tr/AvfilCtQUmRMx5lAVgeX9j99SuFPPFme4k8anNmf6Bj1I57tGBP85zV0I21v0dVCwl\n\tYDOQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUuP5wglmXo63q1a40OM2uVNMPO5nkvkPHRkGieRv1mdKtosNKB3pcxaoPofZd7l3jT9KaOEYxUC6MzkZ7cLiU=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxweVYj1P8QaAH32gKk85WOQgACB4W53rQMpA4t3qeJU0p8ERAL\n\tAILA3L9NntGrI1jn2ompWkKH7SNGN7A4SJHNzN3e3sAKKAXWcDVrmqLdT7W7Y8gEtCA=","X-Gm-Gg":"ASbGncsXyVLEflobFIo8mJDfW4sMsH8hmj0CJGhR60CkkCg42PJsKtvN/iQRwYszTcT\n\tSe30HNbWyd9BvQLgYYbx1FUQHKJAsG4it9PPSQy2qiPytTo4RPPS5JFrmBZ4xbDPs+AIrLyWL6B\n\to6HydIOG5PFBj+bVndRA2Wn8D5JCf3y/ffk2i/cOY/y2+i/lx/MZ+Olxx1U11nVQLmuVx9ueHu4\n\tvMbb4hBws5IHWBpSZ9YoDYnQsACR1++E0ABG+O0B4QTpWkuncovR34vWNb5xlOy2r4Z3k3MQvAW\n\t8Q6zavttl0E2+fc6Dwcyd7BwVKvk6s6uFfJ8FDKcdFdjhTW0vZF2wKINdSGHhwprEqv66dUgsM3\n\tvIGDqK8Ur3qa2jthyRHBI+yP3gm6mmmwVWJ9aIQaq4KS0uNGZ259UxKT5iI9Jze2oaVLy8YsQG9\n\tWFiqS4LH6GUIdpcm/HPesExXhMUWDlmaIQZVOjy5LwmEkeAg==","X-Google-Smtp-Source":"AGHT+IE9dAoJO9JiTRhJUVQSgvXWQnw11tnvWZHgSSb10526VEZ0/YdzJZqO+LUnp9ovgeiUW48+1w==","X-Received":"by 2002:a05:600c:81ca:b0:471:989:9d7b with SMTP id\n\t5b1f17b1804b1-4710989a09amr23163835e9.21.1760608021904; \n\tThu, 16 Oct 2025 02:47:01 -0700 (PDT)","Message-ID":"","Date":"Thu, 16 Oct 2025 10:47:00 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 36/39] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bod.linux@nxsw.ie","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-37-bryan.odonoghue@linaro.org>\n\t<176057131901.635357.7854138406808544226@ping.linuxembedded.co.uk>\n\t<176057139155.635357.10579792279286750728@ping.linuxembedded.co.uk>","From":"Bryan O'Donoghue ","Content-Language":"en-US","In-Reply-To":"<176057139155.635357.10579792279286750728@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]