{"id":24681,"url":"https://patchwork.libcamera.org/api/patches/24681/?format=json","web_url":"https://patchwork.libcamera.org/patch/24681/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251015012251.17508-37-bryan.odonoghue@linaro.org>","date":"2025-10-15T01:22:48","name":"[v3,36/39] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4332d9c2287e66c06675e1d2dd88742998b215e1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24681/mbox/","series":[{"id":5503,"url":"https://patchwork.libcamera.org/api/series/5503/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5503","date":"2025-10-15T01:22:12","name":"Add GLES 2.0 GPUISP to libcamera","version":3,"mbox":"https://patchwork.libcamera.org/series/5503/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24681/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24681/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24D78C3335\n\tfor ;\n\tWed, 15 Oct 2025 01:23:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC0EB60674;\n\tWed, 15 Oct 2025 03:23:46 +0200 (CEST)","from mail-ej1-x631.google.com (mail-ej1-x631.google.com\n\t[IPv6:2a00:1450:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 377036065E\n\tfor ;\n\tWed, 15 Oct 2025 03:23:32 +0200 (CEST)","by mail-ej1-x631.google.com with SMTP id\n\ta640c23a62f3a-b40f11a1027so1073948866b.2\n\tfor ;\n\tTue, 14 Oct 2025 18:23:32 -0700 (PDT)","from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"fkqad5xC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491411; x=1761096211;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=SHxYNwZ2SuJenQQzjJu+qFVpF7ezbdEtz2sX66kqCZc=;\n\tb=fkqad5xC8m+Cl2ByzVYRa6PIbQZLhrTukdY5h9v4BoqHfnH350X1w4UBpTuShzFDkZ\n\t38xwxP897ww71ANLXI40slyMUl5e14dcJD8pub0pWzHcEJaO77T7rHI0ZRQlPb14DaRY\n\t1s6Pot6fEtc/HoJjwop5EV8Hj7H2hW6Y/zGG0Xc9jpMo2Sxi9SseGeI7dW3IYo6Yve1A\n\tdsrwLLib7/TNRkm840HJjQSisWT8q5+j0duR7irZ41R7ignSp0/NB6vdbzAjA6O6G0xx\n\t163Ykc6SkLQhHoJh1ZHXZJPZlb9CLPq/9XZ6pCKMthArMGFqMb5wjRbW+FjnSlRYbZHG\n\tQgtA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491411; x=1761096211;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=SHxYNwZ2SuJenQQzjJu+qFVpF7ezbdEtz2sX66kqCZc=;\n\tb=jL/f7bpHnyVqkrVX5QwznheLooH/4utdaRfxxHl6IHwIw125t0RdG8fTYwu3aj7L5E\n\tc62IEwT5HtRTo2g4sdBtNXYIHjUdQ+2IlJxGBjF2cTOC7VuzkmUi/39Ugaoo1jp4wLJm\n\tGgbDaRw9buIJPICsgI9w2gkKXvzdJd4sDoeWwqz4Rhot9FDPdxQ2sc5VCrw3l2pQzI2X\n\tmcGaKRmtCviHUrDNywVHZij/uhG/TU2IWfj4ueOROVh5VUHKc9I5BqI9RWw488GPV2Y5\n\tksw4siY4CzM/kiSF1dfdo1S8s8Q54XlnEoTjzHZI0cGDUyd/DAFrUYA7n00T9L8kJctA\n\tVp9Q==","X-Gm-Message-State":"AOJu0YxaIIOoysZSKnFZAjg7/wE00I9786tluCrAYVf7Uf3UbFlxGGCi\n\tRCQYIB8ypTWQgn9o4bQPvw1t9N/4w1YDX0Aja07TCJlgmSJViNZxl8GY6vCTHlh7+jhzvjqt3eb\n\tcxzcS","X-Gm-Gg":"ASbGncsvBhMeTWPBus9fQS09WwM5dpwAY2WbzpMCVBZ4b2C2lwKDW6EPOM5ZonCp2gI\n\tNv79YXHLfkRe6ykPsoXYZ+FtGFH+5P/iKdy1Npx6DE2Cjy0H8D9FrmzBIpgNZEZODqlX7Z9pkat\n\tdUn3dXSCGHy8x1G6MCHe6RwBOiynTRteHZu0pZBQmRF+PHzEmpMknPaYCjw9bDWHPgrOp8bdQdq\n\tNRCIJgHz7yaCcIdkE6ef0qNeVHV+QqXY6113lmmCi1WfPEYup666unqoUVkeNWpI8G1p38RS8M8\n\tTsxPJp35KcHbCA/D7wUaRk61CqH0H+YJU8607ZLSb2tM1tp0I7hhHUPQUbfQ9BEUTvd+Y1QLkwj\n\tcXFETJ0qk59QAOvf8SXNYBQXVYqkdr0ZVXTDInvU4kYb9Bsc0fSVcdApL7Mou6gg+BE0bea7y39\n\tuObCoE7pW+ZMdnIrox8IImc2CbFmaEqA==","X-Google-Smtp-Source":"AGHT+IGJfmhdfQEhgLU1OY5TEEzCtyvhMs2+JGdJAc+VfqH52sUXeBqZIsBWkphcNFd+oLtGs2mIdQ==","X-Received":"by 2002:a17:906:c149:b0:b45:60ad:daf1 with SMTP id\n\ta640c23a62f3a-b50aa8a92e3mr2597436466b.22.1760491411537; \n\tTue, 14 Oct 2025 18:23:31 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","Subject":"[PATCH v3 36/39] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","Date":"Wed, 15 Oct 2025 02:22:48 +0100","Message-ID":"<20251015012251.17508-37-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make getInputConfig and getOutputConfig static so as to allow for\ninterrogation of the supported pixel formats prior to object instantiation.\nDo this so as to allow the higher level logic make an informed choice\nbetween CPU and GPU ISP based on which pixel formats are supported.\n\nCurretnly CPU ISP supports more diverse input and output schemes.\n\nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex 3cc07028..3bf34ac3 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -104,8 +104,8 @@ private:\n \ttemplate\n \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n \n-\tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n-\tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n+\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n+\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint setupStandardBayerOrder(BayerFormat::Order order);\n \tint setDebayerFunctions(PixelFormat inputFormat,\n \t\t\t\tPixelFormat outputFormat,\n","prefixes":["v3","36/39"]}