[{"id":36302,"web_url":"https://patchwork.libcamera.org/comment/36302/","msgid":"<2651920e-2fff-440b-adab-105d40d27526@collabora.com>","date":"2025-10-16T09:06:43","subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"While I love to see this, I think we should have at least one release \nwith the swisp staying the default in order to avoid fallout - in \nparticular:\n\n 1. There is no Pipewire release with the necessary sandbox change yet\n (in a month or two we could have 1.6 and 1.4.10)\n 2. With the current series I observe at least one crash specific to the\n gpuisp (hitting the assert in eGL::cleanUp(void)) and I assume it\n won't be the only one when getting more testing, even if I manage to\n debug this in the next couple of days.\n\nBeing able to work those out without getting issues from users or having \nto carry downstream patches would be nice :)\n\nOn 10/15/25 03:22, Bryan O'Donoghue wrote:\n> In some cases the GPU can deliver 15x performance in Debayer with the\n> CCM on, reference hardware Qualcomm RB5 with IMX512 sensor.\n>\n> Given this large performance difference it makes sense to make GPUISP\n> the default for the Software ISP.\n>\n> If LIBCAMERA_SOFTISP_MODE is omitted gpu will be the default. If\n> libcamera is compiled without gpuisp support, CPU Debayer will be used.\n>\n> It is still possible to select CPU mode with LIBCAMERA_SOFISP_MODE=cpu.\n>\n> Signed-off-by: Bryan O'Donoghue\n> ---\n> src/libcamera/software_isp/software_isp.cpp | 11 +++++++++--\n> 1 file changed, 9 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index 869f7320..1b4a29fd 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -120,10 +120,17 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n> \t}\n> \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n> \n> -#if HAVE_DEBAYER_EGL\n> \tconst char *softISPMode = utils::secure_getenv(\"LIBCAMERA_SOFTISP_MODE\");\n> +\tif (softISPMode) {\n> +\t\tif (strcmp(softISPMode, \"gpu\") && strcmp(softISPMode, \"cpu\")) {\n> +\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode << \" invalid. \"\n> +\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n> +\t\t\treturn;\n> +\t\t}\n> +\t}\n> \n> -\tif (softISPMode && !strcmp(softISPMode, \"gpu\"))\n> +#if HAVE_DEBAYER_EGL\n> +\tif (!softISPMode || !strcmp(softISPMode, \"gpu\"))\n> \t\tdebayer_ = std::make_unique(std::move(stats), configuration);\n> #endif\n> \tif (!debayer_)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B28A6BE080\n\tfor ;\n\tThu, 16 Oct 2025 09:06:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6323860669;\n\tThu, 16 Oct 2025 11:06:58 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2D8F600CC\n\tfor ;\n\tThu, 16 Oct 2025 11:06:55 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1760605608286918.8943955640017;\n\tThu, 16 Oct 2025 02:06:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"cJLRM11L\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1760605612; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=S87q1/9xQ3cKMeilcb7VRmyzQCKvWpZrUB2tW41EHfAP2b8k47FVYRHjviZzAP0bOAsw8f7NZ6wg35yxCH5Tb1EZ5vCQ7WSh1ELoOsQq+KK3lN7IxQ50ZRtidWQtLvrWAUMg1nkyD4tnpHJw1mDOjrp3sYQg/lfupxiB0LTeOlM=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760605612;\n\th=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=tcRxmCP1J04zBQKdrTHN0+hER4rnpKXd1NpaZpaetVE=; \n\tb=hOhsuDuZvn6ZCG35xNLRvYt5tUB8azZaMlGCO7re5iJmBL7JDSNikO2Nk2XnYduj9y/X9Kt5nxlWdfI7WXjCMF8bFfDO1I7QRwC1AsdguF9pawbqCN6Ioj1S9WygY5K9NGVsYQr/gkm4HPDjx+lAJjct5E1H2HuLLYsRgho1yLo=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760605612;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Message-Id:Reply-To:Cc;\n\tbh=tcRxmCP1J04zBQKdrTHN0+hER4rnpKXd1NpaZpaetVE=;\n\tb=cJLRM11L5sIWMzL+TpNTHSOFcrzcQxgn2MNq1mDYWYwLyhYu0gyIx8O44K9T89HF\n\t2+rBO2wKEPvtzvMz76WECvcJNOl8frZhpUp0PwL+oIxql9hBTXlhQLaURoVad2Ussbr\n\tvP4yol8fqY1QXcq838vlVk7IwLqpRXHUIUMSehW8=","Content-Type":"multipart/alternative;\n\tboundary=\"------------Il0tN666TxNzFaDXxu6VZU1V\"","Message-ID":"<2651920e-2fff-440b-adab-105d40d27526@collabora.com>","Date":"Thu, 16 Oct 2025 11:06:43 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","To":"libcamera-devel@lists.libcamera.org","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-36-bryan.odonoghue@linaro.org>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20251015012251.17508-36-bryan.odonoghue@linaro.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36306,"web_url":"https://patchwork.libcamera.org/comment/36306/","msgid":"","date":"2025-10-16T09:21:15","subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 10/16/25 11:06, Robert Mader wrote:\n>\n> While I love to see this, I think we should have at least one release \n> with the swisp staying the default in order to avoid fallout - in \n> particular:\n>\n> 1. There is no Pipewire release with the necessary sandbox change yet\n> (in a month or two we could have 1.6 and 1.4.10)\n>\nSorry, correction: looks like the patch *did* already get backported \nalready in 1.4.8. so this shouldn't be an issue.\n>\n> 1. With the current series I observe at least one crash specific to\n> the gpuisp (hitting the assert in eGL::cleanUp(void)) and I assume\n> it won't be the only one when getting more testing, even if I\n> manage to debug this in the next couple of days.\n>\n> Being able to work those out without getting issues from users or \n> having to carry downstream patches would be nice :)\n>\n> On 10/15/25 03:22, Bryan O'Donoghue wrote:\n>> In some cases the GPU can deliver 15x performance in Debayer with the\n>> CCM on, reference hardware Qualcomm RB5 with IMX512 sensor.\n>>\n>> Given this large performance difference it makes sense to make GPUISP\n>> the default for the Software ISP.\n>>\n>> If LIBCAMERA_SOFTISP_MODE is omitted gpu will be the default. If\n>> libcamera is compiled without gpuisp support, CPU Debayer will be used.\n>>\n>> It is still possible to select CPU mode with LIBCAMERA_SOFISP_MODE=cpu.\n>>\n>> Signed-off-by: Bryan O'Donoghue\n>> ---\n>> src/libcamera/software_isp/software_isp.cpp | 11 +++++++++--\n>> 1 file changed, 9 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n>> index 869f7320..1b4a29fd 100644\n>> --- a/src/libcamera/software_isp/software_isp.cpp\n>> +++ b/src/libcamera/software_isp/software_isp.cpp\n>> @@ -120,10 +120,17 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n>> \t}\n>> \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n>> \n>> -#if HAVE_DEBAYER_EGL\n>> \tconst char *softISPMode = utils::secure_getenv(\"LIBCAMERA_SOFTISP_MODE\");\n>> +\tif (softISPMode) {\n>> +\t\tif (strcmp(softISPMode, \"gpu\") && strcmp(softISPMode, \"cpu\")) {\n>> +\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode << \" invalid. \"\n>> +\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n>> +\t\t\treturn;\n>> +\t\t}\n>> +\t}\n>> \n>> -\tif (softISPMode && !strcmp(softISPMode, \"gpu\"))\n>> +#if HAVE_DEBAYER_EGL\n>> +\tif (!softISPMode || !strcmp(softISPMode, \"gpu\"))\n>> \t\tdebayer_ = std::make_unique(std::move(stats), configuration);\n>> #endif\n>> \tif (!debayer_)\n> -- \n> Robert Mader\n> Consultant Software Developer\n>\n> Collabora Ltd.\n> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK\n> Registered in England & Wales, no. 5513718","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A322C3259\n\tfor ;\n\tThu, 16 Oct 2025 09:21:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 127D86066F;\n\tThu, 16 Oct 2025 11:21:28 +0200 (CEST)","from sender4-op-o12.zoho.com (sender4-op-o12.zoho.com\n\t[136.143.188.12])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30EE060669\n\tfor ;\n\tThu, 16 Oct 2025 11:21:26 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1760606481533469.7184163063142;\n\tThu, 16 Oct 2025 02:21:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"Ay3SEq7F\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1760606483; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=bwIhMU3bsts8md/pwZwoRS6mV9chZg95QF9xCwmdWpzS+c8WWWLoJpmOJkBQAqS0eM7IWQ9OP48/gZXlR99jtjE9IDEFBEXVFsquAxxLAmPg1GVNuSjn8BulrBcljEaru232GgPiL4YSdEHHm09Var19gVJfnGGdYbzTtWYp7qA=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760606483;\n\th=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=wGT3J8YC/csTRAt9O1b2S8ll61OvUW6BOaYl5OBtUqM=; \n\tb=XHIZ1WVtdLHdxiUyGkU2XQ9PiomP4BIOpvNjPKN57ZKPW5IekRVGeOpoPLE15iNHm2NJ4Z4/eUhs8vbQkWKlSPUCy4UVEBHQZ76JUjja/5DNYwdmZeFwk4siqWDZvc+o5VtdkShyzReZ73/ymRkA7RW0dM+y4ENumsOQzTlDrUU=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760606483;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Message-Id:Reply-To:Cc;\n\tbh=wGT3J8YC/csTRAt9O1b2S8ll61OvUW6BOaYl5OBtUqM=;\n\tb=Ay3SEq7F/4JZC3af7QKyp9xoIgAmQdleWsvlCH8K3GnCcM9duzo/5qLQ0T+XtUBf\n\tIGgpPYqQOsyxn6Hi+dh3DdRxoqvz/P7ZKXfQxx9wmahl3I0pHGNbAlOXumnZF4db/Lv\n\tOV/XftZFk9Z8kTdjmQEJ34Acznz1Oflm0wi4NtEQ=","Content-Type":"multipart/alternative;\n\tboundary=\"------------XnpK0OTXcX4XU44tGkrbZYxJ\"","Message-ID":"","Date":"Thu, 16 Oct 2025 11:21:15 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","To":"libcamera-devel@lists.libcamera.org","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-36-bryan.odonoghue@linaro.org>\n\t<2651920e-2fff-440b-adab-105d40d27526@collabora.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<2651920e-2fff-440b-adab-105d40d27526@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36330,"web_url":"https://patchwork.libcamera.org/comment/36330/","msgid":"<894d4971-befc-4e81-a8f7-18a3f05bbe6d@collabora.com>","date":"2025-10-16T18:44:13","subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"Ok, sorry for the noise. With the camera restart issue fixed, I quickly \ntested it on all devices I have - PinePhone, Librem5, Pixel3a and \nOnePlus 6 - and the GPU-ISP seems to perform better or at least not \nregress across the board. So it looks like good enough to ship on \nPostmarketOS edge.\n\nOn 16.10.25 11:21, Robert Mader wrote:\n> On 10/16/25 11:06, Robert Mader wrote:\n>>\n>> While I love to see this, I think we should have at least one release \n>> with the swisp staying the default in order to avoid fallout - in \n>> particular:\n>>\n>> 1. There is no Pipewire release with the necessary sandbox change\n>> yet (in a month or two we could have 1.6 and 1.4.10)\n>>\n> Sorry, correction: looks like the patch *did* already get backported \n> already in 1.4.8. so this shouldn't be an issue.\n>>\n>> 1. With the current series I observe at least one crash specific to\n>> the gpuisp (hitting the assert in eGL::cleanUp(void)) and I\n>> assume it won't be the only one when getting more testing, even\n>> if I manage to debug this in the next couple of days.\n>>\n>> Being able to work those out without getting issues from users or \n>> having to carry downstream patches would be nice :)\n>>\n>> On 10/15/25 03:22, Bryan O'Donoghue wrote:\n>>> In some cases the GPU can deliver 15x performance in Debayer with the\n>>> CCM on, reference hardware Qualcomm RB5 with IMX512 sensor.\n>>>\n>>> Given this large performance difference it makes sense to make GPUISP\n>>> the default for the Software ISP.\n>>>\n>>> If LIBCAMERA_SOFTISP_MODE is omitted gpu will be the default. If\n>>> libcamera is compiled without gpuisp support, CPU Debayer will be used.\n>>>\n>>> It is still possible to select CPU mode with LIBCAMERA_SOFISP_MODE=cpu.\n>>>\n>>> Signed-off-by: Bryan O'Donoghue\n>>> ---\n>>> src/libcamera/software_isp/software_isp.cpp | 11 +++++++++--\n>>> 1 file changed, 9 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n>>> index 869f7320..1b4a29fd 100644\n>>> --- a/src/libcamera/software_isp/software_isp.cpp\n>>> +++ b/src/libcamera/software_isp/software_isp.cpp\n>>> @@ -120,10 +120,17 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n>>> \t}\n>>> \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n>>> \n>>> -#if HAVE_DEBAYER_EGL\n>>> \tconst char *softISPMode = utils::secure_getenv(\"LIBCAMERA_SOFTISP_MODE\");\n>>> +\tif (softISPMode) {\n>>> +\t\tif (strcmp(softISPMode, \"gpu\") && strcmp(softISPMode, \"cpu\")) {\n>>> +\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode << \" invalid. \"\n>>> +\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n>>> +\t\t\treturn;\n>>> +\t\t}\n>>> +\t}\n>>> \n>>> -\tif (softISPMode && !strcmp(softISPMode, \"gpu\"))\n>>> +#if HAVE_DEBAYER_EGL\n>>> +\tif (!softISPMode || !strcmp(softISPMode, \"gpu\"))\n>>> \t\tdebayer_ = std::make_unique(std::move(stats), configuration);\n>>> #endif\n>>> \tif (!debayer_)\n>> -- \n>> Robert Mader\n>> Consultant Software Developer\n>>\n>> Collabora Ltd.\n>> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK\n>> Registered in England & Wales, no. 5513718\n> -- \n> Robert Mader\n> Consultant Software Developer\n>\n> Collabora Ltd.\n> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK\n> Registered in England & Wales, no. 5513718","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4F37C3259\n\tfor ;\n\tThu, 16 Oct 2025 18:44:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1511060696;\n\tThu, 16 Oct 2025 20:44:29 +0200 (CEST)","from sender4-op-o15.zoho.com (sender4-op-o15.zoho.com\n\t[136.143.188.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52DF6605D7\n\tfor ;\n\tThu, 16 Oct 2025 20:44:27 +0200 (CEST)","by mx.zohomail.com with SMTPS id 176064025657219.93151962309446;\n\tThu, 16 Oct 2025 11:44:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"PSopqL70\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1760640260; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=mVx9KqM9/o9cn3usr1ifZ53VLvCPa56TEqMfpwOsbvQ94+tyZcAcLQf/0Ka+42z6YEjKskP0c36oM0C2P0oulFQp264wv/W5Lp+OPd7d9BnLS9w4cQ/ZUCuRi3vFGAkAEYrM+WseCK0PliCo6u/2c3Bd91P2kJ9QMu77CVmOrUg=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760640260;\n\th=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=9uacfhqb7xkvEy/pUeHpLFVR1P7C3qwfcy5DCwFaNNg=; \n\tb=NrJ9ILBxUnv6BzKLAcmQ6dvmz79rezp6FJlmv2NfLPZaxchStAY6lhKn5dZxjaz0Wh9ihJRLT89mTriEf4Ik7/lm2r5Yvdbun43J4zwCHNoRVDP1bf1TuspR9pqMaBRCZIS75lIMugBtBWJ1lN6ui31b2XDoXmC7ysRPQYYVTOM=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760640260;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Message-Id:Reply-To:Cc;\n\tbh=9uacfhqb7xkvEy/pUeHpLFVR1P7C3qwfcy5DCwFaNNg=;\n\tb=PSopqL70tmk5a5c7/zvz2cEqi/mU2cfCUdouBgMI7w57m7vZ5hAdIbuifcXb7D2m\n\t7Gu99vX1iPIzq6g68+C3MpzMyHKjH3WLfiHtuEROdR2mffSEc0lxL+UIn9v+qBe26UU\n\tUIORIIOpTeNY4Ur8ORadxxI6UY8Sxj0I6B9zTVAA=","Content-Type":"multipart/alternative;\n\tboundary=\"------------NhT0r3PYd303eg7Dj1hp2vtu\"","Message-ID":"<894d4971-befc-4e81-a8f7-18a3f05bbe6d@collabora.com>","Date":"Thu, 16 Oct 2025 20:44:13 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","To":"libcamera-devel@lists.libcamera.org","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-36-bryan.odonoghue@linaro.org>\n\t<2651920e-2fff-440b-adab-105d40d27526@collabora.com>\n\t","Content-Language":"en-US, de-DE, en-GB","From":"Robert Mader ","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36811,"web_url":"https://patchwork.libcamera.org/comment/36811/","msgid":"","date":"2025-11-14T12:12:52","subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","submitter":{"id":49,"url":"https://patchwork.libcamera.org/api/people/49/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> Ok, sorry for the noise. With the camera restart issue fixed, I quickly \n> tested it on all devices I have - PinePhone, Librem5, Pixel3a and \n> OnePlus 6 - and the GPU-ISP seems to perform better or at least not \n> regress across the board. So it looks like good enough to ship on \n> PostmarketOS edge.\n\nI thought I would be first one to test this on Librem 5, but\napparently you was faster.\n\nThank you!\n\nBest regards,\n\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B42AC3263\n\tfor ;\n\tFri, 14 Nov 2025 12:12:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AEAE4609D8;\n\tFri, 14 Nov 2025 13:12:55 +0100 (CET)","from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7C21606E6\n\tfor ;\n\tFri, 14 Nov 2025 13:12:53 +0100 (CET)","by jabberwock.ucw.cz (Postfix, from userid 1017)\n\tid 209D01C00AB; Fri, 14 Nov 2025 13:12:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ucw.cz header.i=@ucw.cz header.b=\"F+VbdqDE\";\n\tdkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1;\n\tt=1763122373;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=c2iGZ5zFcV4dJkl8vDyhTxCACCicNrCwrXCSyCh5ILM=;\n\tb=F+VbdqDEA7dlCW2A9RABGbaMUAF7LhYuVBUw8sC9EBSYkHdHFW7r4DVbe/S+mGDIQal217\n\tfuH7wfoRkoau5dqCaDqzD0GArcNbkwvaTnOuDEfp7FwDESCR6qipOgCiFshhMH4NufPhLK\n\tC0WAiWzeQ4tiwK/fLraDa7PtvGTwzXc=","Date":"Fri, 14 Nov 2025 13:12:52 +0100","From":"Pavel Machek ","To":"libcamera-devel@lists.libcamera.org,\n\tRobert Mader ","Subject":"Re: [PATCH v3 35/39] libcamera: software_isp: debayer_egl: Make\n\tgpuisp default softisp mode","Message-ID":"","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-36-bryan.odonoghue@linaro.org>\n\t<2651920e-2fff-440b-adab-105d40d27526@collabora.com>\n\t\n\t<894d4971-befc-4e81-a8f7-18a3f05bbe6d@collabora.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"77NirNWqtHZmI0Qf\"","Content-Disposition":"inline","In-Reply-To":"<894d4971-befc-4e81-a8f7-18a3f05bbe6d@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]