[{"id":36280,"web_url":"https://patchwork.libcamera.org/comment/36280/","msgid":"<176056873960.162040.11195098060819950299@ping.linuxembedded.co.uk>","date":"2025-10-15T22:52:19","subject":"Re: [PATCH v3 25/39] libcamera: software_isp: Make\n\tisStandardBayerOrder static","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-10-15 02:22:37)\n> Make this member function static so that it may be called from static\n> members of derived classes.\n> \n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/debayer.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index 8fa281c7..a88f352b 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -100,7 +100,7 @@ private:\n> protected:\n> void setParams(DebayerParams ¶ms);\n> void dmaSyncBegin(std::vector &dmaSyncers, FrameBuffer *input, FrameBuffer *output);\n> - bool isStandardBayerOrder(BayerFormat::Order order);\n> + static bool isStandardBayerOrder(BayerFormat::Order order);\n\nPlease squash this directly into \n[PATCH v3 14/39] libcamera: software_isp: Move isStandardBayerOrder to base class\n\n\n> };\n> \n> } /* namespace libcamera */\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11504BE080\n\tfor ;\n\tWed, 15 Oct 2025 22:52:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A2EA60651;\n\tThu, 16 Oct 2025 00:52:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B2036063D\n\tfor ;\n\tThu, 16 Oct 2025 00:52:22 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E4F071189;\n\tThu, 16 Oct 2025 00:50:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XkKzLz3V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760568643;\n\tbh=f7vF3VcdP0KruuUF9IUWmIO5ObQb2x7+N2V/gd/q660=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=XkKzLz3VYxfoRKKm7qccto9bTCDnkDOfMoKXCREqM8tlmGU/bH9un2TBTuvRUHnRq\n\t3A0EBxaFsVzE7xb5JDbCsdFobia5Wu3zWwe2chcn2JG16m2IpFWnX9xILYTVyuAWIM\n\tRZaSlNZnX/apR+KJvG9ouF0Rq1JTWqGTkD8mcgmc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251015012251.17508-26-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-26-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v3 25/39] libcamera: software_isp: Make\n\tisStandardBayerOrder static","From":"Kieran Bingham ","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 15 Oct 2025 23:52:19 +0100","Message-ID":"<176056873960.162040.11195098060819950299@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]