[{"id":36279,"web_url":"https://patchwork.libcamera.org/comment/36279/","msgid":"<176056856135.635357.5817616334684939864@ping.linuxembedded.co.uk>","date":"2025-10-15T22:49:21","subject":"Re: [PATCH v3 23/39] libcamera: software_isp: lut: Make gain\n\tcorrected CCM in lut.cpp available in debayer params","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-10-15 02:22:35)\n> There is another CCM calculated in this algorithm callback, this time based\n> on the LUT.\n> \n\nPlease squash this into patch \n[PATCH v3 18/39] libcamera: software_isp: debayer: Extend DebayerParams struct to hold a copy of per-frame CCM values\n\nas well so we can see the handling of the params->ccm altogether to\nbetter understand the whole usage and implications.\n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/ipa/simple/algorithms/lut.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index d1d5f727..a161adb1 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -126,6 +126,7 @@ void Lut::prepare(IPAContext &context,\n> auto &red = params->redCcm;\n> auto &green = params->greenCcm;\n> auto &blue = params->blueCcm;\n> + params->ccm = ccm;\n> for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n> red[i].r = ccmValue(i, ccm[0][0]);\n> red[i].g = ccmValue(i, ccm[1][0]);\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E278FC3259\n\tfor ;\n\tWed, 15 Oct 2025 22:49:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 225E560651;\n\tThu, 16 Oct 2025 00:49:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EF606063D\n\tfor ;\n\tThu, 16 Oct 2025 00:49:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 076581189;\n\tThu, 16 Oct 2025 00:47:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mgceiK5k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760568465;\n\tbh=WVyLsl07mYK0+PsIK1jrYKD9r5wyWbVeEomoF1LyJhE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mgceiK5kxEfo+93nJcd7IMhQyPlilqJhKZlDJYAK4K/zIjvbs++4OHPAK+YSOU1/x\n\toeSUw+QaMC8kkNqW6ET6m6guB3KjTYqvVpK3qR7w/vZE3z1cmrMqG8HMagvQl8FU1u\n\tkzhA/tyoG8fMgIo+OfC4yzS/RdUUr55BU5dGdM8s=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251015012251.17508-24-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-24-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v3 23/39] libcamera: software_isp: lut: Make gain\n\tcorrected CCM in lut.cpp available in debayer params","From":"Kieran Bingham ","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 15 Oct 2025 23:49:21 +0100","Message-ID":"<176056856135.635357.5817616334684939864@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36310,"web_url":"https://patchwork.libcamera.org/comment/36310/","msgid":"<85plandqrj.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-10-16T11:34:24","subject":"Re: [PATCH v3 23/39] libcamera: software_isp: lut: Make gain\n\tcorrected CCM in lut.cpp available in debayer params","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> Quoting Bryan O'Donoghue (2025-10-15 02:22:35)\n>> There is another CCM calculated in this algorithm callback, this time based\n>> on the LUT.\n>> \n>\n> Please squash this into patch \n> [PATCH v3 18/39] libcamera: software_isp: debayer: Extend DebayerParams struct to hold a copy of per-frame CCM\n> values\n>\n> as well so we can see the handling of the params->ccm altogether to\n> better understand the whole usage and implications.\n\n+1\n\n>> Signed-off-by: Bryan O'Donoghue \n>> ---\n>> src/ipa/simple/algorithms/lut.cpp | 1 +\n>> 1 file changed, 1 insertion(+)\n>> \n>> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n>> index d1d5f727..a161adb1 100644\n>> --- a/src/ipa/simple/algorithms/lut.cpp\n>> +++ b/src/ipa/simple/algorithms/lut.cpp\n>> @@ -126,6 +126,7 @@ void Lut::prepare(IPAContext &context,\n>> auto &red = params->redCcm;\n>> auto &green = params->greenCcm;\n>> auto &blue = params->blueCcm;\n>> + params->ccm = ccm;\n>> for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n>> red[i].r = ccmValue(i, ccm[0][0]);\n>> red[i].g = ccmValue(i, ccm[1][0]);\n>> -- \n>> 2.51.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4041C3259\n\tfor ;\n\tThu, 16 Oct 2025 11:34:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D64E760681;\n\tThu, 16 Oct 2025 13:34:32 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABCDF605D7\n\tfor ;\n\tThu, 16 Oct 2025 13:34:31 +0200 (CEST)","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-220-wdVtSu9HN56hx7DgewZX_Q-1; Thu, 16 Oct 2025 07:34:29 -0400","by mail-wr1-f69.google.com with SMTP id\n\tffacd0b85a97d-426d4f59cbcso938122f8f.1\n\tfor ;\n\tThu, 16 Oct 2025 04:34:29 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-426ce582b39sm33805975f8f.15.2025.10.16.04.34.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Oct 2025 04:34:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BWZugf8o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1760614470;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=q2eJBx/Di3pljchC5nP/zslRMJGOEKEPurkFPjld+cQ=;\n\tb=BWZugf8oUbfQnIDqoYV/ywYZnphdhQ03PmsRNWyxPsG+D0jDNBV704iZimZrJph4YCiRHm\n\t5BqmvHiJ/SBWpMdNynwLbuBLm9qUGwtdKlDUEP+3PmBdlRz/iKrUc/sM2Ty0dO8ZeyNqNm\n\tcJ6qi1M52K4nbzmPjLM2H70PIuJRefY=","X-MC-Unique":"wdVtSu9HN56hx7DgewZX_Q-1","X-Mimecast-MFC-AGG-ID":"wdVtSu9HN56hx7DgewZX_Q_1760614468","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760614468; x=1761219268;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=q2eJBx/Di3pljchC5nP/zslRMJGOEKEPurkFPjld+cQ=;\n\tb=oNhm6CMfJgGZy4IH6Frl3+psP2IKj22SuL6IN9G/px78GKKV0S3syVt1ufIaxWD5pz\n\tPxhJoR+gccNztLcMJ0aClMgogGu5t7Rm93pYz8nEKMphNFKGstrBs7m0pjN4HNnOee0P\n\tERoJa0XN6p+UuzFl5K35euDwLr814wM+IYilMT0bLVunweY2I0O7reI4Q/Z0Pqad9Agl\n\tCpENT5utPvJva1m8i76P/Jqg/yAOqucLvDCZDw0XYE785l5w23fosLnNn/ZSm+DB47Ib\n\txNKOTuYbadPFSXeviqCmF1zc03U5obrygO0w2KXbgIVo3b7FWZ9qC60RHkcnCpRgqQ7x\n\t+rvg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVjBhTitFXKXC7PFkH21mEDR5RTBFVwsGTRfYxgpGDj4OPBaYj1Oew+t1lwHJCcKdrR05ADtXDJItIQsl7Q+1w=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YzjDOcyeYhUqKqoXmJNj20dgEPuXLqcObZC3BNkfOTHUjmYj3Yw\n\tvaE63G3cMENL3YBOXa6XM7kQ7RQ4eLKTyhpdQ8pfaXJn/VpesQ5ZnZD/rRuyvVh/o6u8+xB8pti\n\tiWo3QJ74wsfGyYjkXRAWQtjTsAPabjjNtuI9vR15Z6FYODRrxr9cTTEEdGG5wpT7uaYI0Ka4pDT\n\t8wJ1GTWfk=","X-Gm-Gg":"ASbGnctoB/9xzb5iqwXghv1E1yKaG6CzAKb5g9un1zS92fRHYF148yst7WJ46EMIb/M\n\tfsp9DQz6xcw8B/tKvzzm597iLAIcaFJ0eBoHzdZqeH5eNk19+xBwuGaQZYhMwaY3XHOl1c0pmGR\n\tRK7JXYnXOqmE74SfeS6J31bVqBAXSubDowy0fqovdz79gioiR+WFaP32WZY3LBojBpoQ3u6I217\n\tR6XIe1uFv1jSq/lrttRXi0mHqvXmo3Ce1FMWvn95gLbKxUALNHlPjijGczQiAhhLshRAe+rGUn2\n\t5Dk2Rzo1MomgDOXU5iGlybV2V0vBCh64swdIHuytHf1MMGr3gqJLkZXE6Ljk31xY2jpBEQu/225\n\tDYX7EiTTafJwj0qU+Xu7QUTFrpp3JeVPny3sh0m1epEtavsOz0jJM","X-Received":["by 2002:a05:6000:2312:b0:426:da92:d39d with SMTP id\n\tffacd0b85a97d-426fb7b4247mr2859733f8f.24.1760614467287; \n\tThu, 16 Oct 2025 04:34:27 -0700 (PDT)","by 2002:a05:6000:2312:b0:426:da92:d39d with SMTP id\n\tffacd0b85a97d-426fb7b4247mr2859205f8f.24.1760614465700; \n\tThu, 16 Oct 2025 04:34:25 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHkCX8tT9ndqFI2W4tQrCDPcy756oIyqd274gMIfjmQR8l7bYs54PI6XNuAbN4XTpFV2sSEVQ==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org, hdegoede@redhat.com,\n\tbod.linux@nxsw.ie","Subject":"Re: [PATCH v3 23/39] libcamera: software_isp: lut: Make gain\n\tcorrected CCM in lut.cpp available in debayer params","In-Reply-To":"<176056856135.635357.5817616334684939864@ping.linuxembedded.co.uk>\n\t(Kieran Bingham's message of \"Wed, 15 Oct 2025 23:49:21 +0100\")","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-24-bryan.odonoghue@linaro.org>\n\t<176056856135.635357.5817616334684939864@ping.linuxembedded.co.uk>","Date":"Thu, 16 Oct 2025 13:34:24 +0200","Message-ID":"<85plandqrj.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"gSYokISuJfQx2Z-rm5KPvPAmCaJmccIQS7D2JevlD3o_1760614468","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]