[{"id":36278,"web_url":"https://patchwork.libcamera.org/comment/36278/","msgid":"<176056843488.162040.11380998691532801390@ping.linuxembedded.co.uk>","date":"2025-10-15T22:47:14","subject":"Re: [PATCH v3 20/39] libcamera: software_isp: awb Populate AWB gains\n\tto Debayer params structure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-10-15 02:22:32)\n> Populate the white-balance gains table in awb::prepare(). A copy is made\n> of the gains in the DebayerParams structure.\n> \n\nAnd I think this can be squashed into :\n\n[PATCH v3 19/39] libcamera: software_isp: debayer: Extend DebayerParams to hold a copy of per-frame AWB values\n\nKeeping the order of 18, then 19 so theres' no merge conflict on the\ndebayer_params.h\n\nWith that I think that's \n\nReviewed-by: Kieran Bingham \n\nfor the combined new patch.\n\n\n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/ipa/simple/algorithms/awb.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index cf78e980..3c4e5d09 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -38,12 +38,14 @@ int Awb::configure(IPAContext &context,\n> void Awb::prepare(IPAContext &context,\n> [[maybe_unused]] const uint32_t frame,\n> IPAFrameContext &frameContext,\n> - [[maybe_unused]] DebayerParams *params)\n> + DebayerParams *params)\n> {\n> auto &gains = context.activeState.awb.gains;\n> /* Just report, the gains are applied in LUT algorithm. */\n> frameContext.gains.red = gains.r();\n> frameContext.gains.blue = gains.b();\n> + /* Latch the AWB gains so GPUISP can consume them. */\n> + params->gains = gains;\n> }\n> \n> void Awb::process(IPAContext &context,\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BE7CC3259\n\tfor ;\n\tWed, 15 Oct 2025 22:47:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 615D160640;\n\tThu, 16 Oct 2025 00:47:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55140605F3\n\tfor ;\n\tThu, 16 Oct 2025 00:47:18 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7F651189;\n\tThu, 16 Oct 2025 00:45:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XikkArhb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760568339;\n\tbh=CGK/qYvWVk40I3u4QtY2EJl4w/+GqcLC+p5TdMEyFDo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=XikkArhbSXOw26j/x2+tzP4XqJyVmvj5mH8uFyn/5e+q+UcU45AKqAn0WcMG99EIk\n\tGN6UOT3RS1ZxLQ0Rs214F60XbFy2nDOagNIX0kpas7P/r1syVEIoFMpdKh1H1ku0FE\n\tLuwtrdz9m9Jel54XSm1kzpYvUDfBV8dWv4AhiyvI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251015012251.17508-21-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-21-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v3 20/39] libcamera: software_isp: awb Populate AWB gains\n\tto Debayer params structure","From":"Kieran Bingham ","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 15 Oct 2025 23:47:14 +0100","Message-ID":"<176056843488.162040.11380998691532801390@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36305,"web_url":"https://patchwork.libcamera.org/comment/36305/","msgid":"<85a51rfbnh.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-10-16T09:17:54","subject":"Re: [PATCH v3 20/39] libcamera: software_isp: awb Populate AWB\n\tgains to Debayer params structure","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Populate the white-balance gains table in awb::prepare(). A copy is made\n> of the gains in the DebayerParams structure.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/simple/algorithms/awb.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\n> index cf78e980..3c4e5d09 100644\n> --- a/src/ipa/simple/algorithms/awb.cpp\n> +++ b/src/ipa/simple/algorithms/awb.cpp\n> @@ -38,12 +38,14 @@ int Awb::configure(IPAContext &context,\n> void Awb::prepare(IPAContext &context,\n> \t\t [[maybe_unused]] const uint32_t frame,\n> \t\t IPAFrameContext &frameContext,\n> -\t\t [[maybe_unused]] DebayerParams *params)\n> +\t\t DebayerParams *params)\n> {\n> \tauto &gains = context.activeState.awb.gains;\n> \t/* Just report, the gains are applied in LUT algorithm. */\n> \tframeContext.gains.red = gains.r();\n> \tframeContext.gains.blue = gains.b();\n> +\t/* Latch the AWB gains so GPUISP can consume them. */\n> +\tparams->gains = gains;\n> }\n> \n> void Awb::process(IPAContext &context,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FACFBE080\n\tfor ;\n\tThu, 16 Oct 2025 09:18:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 361DE60675;\n\tThu, 16 Oct 2025 11:18:02 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0556B600CC\n\tfor ;\n\tThu, 16 Oct 2025 11:17:59 +0200 (CEST)","from mail-ej1-f71.google.com (mail-ej1-f71.google.com\n\t[209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-107-iv2fjqb5PgC_3kndTaRrRg-1; Thu, 16 Oct 2025 05:17:57 -0400","by mail-ej1-f71.google.com with SMTP id\n\ta640c23a62f3a-b3cb0f2b217so69172866b.2\n\tfor ;\n\tThu, 16 Oct 2025 02:17:57 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5cb965da86sm453458366b.12.2025.10.16.02.17.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Oct 2025 02:17:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"eAHNhD4o\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1760606278;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=vzz3O+X3c/EesX4m2Tu2sp6dMXBa1mdl3IcG6V+1CeI=;\n\tb=eAHNhD4oCCisKdhQWtvT9iR0Bhy99F9SdACQiVeymMMmcB0Hyyk6iC3S7mntCjtnv8wjeI\n\tBpkieJyEPzT0PlChFQv+MhT1nKi0+gf+hCMDUfPpsymogQ+1LjI5zrjdzYoj0UuY0cFk4Y\n\ty46FeS73b3WhXPozMNntxg6F44EnrGc=","X-MC-Unique":"iv2fjqb5PgC_3kndTaRrRg-1","X-Mimecast-MFC-AGG-ID":"iv2fjqb5PgC_3kndTaRrRg_1760606277","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760606276; x=1761211076;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vzz3O+X3c/EesX4m2Tu2sp6dMXBa1mdl3IcG6V+1CeI=;\n\tb=rOGYLhc7RKuNBSIlW4LFKRdtiEkEPi1uNzw/0gk1rwuUyoippYULZQdyXBGMVmrgXR\n\tcxHaL3Cv9FKKTvawHAQ8vNyxpZunO7Jq5DaU17bv8RozUws0YDCg672svxLwdTPJ36jB\n\topnIBh7VbCEqUnkiCTDeFfhWeTwX2GnQO2hIHaxx/XfN6jMVr0/Sd63q62bw8KDLUNd9\n\thn4UJw8b/aGbNBzglHiAIrlcAp5zEYYmDllXd//edMuwlqDzYUVfdSORli4sorkPsVGs\n\tQGNTKmlIraXD4wYqmZgadsbLD5lrAfz9MNBrSk3RhNamOGxDSLrUaxSy+HY09J9BT/xD\n\tkdHg==","X-Gm-Message-State":"AOJu0YyUlsb6Ki8XDub5PujBRiZJkrPfe3+KIQMXyeBlID+clQJCzizV\n\t9JT7EhqRoOPXwItb5Cjc3SaxgsvFeUrywzs9kHV4cmTvSewySZWyJpzNFvtAlLy5eiBcJMkd9zT\n\tYjCvbI+whbpGk0BcrTQ8HQ9HDyIoXLX8DPGh08j2HrxvUagTNxDHdo9AW/oVGKn748LlSGs6Bn8\n\tMLcK5Ufdg=","X-Gm-Gg":"ASbGnct9Vj71MxLAJtnjpexnrm3Hg8yPxeihFHBnvzzzP44MWdij1l/Cth3UIJW7iUG\n\tSNMiVVBQG7JnwDin0/6aAZQ40ALvVqyL1KdY1O1+aVR/29BqwGXr9pvtBEGbHilakEfzSBVGjur\n\tLnSXCyK6pUbn3gRYj35eSMu16RkpV/+bz25UZrSac1M03xoTg1Qkg7d8OeNz7Iv8S88Rb1DnaQJ\n\tt4AVFAb2pkoHTdEnHq1NN1nzNuhPCGpCrT1U9Yp3Pma2TE+TvMouLhEzo5XzzKFrUf38jVdODIq\n\tIi2UnnfpaMrHmpSmWcmoWH/xTngpQgg8CPuidmchtD0uPqPsZJua8uL1hNQDeEAoMVCzUeYVakw\n\tgKoCksA2+pi/cPXPY3XS3FX4UnLyrsyTUuu7PA7qG73TK63uP6L4O","X-Received":["by 2002:a17:907:72c6:b0:b46:8bad:6970 with SMTP id\n\ta640c23a62f3a-b50abaa43b4mr3661563766b.36.1760606276105; \n\tThu, 16 Oct 2025 02:17:56 -0700 (PDT)","by 2002:a17:907:72c6:b0:b46:8bad:6970 with SMTP id\n\ta640c23a62f3a-b50abaa43b4mr3661561066b.36.1760606275549; \n\tThu, 16 Oct 2025 02:17:55 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGTSveft9ylWlQcXiqyutPt43bkeVtERMEDqs/SHK+/0g+WKLArFpOaLdQfP+x1T6z2t38PGQ==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, hdegoede@redhat.com,\n\tbod.linux@nxsw.ie","Subject":"Re: [PATCH v3 20/39] libcamera: software_isp: awb Populate AWB\n\tgains to Debayer params structure","In-Reply-To":"<20251015012251.17508-21-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 15 Oct 2025 02:22:32 +0100\")","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-21-bryan.odonoghue@linaro.org>","Date":"Thu, 16 Oct 2025 11:17:54 +0200","Message-ID":"<85a51rfbnh.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"x0jZ8Ik2q3JsCZllqb0hxQLcUgQnx9PfKNq29nMWI4M_1760606277","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]