[{"id":36304,"web_url":"https://patchwork.libcamera.org/comment/36304/","msgid":"<85ecr3fbsk.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-10-16T09:14:51","subject":"Re: [PATCH v3 19/39] libcamera: software_isp: debayer: Extend\n\tDebayerParams to hold a copy of per-frame AWB values","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Bryan,\n\nBryan O'Donoghue writes:\n\n> Add a vector to allow the AWB gains calculated in the IPA to be fed back into\n> the Debayer shaders.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/software_isp/debayer_params.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index 56803195..9d0a852d 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -14,6 +14,7 @@\n> #include \n> \n> #include \"libcamera/internal/matrix.h\"\n> +#include \"libcamera/internal/vector.h\"\n> \n> namespace libcamera {\n> \n> @@ -56,6 +57,11 @@ struct DebayerParams {\n> \t * Per frame CCM values as calcualted by the IPA\n> \t */\n> \tMatrix ccm;\n> +\n> +\t/*\n> +\t * Per frame awb gains calculated by the IPA\n> +\t */\n\nI think this can be on a single line:\n\n /* ... */\n\nReviewed-by: Milan Zamazal \n\n> +\tRGB gains;\n> };\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2A99C3259\n\tfor ;\n\tThu, 16 Oct 2025 09:15:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0433A60675;\n\tThu, 16 Oct 2025 11:15:00 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE43A600CC\n\tfor ;\n\tThu, 16 Oct 2025 11:14:57 +0200 (CEST)","from mail-ej1-f70.google.com (mail-ej1-f70.google.com\n\t[209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-14-k2HDwhi7NpiPnabwwgxlPg-1; Thu, 16 Oct 2025 05:14:55 -0400","by mail-ej1-f70.google.com with SMTP id\n\ta640c23a62f3a-b5cbb3629f2so52094666b.1\n\tfor ;\n\tThu, 16 Oct 2025 02:14:55 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd2a6847sm450505266b.67.2025.10.16.02.14.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Oct 2025 02:14:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"KH2VW32/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1760606096;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=FLatFX3hrxnYdMXieFde+sUFG3RBz8E7cWHtDxXEyxg=;\n\tb=KH2VW32/EFbyQEkk4rnHY7fAVevBlLXzJAKTrgB6A1zlFkVdltWZhn+Mj0ahPE6nIcds1e\n\t0f25PirxTMpI8Q2c9JHrCucI/rTtmooQN8k2SsggH98iugVHhCjH3FiQ/pTWaczB8dEF+d\n\t2yAZQ4na7j/HZF+mp5ZjS8QcmTfCjFs=","X-MC-Unique":"k2HDwhi7NpiPnabwwgxlPg-1","X-Mimecast-MFC-AGG-ID":"k2HDwhi7NpiPnabwwgxlPg_1760606094","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760606094; x=1761210894;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=FLatFX3hrxnYdMXieFde+sUFG3RBz8E7cWHtDxXEyxg=;\n\tb=IbyCj1Quu7HEYqpb0qqtx2PY1x6KJCUzJy1C+I+NkRuH1wevo7uAJnUonclFtN1au2\n\tyt+9Ign1LSQiLW39j1827ASfHvD+fU77gmWdeMycx9lSctlndi+aFnHbyUDGr+jerKG2\n\tTCU4xoiwImkMvxLZ/ghifIsnURKzBs4+pFZKNGjH8E8DmuCABFrqFkX4VXR3OE4U8Liy\n\tA06DbaTsFRo8sLSBBAZI/HhCmq4o/fwMeEmcv5SFOPv1MP75dVpqZ2wk+eHETT1DysXe\n\thcHkLDna17VquMzcuzoikMKjPNEsDYVj5Dg202eY73Rth5ihhog3XFmz2snGTBFm6O0G\n\tRd+A==","X-Gm-Message-State":"AOJu0YwipZxNhCUgt3pNmSFDxG0c8PMAIdqwSWvVeaN2N/PxgCna1r8j\n\t6JiJQc8VwZ01rQ5JjzQpnwMrMUvofcPF6rSYa52P0HP1ruIxJK6TkLwAxBD0r/M2u3DsOwKY9OR\n\t4S1Vl12bXHS+yUT9Lv7C2oavwRxtts1FlaT8/HDhE5JcIvtblSXD+9dkUYEpKiQaahBWEoH6Nph\n\tR1PrTDsrA=","X-Gm-Gg":"ASbGncvfc94XPXQ/yUE4Q99Y2XkMW9Pl0qi7VPtEbwkSv5bLpqshFk5rLsruQC0fzmp\n\tSm8g/to1estorOJnvjUrK3bF3fc12rFGglEMoezSngGayBY/wL/rJtTP6ghL33Zk9bjtQk3m1E0\n\t/Er85ZWeQhbdSOzbDmx+ETm2mhbLaum/qanTzQEVXendAkc3J90drgdyLw1SkzDWohMjSws3mJ2\n\tv1/XH2wji3zfGtSXNdHJ7iRNdJgrKl3hJltZaUawVd6HgHb6BIJ3vc1vRTMvome+QyN8qmo+9xN\n\thOh0ukiHDJDTldi2beuDa3wpqaaLTWsjz7O6OOQlFlaJuPLKyVQX/h50i2uHg4UXlN7GROvFCde\n\tAWkIDCoHCXPMNT6/NcEAYjb3b2aGTI5Q0u3i/ADu+pP21s5w4weGN","X-Received":["by 2002:a17:906:c105:b0:b3e:907c:9e26 with SMTP id\n\ta640c23a62f3a-b50ac5cfaf7mr3361628166b.59.1760606093595; \n\tThu, 16 Oct 2025 02:14:53 -0700 (PDT)","by 2002:a17:906:c105:b0:b3e:907c:9e26 with SMTP id\n\ta640c23a62f3a-b50ac5cfaf7mr3361625366b.59.1760606093201; \n\tThu, 16 Oct 2025 02:14:53 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGVyioGV2LjuHtDhpJav7gxbOGPif7/bEgIQneVRIxXTpf/n2CQkPcIcNlj/JPDl7IAPs3kRw==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, hdegoede@redhat.com,\n\tbod.linux@nxsw.ie","Subject":"Re: [PATCH v3 19/39] libcamera: software_isp: debayer: Extend\n\tDebayerParams to hold a copy of per-frame AWB values","In-Reply-To":"<20251015012251.17508-20-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 15 Oct 2025 02:22:31 +0100\")","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-20-bryan.odonoghue@linaro.org>","Date":"Thu, 16 Oct 2025 11:14:51 +0200","Message-ID":"<85ecr3fbsk.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"9wPDpFH-w5CvcoT_L9l-YTYhT8NwMBIoLL24LyaP8v4_1760606094","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]