[{"id":36303,"web_url":"https://patchwork.libcamera.org/comment/36303/","msgid":"<85ldlbfc3c.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-10-16T09:08:23","subject":"Re: [PATCH v3 18/39] libcamera: software_isp: debayer: Extend\n\tDebayerParams struct to hold a copy of per-frame CCM values","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Bryan,\n\nsee\nhttps://lists.libcamera.org/pipermail/libcamera-devel/2025-June/050886.html\n\nBryan O'Donoghue writes:\n\n> Add an element to the DebayerParams structure to capture the calculated\n> CCM. This allows us to pass the CCM into the eGL Debayer shader later on.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index 217cd5d9..56803195 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -13,6 +13,8 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/matrix.h\"\n> +\n> namespace libcamera {\n> \n> struct DebayerParams {\n> @@ -49,6 +51,11 @@ struct DebayerParams {\n> \tCcmLookupTable greenCcm;\n> \tCcmLookupTable blueCcm;\n> \tLookupTable gammaLut;\n> +\n> +\t/*\n> +\t * Per frame CCM values as calcualted by the IPA\n> +\t */\n> +\tMatrix ccm;\n> };\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D4C3BE080\n\tfor ;\n\tThu, 16 Oct 2025 09:08:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EB126066A;\n\tThu, 16 Oct 2025 11:08:33 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EDC9600CC\n\tfor ;\n\tThu, 16 Oct 2025 11:08:31 +0200 (CEST)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-404-dqL8ESbuMJKoPVSHLNBKaw-1; Thu, 16 Oct 2025 05:08:27 -0400","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-3f3c118cbb3so451095f8f.3\n\tfor ;\n\tThu, 16 Oct 2025 02:08:26 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-426ce5e10e8sm33416796f8f.39.2025.10.16.02.08.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Oct 2025 02:08:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"W0KGCW/0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1760605710;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=t2RUk9rLrxLaBkh2gkpcFYSzTJAZ+7eyM6lN08pCiDs=;\n\tb=W0KGCW/0P1RMVwdbue0v5Z57Wfrz4gpCzmTg/nohuyDWrTftNOIPBVk47srIWh8mwXDK87\n\tT4B5OAk4yAklMwquzXn/1u5wFTa831zSw/u49zDkBtYofkx+Dgp3NInsjoHeeYqPh2LXax\n\tQZE3VpuLaZvJmBFmCxv7GE8TxMJ9mxw=","X-MC-Unique":"dqL8ESbuMJKoPVSHLNBKaw-1","X-Mimecast-MFC-AGG-ID":"dqL8ESbuMJKoPVSHLNBKaw_1760605706","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760605705; x=1761210505;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=t2RUk9rLrxLaBkh2gkpcFYSzTJAZ+7eyM6lN08pCiDs=;\n\tb=P2znT3yUOepdpUF0Ynl4wOh0KVcD5b4irxA6kwQRLpq7T5duUEe0o97k+KXhokAWKP\n\t9HK6XgyKtzlDzb6X5ao8uvOoy++mFAFakxFl0vJ3HlsLcgVMZ82G9En5xsLhNxBebaUL\n\tvzPZT6mUatnRTolmXvrq4fy8cSsMDaYVz7nLZq0Z0CzH5z0qIHZniym7g9xOrsx+E+P0\n\tB7Xku/3BgttaxD8wP0BL6lQFqqvRBVS/nIHbYHnyDG1XMur9BqiEjeGK5Kernrscxlke\n\tWFNeIkFRX8lhKWL9cXQzjVsFEWDnaT56wIpp+QZzzQvuTFmoAIltylwN8Q4n7ODWr+P7\n\tJwtA==","X-Gm-Message-State":"AOJu0YyTkRYsQZ7Iv/r3b7p6TCXEzzTnDyWhYVyHjyoGxI5cr65UwVHc\n\tdeVTft04geeICIidclOI0GBuN4aF1yyOCE9uzaRB1PYr9+D5s3+VeD4kFU+Mv7PSLVJE5NO6PZu\n\tDLG0JfYZdcE2gJBe7j93mI54YTYdkF6bhTkdpdRUuBV6YOPDOpUNfeZya1FEeLpHm/ELil1KK6U\n\tjzoZPN30Y=","X-Gm-Gg":"ASbGncucZJSJITj7t0tgDTYuqaylJRLOADye7E+yFYDwiJehIFO25L+Tcv1lfx+vkZ4\n\tbHJoQ74nNmy1u0Ruuea/oDS9jmH2UopGZ0hYB9RqVoe5XVdwmybo92UWPzhdt6K37t1NKRwuLrL\n\tpyIc09CDhB23iY9DjWHp0ge3QLPVmBaBG/bKz3tjgH/Pr+7MjRiC3WMcolUc064F+Deg5yHOKEE\n\t1tRsEEtljbiEuSq0LAxaToC45BmIbY4nnTuMhcUeWhkFWhRtdMZNtxDNDZdM9QgPsYGdzM/IHeX\n\t8KSBAvguICDtQj/BjoXYPaKSyXiQlLObRWRs2v3/jj/QkGEXFrQevqRbM2CiepR48ddfQghnTQJ\n\trD8n7KW/v+Gj37xgnscDtWlgptHZ+htC6lF2+1nc1D1tVjrerkHMS","X-Received":["by 2002:a05:6000:2303:b0:425:72f2:f872 with SMTP id\n\tffacd0b85a97d-4266e7dfe00mr20859832f8f.31.1760605705481; \n\tThu, 16 Oct 2025 02:08:25 -0700 (PDT)","by 2002:a05:6000:2303:b0:425:72f2:f872 with SMTP id\n\tffacd0b85a97d-4266e7dfe00mr20859812f8f.31.1760605705088; \n\tThu, 16 Oct 2025 02:08:25 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHRkIGZLadsu9fHKYt+gMVCTXhcyWYOmUWnPdfBEu2t2UBOwrSJ2WgnJyPXVLp/McgkGxO2Nw==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, hdegoede@redhat.com,\n\tbod.linux@nxsw.ie","Subject":"Re: [PATCH v3 18/39] libcamera: software_isp: debayer: Extend\n\tDebayerParams struct to hold a copy of per-frame CCM values","In-Reply-To":"<20251015012251.17508-19-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 15 Oct 2025 02:22:30 +0100\")","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-19-bryan.odonoghue@linaro.org>","Date":"Thu, 16 Oct 2025 11:08:23 +0200","Message-ID":"<85ldlbfc3c.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"h6Z8mhUVqlPS3EgWKAlbSsLGKPTHOEIQTJGxiMkCZTA_1760605706","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]