[{"id":36271,"web_url":"https://patchwork.libcamera.org/comment/36271/","msgid":"<176056730035.162040.6710656194522039750@ping.linuxembedded.co.uk>","date":"2025-10-15T22:28:20","subject":"Re: [PATCH v3 17/39] libcamera: software_isp: debayer: Make the\n\tdebayer_ object of type class Debayer not DebayerCpu","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-10-15 02:22:29)\n> Make the type of object Debayer not DebayerCpu thus allowing us to assign\n> the object to either DebayerCpu or DebayerEGL.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/software_isp/software_isp.h | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n> index 78624659..ad89c9b3 100644\n> --- a/include/libcamera/internal/software_isp/software_isp.h\n> +++ b/include/libcamera/internal/software_isp/software_isp.h\n> @@ -37,7 +37,7 @@\n> \n> namespace libcamera {\n> \n> -class DebayerCpu;\n> +class Debayer;\n> class FrameBuffer;\n> class PixelFormat;\n> class Stream;\n> @@ -94,8 +94,7 @@ private:\n> void statsReady(uint32_t frame, uint32_t bufferId);\n> void inputReady(FrameBuffer *input);\n> void outputReady(FrameBuffer *output);\n> -\n> - std::unique_ptr debayer_;\n> + std::unique_ptr debayer_;\n> Thread ispWorkerThread_;\n> SharedMemObject sharedParams_;\n> DebayerParams debayerParams_;\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D828C3259\n\tfor ;\n\tWed, 15 Oct 2025 22:28:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C15DC60635;\n\tThu, 16 Oct 2025 00:28:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5199F605F3\n\tfor ;\n\tThu, 16 Oct 2025 00:28:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1092558;\n\tThu, 16 Oct 2025 00:26:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Pl/6t86p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760567204;\n\tbh=FbcHioYmbgSkiLnFMYQfegP4EkPC2CLYqIZvMTqutCo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Pl/6t86ptOYD5sqga20IMhM/iU0SNNe2i7aD1GnVEut0gipSZO/rC07TpEZwByZJx\n\tp/EpcuJTWvm/X/74hSSZX3l3TlHOrt/Hbgzp5LuEsmJe/bnbOW7xYtxlZlB+vv7Yp3\n\t4wslnCFoMBgXYLsGx/BQNXonUCXiBgxf1C1Ta/sc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251015012251.17508-18-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-18-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v3 17/39] libcamera: software_isp: debayer: Make the\n\tdebayer_ object of type class Debayer not DebayerCpu","From":"Kieran Bingham ","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 15 Oct 2025 23:28:20 +0100","Message-ID":"<176056730035.162040.6710656194522039750@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36301,"web_url":"https://patchwork.libcamera.org/comment/36301/","msgid":"<85qzv3fc8l.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-10-16T09:05:14","subject":"Re: [PATCH v3 17/39] libcamera: software_isp: debayer: Make the\n\tdebayer_ object of type class Debayer not DebayerCpu","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Make the type of object Debayer not DebayerCpu thus allowing us to assign\n> the object to either DebayerCpu or DebayerEGL.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nLooks like my already provided tag was lost, so once again:\n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/internal/software_isp/software_isp.h | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n>\n> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\n> index 78624659..ad89c9b3 100644\n> --- a/include/libcamera/internal/software_isp/software_isp.h\n> +++ b/include/libcamera/internal/software_isp/software_isp.h\n> @@ -37,7 +37,7 @@\n> \n> namespace libcamera {\n> \n> -class DebayerCpu;\n> +class Debayer;\n> class FrameBuffer;\n> class PixelFormat;\n> class Stream;\n> @@ -94,8 +94,7 @@ private:\n> \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n> \tvoid inputReady(FrameBuffer *input);\n> \tvoid outputReady(FrameBuffer *output);\n> -\n> -\tstd::unique_ptr debayer_;\n> +\tstd::unique_ptr debayer_;\n> \tThread ispWorkerThread_;\n> \tSharedMemObject sharedParams_;\n> \tDebayerParams debayerParams_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F382C3259\n\tfor ;\n\tThu, 16 Oct 2025 09:05:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 443436066E;\n\tThu, 16 Oct 2025 11:05:22 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06B20600CC\n\tfor ;\n\tThu, 16 Oct 2025 11:05:19 +0200 (CEST)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-244-_1dEKwUyNt-VHmt1nqwSFw-1; Thu, 16 Oct 2025 05:05:17 -0400","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-470fd59d325so2498385e9.0\n\tfor ;\n\tThu, 16 Oct 2025 02:05:17 -0700 (PDT)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-426ce5e0efasm33386094f8f.41.2025.10.16.02.05.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 16 Oct 2025 02:05:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"FMaInpXp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1760605518;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=0p1ugHHRIG3jxL/pocRrOZnwX9oNqzXBK2jh23D4LA4=;\n\tb=FMaInpXpzEkV/C1nBKPh8a4/2R4wECUhePcGVhcxFk0kUDO6aWk+UbrZc7HKrctpCsgNdL\n\tNYKv4UuKgTS6OJ8Wji+VI/eF7/D/uOGH/9Qtvj0z/Ygi+MDq2C871Aux3Fmy0dNbvOGb8R\n\t9rN4OhmR9UBACA4uJUQgKa6ztPXeEtw=","X-MC-Unique":"_1dEKwUyNt-VHmt1nqwSFw-1","X-Mimecast-MFC-AGG-ID":"_1dEKwUyNt-VHmt1nqwSFw_1760605516","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760605516; x=1761210316;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=0p1ugHHRIG3jxL/pocRrOZnwX9oNqzXBK2jh23D4LA4=;\n\tb=fdmWGBaQr6DQ7J5JZLof0ipsxnKS51DSGPf1qdxhVPxn4q+DhRB5vmX6RchVQ+ulyE\n\tXrQxlzkxQJayJyeXjMmkUx6rTlell4l6odbIG8UQOAKgHeOGLjGE4M2TWrFjnE9Fe/iP\n\tLBBmkGS/dHTV08ps/JDneMHtR7xyo0mai6qp7sYd+aQ//1y31hqvCctL3dsCY1xOB/40\n\tp7nPPjNByagbIBf0iLPEw2fVWz46hMR4wSRYuhPZCev7vbeRlF8HwU8Q77sJMNcybVtb\n\tF5dGp8IcQneB6lG0Jlwg/5n+rN4F6D5rIP/vZFztCRawhQzGzgp9Qo4nWK3OHJEftwfu\n\tP3OQ==","X-Gm-Message-State":"AOJu0YzyV8m15ILhvVx0sDC15faIOfBN25C2ohFuX5DYgciVjULIT8u0\n\tSKgZd/KTSDZOIY90tJ6hYv2ZbVZy2Z0AtLys2j0xpX3IIvNN8wnwVh/Rq/r2gYgA1m+4f2DlW1A\n\tawBITviiRs23BOr04aoOA2GDKNBfdmbhiYtCD1l1kOxw8cLR5EvhbzeSGGPV+V9Vbpulex37yB2\n\tZW5XHTVgg=","X-Gm-Gg":"ASbGncsWxeqHvMcb48ZdTiXmJyJW5ZOg4HTRA8tgS78sS01Y5j+5DQHAjMDd8/CSLEx\n\tTWzd2Ao/pNeM0hAsNdhB7p64t2zq3E6WAr3YOzed2Jy1Q69bEm6AhOZTwMyAB5+520t3QENBA76\n\t88a+epa1WFy4RAr6EL8gimENNY0OWvu6+SMuyPZ0ENpXkD8K70G3yG6HLvhOidZtQ3GiaO55aXp\n\tQ0NmNxVgMtGW8e+HiSzJckYy4vzSd2BxE+qj1ONKtD8TtK/V1xn6zVm2sjRCKe7PeEcHo6/NWB8\n\thOXsoe9rFx1ErmehZhEnRRAQ4JLMa/MWhF3zFg0HmkAh9Hb7BYndNSoBF18mvZjWZzJlhfHl7S+\n\tY30BiRDQfWKhbbRBoPQiSUgTczC5DLdBv9iGxxCjnOCeB2JgOFoMx","X-Received":["by 2002:a05:600c:c083:b0:46f:b43a:aef0 with SMTP id\n\t5b1f17b1804b1-46fb43aaf30mr124544515e9.41.1760605516143; \n\tThu, 16 Oct 2025 02:05:16 -0700 (PDT)","by 2002:a05:600c:c083:b0:46f:b43a:aef0 with SMTP id\n\t5b1f17b1804b1-46fb43aaf30mr124544365e9.41.1760605515729; \n\tThu, 16 Oct 2025 02:05:15 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IH9MOyYRmLKzlHlNc34wgn4LmbEJTUnJ3UZz0yOr8EbAoT2yX1ubd/P1AqMSXL48stHdgoG0g==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, hdegoede@redhat.com,\n\tbod.linux@nxsw.ie","Subject":"Re: [PATCH v3 17/39] libcamera: software_isp: debayer: Make the\n\tdebayer_ object of type class Debayer not DebayerCpu","In-Reply-To":"<20251015012251.17508-18-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 15 Oct 2025 02:22:29 +0100\")","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>\n\t<20251015012251.17508-18-bryan.odonoghue@linaro.org>","Date":"Thu, 16 Oct 2025 11:05:14 +0200","Message-ID":"<85qzv3fc8l.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"PiWPGkviau5TkRZuU6-ek4UyvBr3jvxVUm6VxDwvbxs_1760605516","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]