{"id":24660,"url":"https://patchwork.libcamera.org/api/patches/24660/?format=json","web_url":"https://patchwork.libcamera.org/patch/24660/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251015012251.17508-16-bryan.odonoghue@linaro.org>","date":"2025-10-15T01:22:27","name":"[v3,15/39] libcamera: software_isp: Start the ISP thread in configure","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f15eebb7c60746935ec55f953c786798ff77e881","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24660/mbox/","series":[{"id":5503,"url":"https://patchwork.libcamera.org/api/series/5503/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5503","date":"2025-10-15T01:22:12","name":"Add GLES 2.0 GPUISP to libcamera","version":3,"mbox":"https://patchwork.libcamera.org/series/5503/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24660/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24660/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 008AAC3331\n\tfor ;\n\tWed, 15 Oct 2025 01:23:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8141360641;\n\tWed, 15 Oct 2025 03:23:21 +0200 (CEST)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D2F160617\n\tfor ;\n\tWed, 15 Oct 2025 03:23:11 +0200 (CEST)","by mail-ej1-x632.google.com with SMTP id\n\ta640c23a62f3a-b3e9d633b78so100388166b.1\n\tfor ;\n\tTue, 14 Oct 2025 18:23:11 -0700 (PDT)","from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.23.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:23:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"yM7UjF9D\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491390; x=1761096190;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=r1DkagOG3edPpf2lxaQBxOkTweGIjpitNTyvx3GYFSQ=;\n\tb=yM7UjF9DTD+RF0johEItrOgsYvah8Q6bWXA2Ud7ToD+FLqy6/aFUF1yBQhs8EcI+jN\n\tGJpA/rha4c5iw16teJpU0vNiX2Ac1WXc9u4/pwH2PmJBm8Pft3+hMBpkAp8Hb4tkZQxP\n\tIQ3oUYRb0s0IcctZOD69N+FAmtbv1F9vbtYL4VViH07uCw4EoOmH6Yc4Qe8yUkNjTIsV\n\tzdjkyZGiYWFUXSQrPn6gz348Y+x1B2oY28ugDF+YRK1kE8C14AOJtz+Mt1MarNLaJPeb\n\tTme3CQIhE5O6IWkl9sQfGY7uOix8D6Z7B9jBHaRCgLPXCDpBfF0mgYWOVwPSk7JFZEkg\n\t+L6Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491390; x=1761096190;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=r1DkagOG3edPpf2lxaQBxOkTweGIjpitNTyvx3GYFSQ=;\n\tb=CRd1urECmVUaECEcw+xcrYOlMuhkQQbShnw34ztaJ38WxE76cKktSLIruS3ynfif9k\n\tUyXhgopRpdvN35bsnU0iNTGDyD4JvOpEK5wqUuS+78eGKkVIUsVEMcajc8WT2G46Fz+9\n\tQfPNNW/lp1H+/9vgjF9D5lckHD6/W7Vz/c/Sy+F/49oA5WuBDgFWBoduYaUwOcEGttt2\n\tuqugm0Vp4Mxktrvpd67FZNWvHXzXk4LWOsOXO+O0NYLczEi7Zet4bDaBHs/4k/Chyx9J\n\thjeRsfXYP++lB303zo5e+fLlogbRsin7sBsXuOWaM8HawrRDFHq9HyrKBToL67mK2Z9X\n\t9gyg==","X-Gm-Message-State":"AOJu0YzDPz4mvtdTYKqJVtyrwqLnSQKXb2UcrP797/kex02loM/qCePs\n\tJ/j9SNI3OHd0dA4baLxGH1PK7dO9/eFqSrh2LIfSAVFIDaYgQrLxha5OeWdYwVS8YqP5YcEhYlB\n\ts1ki+","X-Gm-Gg":"ASbGnctl1uUSBQtyJ/HId+4ERgvaXZtxHoCXl/PZS+nXt/HwTYr1pa44M9T7/yq0fN0\n\tHOmX1NQWmGp/OH/D+w0dIcBQaKGNWdNiqP2LNJLGmAm5MFbDykucjbRiXNDZXTCFGeaMnvMVU28\n\tIOkD8zv9tEz9ut/lPFmSAa5FxrS/cQuP9lsKvNrzoQV8f3BJ6yQLtABXJ20hJVwK278N8p+Qj6N\n\tv0pWIN8+t5oDiyiKt+iVvcQqno/BJu9H9PIepKy8Fhk6/Sy7GzfZbGyngXcFKjoioq4506ZW0ju\n\tMQCObMZ5CFsesvN2VScEzXnzlolX2ivxZPWy+OLqaE/ley+kHXk1anWA1JGSRy8HFExjCk2fus1\n\tQmjjzmRThOi/QNms9iGPO0yYMVAsFXwXE2A4WWWJJYXc40GWjabt6NX34sqUFXuSLnica7X9Izv\n\tfn/Ni5wV4kGH/Qgar9amI/WwMiMVrnV2UvP7/yd1e2","X-Google-Smtp-Source":"AGHT+IEBppBTA4ym/A77919M0hmOYL6U1wW6yhW/HlNxg+WCs4hCTgHC/l7IGzUL320BcnjGykI6WA==","X-Received":"by 2002:a17:907:7213:b0:b38:49a6:583a with SMTP id\n\ta640c23a62f3a-b50bf2bcc2amr2702182766b.23.1760491390314; \n\tTue, 14 Oct 2025 18:23:10 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie, Robert Mader ","Subject":"[PATCH v3 15/39] libcamera: software_isp: Start the ISP thread in\n\tconfigure","Date":"Wed, 15 Oct 2025 02:22:27 +0100","Message-ID":"<20251015012251.17508-16-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL is not thread-safe and in fact associates invisible handles with the\nthreadid of the calling context.\n\nAs a result we need to make Deabyer::configure() and Debayer::process() in SoftISP execute on\nthe same thread.\n\nWhen we call Debayer::configure() in the egl class this will setup and egl context\nfor us which is associated with the calling thread context. Hence when\nDebayer::process(); runs it must run in the same thread as\nDebayer::configure() or the hidden Gegl context handles will not point\nto the same place.\n\nMove start thread into configure() as a first step towards this.\n\nCo-developed-by: Robert Mader \nSigned-off-by: Robert Mader \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 6f1f88fe..500858ab 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -264,6 +264,8 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tispWorkerThread_.start();\n+\n \treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n }\n \n@@ -345,7 +347,6 @@ int SoftwareIsp::start()\n \tif (ret)\n \t\treturn ret;\n \n-\tispWorkerThread_.start();\n \treturn 0;\n }\n \n","prefixes":["v3","15/39"]}