{"id":24650,"url":"https://patchwork.libcamera.org/api/patches/24650/?format=json","web_url":"https://patchwork.libcamera.org/patch/24650/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251015012251.17508-6-bryan.odonoghue@linaro.org>","date":"2025-10-15T01:22:17","name":"[v3,05/39] libcamera: swstats_cpu: Drop patternSize_ documentation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"59741e75c523b0031de9169f512623c1b3987ba1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24650/mbox/","series":[{"id":5503,"url":"https://patchwork.libcamera.org/api/series/5503/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5503","date":"2025-10-15T01:22:12","name":"Add GLES 2.0 GPUISP to libcamera","version":3,"mbox":"https://patchwork.libcamera.org/series/5503/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24650/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24650/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D74F6BF415\n\tfor ;\n\tWed, 15 Oct 2025 01:23:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6236D60624;\n\tWed, 15 Oct 2025 03:23:06 +0200 (CEST)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n\t[IPv6:2a00:1450:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 684AE60618\n\tfor ;\n\tWed, 15 Oct 2025 03:23:00 +0200 (CEST)","by mail-ej1-x634.google.com with SMTP id\n\ta640c23a62f3a-b463f986f80so340232266b.2\n\tfor ;\n\tTue, 14 Oct 2025 18:23:00 -0700 (PDT)","from inspiron14p-linux.nxsw.local (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b5ccd7b202dsm98348466b.82.2025.10.14.18.22.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Oct 2025 18:22:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"GubyPR05\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1760491380; x=1761096180;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=6QhKm2HbNzOXoZbqp3cnze1QGBGffOYanYP1Eb/65tU=;\n\tb=GubyPR05EA4lthA4rapZ93Fzk1C0r1/GKCajHXePo3WlY3JZz7pLe/OmdwcPnI1AU3\n\t3ZsfFvbNHiJ1D6wZlao+Q0XNYiNJEE3pNtIwDEMu9pXhPcRQ7SNLbcvqqE7DGdSUyjhO\n\tIUMNeqSNqsTu03WzG4uCqxy3oJR5+6Gd79Kd9OMdOvdI+Rh+20tY4+ehS30kG66itTE+\n\tyebxvAwTfjcIyEa5Vlga1BH40tV6lXez8lbnI8FTJZWRyHCp3nxF5Bv27iuWRx+I1HuJ\n\t9B6Slu/VE6/YAG+UQuHt9XFpWDFHC3qDXJfJardx1UrmDPksp8on0EcGGhI3j8vImvgb\n\tMswQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760491380; x=1761096180;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=6QhKm2HbNzOXoZbqp3cnze1QGBGffOYanYP1Eb/65tU=;\n\tb=NqOnR8UjVXovhIPSP7fHzZi/v5dc9Jabd7cqc3LhlFvVRbJhyCFiX1rBA9BCV7UE02\n\tZ+h2BpMlKv+/kcitR4zaB0G0VStQGspNYwBG0UPm1DZFLwuKqcznPZAEAHWLaqGDG3HK\n\t3xIPuw46chC6KBZWrF/5oq+05nyidqjnjdOCctaNIJpfB5jeyn5mNdLcKEiuW241lYUf\n\tZl9vMkFAbG+WUD4QDhEnPHv9vmDoOPBaQYVw2P8970R0eeAFnn+W4ut3rdqLoyFVBkYF\n\tnjT9aX9BQJ9rJOeJEMOPfTuI6NSeO6azjjz3yss/qiiMoZIAGkpZ8RjrOGfk+cDiu1OB\n\trkGA==","X-Gm-Message-State":"AOJu0YxBM6FjHTZQ87G1JQtamLudW3hGZvgNgJvgvwGNvexG7xfbYcmW\n\tRydAgzlsuwS4XJgkpmcUOkPNgNEizq8oYcgmb+r+9FIm/Kq2ESpe4IBzXlEuTqjv0z0As5AWyM1\n\tg95or","X-Gm-Gg":"ASbGncv7AX/Zg3HOTAKe7AuaP2JoMYKZRVFFW2ASuO1Dp1k+Y5oOb3Qaye6Ldih6bqc\n\tBNIfGI8eh9gPbjkTQSYWaMvPA5PgpaxLSXQDnSFjV7FJhJosSTl0z++do+YjCiwQsQGHGYvNI8t\n\tAWZ1t+3wrXpmSGhGW5IeXNXrqpS13xPYjY/Owso5m7fvaWdHfmtVcZEPWxQWPns7wzhgJuA9jwg\n\tSD0lLeR07oCUNlPbJ+ekY9ueBkBq/uNYqymnZc8PFhzb/Fm05Vv4L2hloWftREYXa3iRlWUCYos\n\tbGUkRmLnf1vbr19xDVwQDYmz06HQYX1HnsBbJqRhmuRjKCYWByReuPw4iVoxMkS9ybZi60svR57\n\tPp1Ddfk4xkqhaEjAOGkMVHuZd5X9NZVNlY5CSI0EEQ58/RWbK8wjqVctiCpkE/ntKxeN+2LUHSw\n\tu4nXVToZQXKlGz8tEICmFZMcoFkFpXjw==","X-Google-Smtp-Source":"AGHT+IFS120a3oecR3DnXjXtC/4G2k1I4w8Ht5m/mUsjhFMwk29YYLs2dy/QJFz6v6xyJ/LwhcH2jA==","X-Received":"by 2002:a17:907:72c6:b0:b45:b078:c52d with SMTP id\n\ta640c23a62f3a-b50abaa439emr2803285066b.35.1760491379668; \n\tTue, 14 Oct 2025 18:22:59 -0700 (PDT)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie, Kieran Bingham ","Subject":"[PATCH v3 05/39] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","Date":"Wed, 15 Oct 2025 02:22:17 +0100","Message-ID":"<20251015012251.17508-6-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>","References":"<20251015012251.17508-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hans de Goede \n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Hans de Goede \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 9c03338a..1b33ffa7 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -133,13 +135,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n","prefixes":["v3","05/39"]}