{"id":24643,"url":"https://patchwork.libcamera.org/api/patches/24643/?format=json","web_url":"https://patchwork.libcamera.org/patch/24643/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251014142427.3107490-4-stefan.klug@ideasonboard.com>","date":"2025-10-14T14:24:18","name":"[v1,3/4] ipa: libipa: pwl: Add construction from initializer_list","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e2beec370053c093b8723d9e2081c9d352adcf13","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24643/mbox/","series":[{"id":5502,"url":"https://patchwork.libcamera.org/api/series/5502/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5502","date":"2025-10-14T14:24:15","name":"libipa: agc: Fix constraints yTarget handling and add PWL support","version":1,"mbox":"https://patchwork.libcamera.org/series/5502/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24643/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24643/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C476BE080\n\tfor ;\n\tTue, 14 Oct 2025 14:24:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0EA9060605;\n\tTue, 14 Oct 2025 16:24:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5101660609\n\tfor ;\n\tTue, 14 Oct 2025 16:24:40 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D2241104D; \n\tTue, 14 Oct 2025 16:23:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"X9MSVqqc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760451781;\n\tbh=lgIAzDG0NRsV3A0ed7UTU2hFjwNgg3Gr1KofJ+C/whw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=X9MSVqqcsPcPGiniOpk5MpIu2P0/tSVuwamwRl2CvVUxaZUKzyqHButqBhjw4rBQP\n\t201v7tZyTKgRI4HlSF9TkFABCsHr0otHqjFp/xLemIZtI8MjiWtTWuhDrj6TnLF/u+\n\t1aIXNwSJaV7i9fjdUwiPmIGPr89EIzxND3tUcZow=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 3/4] ipa: libipa: pwl: Add construction from\n\tinitializer_list","Date":"Tue, 14 Oct 2025 16:24:18 +0200","Message-ID":"<20251014142427.3107490-4-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251014142427.3107490-1-stefan.klug@ideasonboard.com>","References":"<20251014142427.3107490-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In the tuning files it is possible to construct the PWL from a linear\nlist of numbers. Add a initializer_list based constructor to replicate\nsimilar style in C++ code. An initializer_list is preferred to a Span\nbased constructor because the Span makes the static construction\ncumbersome ( {{{ 1.0, 2.0 }}} vs { 1.0, 2.0 } ) and initialization is\nthe only use case at the moment.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/libipa/pwl.cpp | 19 +++++++++++++++++++\n src/ipa/libipa/pwl.h | 1 +\n 2 files changed, 20 insertions(+)","diff":"diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\nindex 1858ab37b101..501ac79ea8b5 100644\n--- a/src/ipa/libipa/pwl.cpp\n+++ b/src/ipa/libipa/pwl.cpp\n@@ -122,6 +122,25 @@ Pwl::Pwl(std::vector &&points)\n {\n }\n \n+/**\n+ * \\brief Construct a piecewise linear function from a initializer list\n+ * \\param[in] data initializer list of doubles\n+ *\n+ * This constructor takes a even number of doubles and treats them as\n+ * x0,y0,x1,y1,...,xn,yn coordinates for the PWL.\n+ */\n+Pwl::Pwl(std::initializer_list data)\n+{\n+\tASSERT((data.size() % 2) == 0);\n+\n+\tauto iter = data.begin();\n+\twhile (iter != data.end()) {\n+\t\tdouble x = *iter++;\n+\t\tdouble y = *iter++;\n+\t\tappend(x, y);\n+\t}\n+}\n+\n /**\n * \\brief Append a point to the end of the piecewise linear function\n * \\param[in] x x-coordinate of the point to add to the piecewise linear function\ndiff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\nindex add20b5867af..b82b17317a5e 100644\n--- a/src/ipa/libipa/pwl.h\n+++ b/src/ipa/libipa/pwl.h\n@@ -45,6 +45,7 @@ public:\n \tPwl();\n \tPwl(const std::vector &points);\n \tPwl(std::vector &&points);\n+\tPwl(std::initializer_list data);\n \n \tvoid append(double x, double y, double eps = 1e-6);\n \n","prefixes":["v1","3/4"]}