[{"id":36250,"web_url":"https://patchwork.libcamera.org/comment/36250/","msgid":"","date":"2025-10-14T14:38:27","subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 14. 16:24 keltezéssel, Stefan Klug írta:\n> Add a swap() function to easily swap the contents of two PWLs.\n> \n> Signed-off-by: Stefan Klug \n> ---\n\nIt looks OK, although I believe all use-cases in this patch series\ncan be replaced with the already generated move assignment operator.\nMaybe I am missing some other reason?\n\n\nBut if it is need:\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/libipa/pwl.cpp | 6 ++++++\n> src/ipa/libipa/pwl.h | 1 +\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> index 69a9334112e8..1858ab37b101 100644\n> --- a/src/ipa/libipa/pwl.cpp\n> +++ b/src/ipa/libipa/pwl.cpp\n> @@ -169,6 +169,12 @@ void Pwl::prepend(double x, double y, const double eps)\n> * \\return The number of points in the piecewise linear function\n> */\n> \n> +/**\n> + * \\fn Pwl::swap(Pwl &other)\n> + * \\brief Swap the contents with another PWL\n> + * \\param[in] other The PWL to swap with\n> + */\n> +\n> /**\n> * \\brief Get the domain of the piecewise linear function\n> * \\return An interval representing the domain\n> diff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\n> index c1496c300ee0..add20b5867af 100644\n> --- a/src/ipa/libipa/pwl.h\n> +++ b/src/ipa/libipa/pwl.h\n> @@ -51,6 +51,7 @@ public:\n> \tbool empty() const { return points_.empty(); }\n> \tvoid clear() { points_.clear(); }\n> \tsize_t size() const { return points_.size(); }\n> +\tvoid swap(Pwl &other) { points_.swap(other.points_); }\n> \n> \tInterval domain() const;\n> \tInterval range() const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2ACE5BF415\n\tfor ;\n\tTue, 14 Oct 2025 14:38:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42AA760605;\n\tTue, 14 Oct 2025 16:38:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40A33605F3\n\tfor ;\n\tTue, 14 Oct 2025 16:38:31 +0200 (CEST)","from [192.168.33.20] (185.182.214.105.nat.pool.zt.hu\n\t[185.182.214.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3AB4741;\n\tTue, 14 Oct 2025 16:36:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZTl+YLMH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760452612;\n\tbh=FLT15sNel2XH3rvy/mgpAyI+BBpBVgW0Gs61FZjouSs=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ZTl+YLMH4dSDoZTCcviTo826O12VEG3NtdIxvk9+ImXJDmnzKyg9loc0nETwGAGYl\n\tn+VpNI+6UNrFiAXV6HIul2Bb4wPRZ5mjY5v9lMgFwQikRLezlpTfXBq61pnhlVPETv\n\tHfTxx21kTH2XkrGTB6mxRCyteiwBaYeba3rsmPqE=","Message-ID":"","Date":"Tue, 14 Oct 2025 16:38:27 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014142427.3107490-1-stefan.klug@ideasonboard.com>\n\t<20251014142427.3107490-2-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251014142427.3107490-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36581,"web_url":"https://patchwork.libcamera.org/comment/36581/","msgid":"","date":"2025-10-31T15:30:22","subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan - thanks for the patches and fixing my mistakes :)\n\nOn 14/10/2025 15:24, Stefan Klug wrote:\n> Add a swap() function to easily swap the contents of two PWLs.\n> \n> Signed-off-by: Stefan Klug \n> ---\n\nReviewed-by: Daniel Scally \n\n> src/ipa/libipa/pwl.cpp | 6 ++++++\n> src/ipa/libipa/pwl.h | 1 +\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> index 69a9334112e8..1858ab37b101 100644\n> --- a/src/ipa/libipa/pwl.cpp\n> +++ b/src/ipa/libipa/pwl.cpp\n> @@ -169,6 +169,12 @@ void Pwl::prepend(double x, double y, const double eps)\n> * \\return The number of points in the piecewise linear function\n> */\n> \n> +/**\n> + * \\fn Pwl::swap(Pwl &other)\n> + * \\brief Swap the contents with another PWL\n> + * \\param[in] other The PWL to swap with\n> + */\n> +\n> /**\n> * \\brief Get the domain of the piecewise linear function\n> * \\return An interval representing the domain\n> diff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\n> index c1496c300ee0..add20b5867af 100644\n> --- a/src/ipa/libipa/pwl.h\n> +++ b/src/ipa/libipa/pwl.h\n> @@ -51,6 +51,7 @@ public:\n> \tbool empty() const { return points_.empty(); }\n> \tvoid clear() { points_.clear(); }\n> \tsize_t size() const { return points_.size(); }\n> +\tvoid swap(Pwl &other) { points_.swap(other.points_); }\n> \n> \tInterval domain() const;\n> \tInterval range() const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F62ABE080\n\tfor ;\n\tFri, 31 Oct 2025 15:30:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB46C609E0;\n\tFri, 31 Oct 2025 16:30:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BA9B60947\n\tfor ;\n\tFri, 31 Oct 2025 16:30:25 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6F1D61690;\n\tFri, 31 Oct 2025 16:28:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZJ/Cgk4i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761924514;\n\tbh=sEz8J6UOLl7HDeQgHydKTaKZBktt7ToxqafVjxpF9t4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ZJ/Cgk4iaGP6Wx6/BDW3ZnJ91Pk+qO7RX7SEkm3YWqpjN6yxXk7osQWasEG0i1OTn\n\tWQFlnjvXXbhDKZ4WSR89xzCKeb6Tg7sLdm96THG5ai2oZmsPCeI6DoPS4aIpJFr367\n\twoQhzm00WdlYDUbe3K07nkbXopACje010mWe55Fw=","Message-ID":"","Date":"Fri, 31 Oct 2025 15:30:22 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014142427.3107490-1-stefan.klug@ideasonboard.com>\n\t<20251014142427.3107490-2-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","In-Reply-To":"<20251014142427.3107490-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36632,"web_url":"https://patchwork.libcamera.org/comment/36632/","msgid":"<20251102220626.GN27255@pendragon.ideasonboard.com>","date":"2025-11-02T22:06:26","subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Oct 14, 2025 at 04:38:27PM +0200, Barnabás Pőcze wrote:\n> 2025. 10. 14. 16:24 keltezéssel, Stefan Klug írta:\n> > Add a swap() function to easily swap the contents of two PWLs.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> \n> It looks OK, although I believe all use-cases in this patch series\n> can be replaced with the already generated move assignment operator.\n> Maybe I am missing some other reason?\n\nWith std::swap() then I suppose ? I agree, that could be better.\n\n> But if it is need:\n> \n> Reviewed-by: Barnabás Pőcze \n> \n> > src/ipa/libipa/pwl.cpp | 6 ++++++\n> > src/ipa/libipa/pwl.h | 1 +\n> > 2 files changed, 7 insertions(+)\n> > \n> > diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> > index 69a9334112e8..1858ab37b101 100644\n> > --- a/src/ipa/libipa/pwl.cpp\n> > +++ b/src/ipa/libipa/pwl.cpp\n> > @@ -169,6 +169,12 @@ void Pwl::prepend(double x, double y, const double eps)\n> > * \\return The number of points in the piecewise linear function\n> > */\n> > \n> > +/**\n> > + * \\fn Pwl::swap(Pwl &other)\n> > + * \\brief Swap the contents with another PWL\n> > + * \\param[in] other The PWL to swap with\n> > + */\n> > +\n> > /**\n> > * \\brief Get the domain of the piecewise linear function\n> > * \\return An interval representing the domain\n> > diff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\n> > index c1496c300ee0..add20b5867af 100644\n> > --- a/src/ipa/libipa/pwl.h\n> > +++ b/src/ipa/libipa/pwl.h\n> > @@ -51,6 +51,7 @@ public:\n> > \tbool empty() const { return points_.empty(); }\n> > \tvoid clear() { points_.clear(); }\n> > \tsize_t size() const { return points_.size(); }\n> > +\tvoid swap(Pwl &other) { points_.swap(other.points_); }\n> > \n> > \tInterval domain() const;\n> > \tInterval range() const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93479BDE4C\n\tfor ;\n\tSun, 2 Nov 2025 22:06:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEA3E6096B;\n\tSun, 2 Nov 2025 23:06:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7B65606E6\n\tfor ;\n\tSun, 2 Nov 2025 23:06:40 +0100 (CET)","from pendragon.ideasonboard.com (82-203-160-149.bb.dnainternet.fi\n\t[82.203.160.149])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id EEB7C8D4;\n\tSun, 2 Nov 2025 23:04:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Vayq3weX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762121088;\n\tbh=qyb9cAdHoc7g8cvPpfjkk7JRGZlte8K8SVIhiWL50qg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Vayq3weXWgoEGWVAy6mbytOxgeKmq7mTPIjMl4190+Fd3f0Qkr55QxvIRCcjRz2sx\n\tRWeVhWbUIwar3HTEsrrvZYOYnifevz0JE+6IivHkIIPJMtrkb+KAPgKdlco3oCAQhI\n\tiuab9Xv3RASi8JxkpjVYHmxfJDDScEx8OFIlqYsQ=","Date":"Mon, 3 Nov 2025 00:06:26 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","Message-ID":"<20251102220626.GN27255@pendragon.ideasonboard.com>","References":"<20251014142427.3107490-1-stefan.klug@ideasonboard.com>\n\t<20251014142427.3107490-2-stefan.klug@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36647,"web_url":"https://patchwork.libcamera.org/comment/36647/","msgid":"<4e965f06-42c2-426c-8574-a31c3ee38216@ideasonboard.com>","date":"2025-11-03T11:28:52","subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 11. 02. 23:06 keltezéssel, Laurent Pinchart írta:\n> On Tue, Oct 14, 2025 at 04:38:27PM +0200, Barnabás Pőcze wrote:\n>> 2025. 10. 14. 16:24 keltezéssel, Stefan Klug írta:\n>>> Add a swap() function to easily swap the contents of two PWLs.\n>>>\n>>> Signed-off-by: Stefan Klug \n>>> ---\n>>\n>> It looks OK, although I believe all use-cases in this patch series\n>> can be replaced with the already generated move assignment operator.\n>> Maybe I am missing some other reason?\n> \n> With std::swap() then I suppose ? I agree, that could be better.\n\nI don't think std::swap() is needed. Just\n\n someMember_ = std::move(someLocal);\n\nis enough to cover all use cases as far as I can see.\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n>> But if it is need:\n>>\n>> Reviewed-by: Barnabás Pőcze \n>>\n>>> src/ipa/libipa/pwl.cpp | 6 ++++++\n>>> src/ipa/libipa/pwl.h | 1 +\n>>> 2 files changed, 7 insertions(+)\n>>>\n>>> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n>>> index 69a9334112e8..1858ab37b101 100644\n>>> --- a/src/ipa/libipa/pwl.cpp\n>>> +++ b/src/ipa/libipa/pwl.cpp\n>>> @@ -169,6 +169,12 @@ void Pwl::prepend(double x, double y, const double eps)\n>>> * \\return The number of points in the piecewise linear function\n>>> */\n>>> \n>>> +/**\n>>> + * \\fn Pwl::swap(Pwl &other)\n>>> + * \\brief Swap the contents with another PWL\n>>> + * \\param[in] other The PWL to swap with\n>>> + */\n>>> +\n>>> /**\n>>> * \\brief Get the domain of the piecewise linear function\n>>> * \\return An interval representing the domain\n>>> diff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\n>>> index c1496c300ee0..add20b5867af 100644\n>>> --- a/src/ipa/libipa/pwl.h\n>>> +++ b/src/ipa/libipa/pwl.h\n>>> @@ -51,6 +51,7 @@ public:\n>>> \tbool empty() const { return points_.empty(); }\n>>> \tvoid clear() { points_.clear(); }\n>>> \tsize_t size() const { return points_.size(); }\n>>> +\tvoid swap(Pwl &other) { points_.swap(other.points_); }\n>>> \n>>> \tInterval domain() const;\n>>> \tInterval range() const;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 604B0BDE4C\n\tfor ;\n\tMon, 3 Nov 2025 11:28:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C497D60A80;\n\tMon, 3 Nov 2025 12:28:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C59D606A0\n\tfor ;\n\tMon, 3 Nov 2025 12:28:57 +0100 (CET)","from [192.168.33.39] (185.221.140.239.nat.pool.zt.hu\n\t[185.221.140.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBFAD99F;\n\tMon, 3 Nov 2025 12:27:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zle1GUXv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762169224;\n\tbh=DszNNhXRkgmnG3qofL2KEHzQ6JHFgYzt0Ctv1tTFun4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Zle1GUXv1HQ1KBnbE5UOENOjnTiVCLbsbjZeuJE9aTbwtOfxGzu+mLcZirMqF2CVs\n\t0TymMpJDETUI4eDSFJFuAZNOSZWM0zygSYuMpBN/aLs6BLh1NAC4ggraGkF4sZjIdW\n\tbB7ZCDoSxpf/sF6T4iJ/XGr2ApDN5oCgO3vtai7w=","Message-ID":"<4e965f06-42c2-426c-8574-a31c3ee38216@ideasonboard.com>","Date":"Mon, 3 Nov 2025 12:28:52 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 1/4] ipa: libipa: pwl: Add swap() function","To":"Laurent Pinchart ","Cc":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014142427.3107490-1-stefan.klug@ideasonboard.com>\n\t<20251014142427.3107490-2-stefan.klug@ideasonboard.com>\n\t\n\t<20251102220626.GN27255@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251102220626.GN27255@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]