[{"id":36451,"web_url":"https://patchwork.libcamera.org/comment/36451/","msgid":"","date":"2025-10-24T17:09:42","subject":"Re: [PATCH v1 11/12] libcamera: control_ids: Introduce\n\tLensShadingEnable","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> Introduce a control to enable and disable LSC and replace the draft \n> android control. Signed-off-by: Jacopo Mondi \n> Signed-off-by: Stefan Klug --- \n> src/android/camera_capabilities.cpp | 4 ++-- \n> src/libcamera/control_ids_core.yaml | 6 ++++++ \n> src/libcamera/control_ids_draft.yaml | 14 -------------- 3 files \n> changed, 8 insertions(+), 16 deletions(-) diff --git \n> a/src/android/camera_capabilities.cpp \n> b/src/android/camera_capabilities.cpp index b161bc6b3ed6..6fbd83695dfc \n> 100644 --- a/src/android/camera_capabilities.cpp +++ \n> b/src/android/camera_capabilities.cpp @@ -1223,10 +1223,10 @@ int \n> CameraCapabilities::initializeStaticMetadata() { std::vector \n> data; data.reserve(2); - const auto &infoMap = \n> controlsInfo.find(&controls::draft::LensShadingMapMode); + const auto \n> &infoMap = controlsInfo.find(&controls::LensShadingEnable); if \n> (infoMap != controlsInfo.end()) { for (const auto &value : \n> infoMap->second.values()) - data.push_back(value.get()); + \n> data.push_back(value.get()); } else { \n> data.push_back(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE_OFF); } diff \n> --git a/src/libcamera/control_ids_core.yaml \n> b/src/libcamera/control_ids_core.yaml index f781865859ac..9244b7eddb77 \n> 100644 --- a/src/libcamera/control_ids_core.yaml +++ \n> b/src/libcamera/control_ids_core.yaml @@ -1346,4 +1346,10 @@ controls: \n> reduces the WdrExposureValue until the amount of pixels that are close \n> to saturation is lower than this value. + - LensShadingEnable: + type: \n> bool + direction: inout + description: | + Enable or disable the lens \n> shading algorithm. +\n\n naming as LensShadingCorrectionEnable .\n\n> ... diff --git a/src/libcamera/control_ids_draft.yaml \n> b/src/libcamera/control_ids_draft.yaml index \n> 03309eeac34f..14026de46ad6 100644 --- \n> a/src/libcamera/control_ids_draft.yaml +++ \n> b/src/libcamera/control_ids_draft.yaml @@ -110,20 +110,6 @@ controls: \n> row and the start of exposure of the last row. Currently identical to \n> ANDROID_SENSOR_ROLLING_SHUTTER_SKEW - - LensShadingMapMode: - type: \n> int32_t - direction: inout - description: | - Control to report if the \n> lens shading map is available. Currently - identical to \n> ANDROID_STATISTICS_LENS_SHADING_MAP_MODE. - enum: - - name: \n> LensShadingMapModeOff - value: 0 - description: No lens shading map \n> mode is available. - - name: LensShadingMapModeOn - value: 1 - \n> description: The lens shading map mode is available. - - \n> PipelineDepth: type: int32_t direction: out","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E15E9C3259\n\tfor ;\n\tFri, 24 Oct 2025 17:09:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39E6E609B6;\n\tFri, 24 Oct 2025 19:09:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3070460990\n\tfor ;\n\tFri, 24 Oct 2025 19:09:55 +0200 (CEST)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0AA2122A\n\tfor ;\n\tFri, 24 Oct 2025 19:08:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I8Sh/ihL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761325689;\n\tbh=08Jp4/PrTrEGSTy17Ai3GO+Q0SBkojB8yYWfbkAuQlA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=I8Sh/ihLWXSHvfPv515RZniBgVM5APpDy4XXU1Cc1CP3EbQHQCtCA9/rr81vaIsl/\n\tzDMYdup4DdrKHD0UhYAT9kUKyZ719VacrjOxOY3s/q9gl7FWGyAUREzhTrwMfUGQup\n\tOYvIFVl0O/XfI9BnvaLvAlcg4ps3q/1OcogzJZ34=","Content-Type":"multipart/alternative;\n\tboundary=\"------------vSEXUyRi0slLTFtt1NWZR4LI\"","Message-ID":"","Date":"Fri, 24 Oct 2025 13:09:42 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 11/12] libcamera: control_ids: Introduce\n\tLensShadingEnable","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-12-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-12-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]