{"id":24627,"url":"https://patchwork.libcamera.org/api/patches/24627/?format=json","web_url":"https://patchwork.libcamera.org/patch/24627/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251014075252.2876485-12-stefan.klug@ideasonboard.com>","date":"2025-10-14T07:52:33","name":"[v1,11/12] libcamera: control_ids: Introduce LensShadingEnable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e971d95c908f3ad9e16e00a9b70a7d5c84df4102","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24627/mbox/","series":[{"id":5498,"url":"https://patchwork.libcamera.org/api/series/5498/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5498","date":"2025-10-14T07:52:22","name":"Add resampling support for polynomial LSC data","version":1,"mbox":"https://patchwork.libcamera.org/series/5498/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24627/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24627/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2A33BF415\n\tfor ;\n\tTue, 14 Oct 2025 07:53:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6500605EA;\n\tTue, 14 Oct 2025 09:53:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5CE4605DD\n\tfor ;\n\tTue, 14 Oct 2025 09:53:31 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2712CC73;\n\tTue, 14 Oct 2025 09:51:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rNjLIFZq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760428313;\n\tbh=2Hc+TYFyl1w104gmWwZ01Zd68dWJEywjDmfnavqXN/o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rNjLIFZqm/dSwQr5v7l8DuI5Myiwu+zpuQhxwFAQTas140NCh7UergAMIfa7eJ3hF\n\tMJOyFEV2cXkQKfUakOccAA7jlTjpbqACVjqTCYLfwhRxsnckCa5tpL1aYfLey6Vg8m\n\tmJskxWNaDKWyrejWqfDifTlfNFKBm6CR3hFvlqeU=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tJacopo Mondi ","Subject":"[PATCH v1 11/12] libcamera: control_ids: Introduce LensShadingEnable","Date":"Tue, 14 Oct 2025 09:52:33 +0200","Message-ID":"<20251014075252.2876485-12-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Introduce a control to enable and disable LSC and replace the\ndraft android control.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Stefan Klug \n---\n src/android/camera_capabilities.cpp | 4 ++--\n src/libcamera/control_ids_core.yaml | 6 ++++++\n src/libcamera/control_ids_draft.yaml | 14 --------------\n 3 files changed, 8 insertions(+), 16 deletions(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex b161bc6b3ed6..6fbd83695dfc 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1223,10 +1223,10 @@ int CameraCapabilities::initializeStaticMetadata()\n \t{\n \t\tstd::vector data;\n \t\tdata.reserve(2);\n-\t\tconst auto &infoMap = controlsInfo.find(&controls::draft::LensShadingMapMode);\n+\t\tconst auto &infoMap = controlsInfo.find(&controls::LensShadingEnable);\n \t\tif (infoMap != controlsInfo.end()) {\n \t\t\tfor (const auto &value : infoMap->second.values())\n-\t\t\t\tdata.push_back(value.get());\n+\t\t\t\tdata.push_back(value.get());\n \t\t} else {\n \t\t\tdata.push_back(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE_OFF);\n \t\t}\ndiff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex f781865859ac..9244b7eddb77 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1346,4 +1346,10 @@ controls:\n reduces the WdrExposureValue until the amount of pixels that are close\n to saturation is lower than this value.\n \n+ - LensShadingEnable:\n+ type: bool\n+ direction: inout\n+ description: |\n+ Enable or disable the lens shading algorithm.\n+\n ...\ndiff --git a/src/libcamera/control_ids_draft.yaml b/src/libcamera/control_ids_draft.yaml\nindex 03309eeac34f..14026de46ad6 100644\n--- a/src/libcamera/control_ids_draft.yaml\n+++ b/src/libcamera/control_ids_draft.yaml\n@@ -110,20 +110,6 @@ controls:\n row and the start of exposure of the last row. Currently identical to\n ANDROID_SENSOR_ROLLING_SHUTTER_SKEW\n \n- - LensShadingMapMode:\n- type: int32_t\n- direction: inout\n- description: |\n- Control to report if the lens shading map is available. Currently\n- identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.\n- enum:\n- - name: LensShadingMapModeOff\n- value: 0\n- description: No lens shading map mode is available.\n- - name: LensShadingMapModeOn\n- value: 1\n- description: The lens shading map mode is available.\n-\n - PipelineDepth:\n type: int32_t\n direction: out\n","prefixes":["v1","11/12"]}